Potential fix for pull request finding 'CodeQL / Uncontrolled command line'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Author: BenWestgate

tools/bitcoin_core_main_smoke.py

@@ -29,15 +29,24 @@ def main() -> None:
     parser.add_argument("--bitcoind", default="bitcoind")
     parser.add_argument("--bitcoin-cli", default="bitcoin-cli")
     arguments = parser.parse_args()
+    allowed_bitcoind = {"bitcoind"}
+    allowed_bitcoin_cli = {"bitcoin-cli"}
+    if arguments.bitcoind not in allowed_bitcoind:
+        raise RuntimeError("unsupported bitcoind executable")
+    if arguments.bitcoin_cli not in allowed_bitcoin_cli:
+        raise RuntimeError("unsupported bitcoin-cli executable")
 
     with tempfile.TemporaryDirectory(prefix="codex32-core-main-") as temporary:
         datadir = Path(temporary)
+        real_bitcoind = shutil.which(arguments.bitcoind)
+        if real_bitcoind is None:
+            raise RuntimeError("bitcoind was not found")
         real_cli = shutil.which(arguments.bitcoin_cli)
         if real_cli is None:
             raise RuntimeError("bitcoin-cli was not found")
         daemon = subprocess.Popen(
             [
-                arguments.bitcoind,
+                real_bitcoind,
                 "-chain=main",
                 f"-datadir={datadir}",
                 "-server=1",