From 3275b751eb526f94d789f3e7ad036c5bee2d4beb Mon Sep 17 00:00:00 2001 From: Kinflou Date: Thu, 12 Nov 2026 12:23:20 +0800 Subject: [PATCH 1/4] Bump core to a5bebdf (core#263: unverified::frozen_reasons) --- codegen/Cargo.toml | 4 ++-- conformance/Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/codegen/Cargo.toml b/codegen/Cargo.toml index 9893dea..ca4a3ce 100644 --- a/codegen/Cargo.toml +++ b/codegen/Cargo.toml @@ -12,7 +12,7 @@ license = "GPL-3.0-only" # The IR only (`default-features = false`): a generator reads frozen IR and # never parses, and without core's parser (tree-sitter) a generator binary # can be built for `wasm32-wasip1`. -comline-core = { git = "https://github.com/ComlineProject/core", rev = "35ab4b801c9b35af591fb48972407468c8e8af24", default-features = false } +comline-core = { git = "https://github.com/ComlineProject/core", rev = "a5bebdfbf71c57dba742a465bd4a08d53d650e56", default-features = false } eyre = "0.6.8" serde_json = "1.0" @@ -30,4 +30,4 @@ schemars = "=1.2.3" jsonschema = { version = "=0.58.6", default-features = false } toml = "0.8" # The tests compile schemas, so they need core's compiler. -comline-core = { git = "https://github.com/ComlineProject/core", rev = "35ab4b801c9b35af591fb48972407468c8e8af24" } +comline-core = { git = "https://github.com/ComlineProject/core", rev = "a5bebdfbf71c57dba742a465bd4a08d53d650e56" } diff --git a/conformance/Cargo.toml b/conformance/Cargo.toml index 80697c3..90b06de 100644 --- a/conformance/Cargo.toml +++ b/conformance/Cargo.toml @@ -11,7 +11,7 @@ publish = false # to their own repos. See design/runtime-repo-structure.md (rollout step 3). [dependencies] -comline-core = { git = "https://github.com/ComlineProject/core", rev = "35ab4b801c9b35af591fb48972407468c8e8af24" } +comline-core = { git = "https://github.com/ComlineProject/core", rev = "a5bebdfbf71c57dba742a465bd4a08d53d650e56" } # Not dev-only: a `Fixture` states the `Mode` it exercises, so the contract # types are part of the corpus's own public shape. comline-codegen = { path = "../codegen" } From 8fb3f2126f253d9639d17f6ceb42fdb1c1ae6652 Mon Sep 17 00:00:00 2001 From: Kinflou Date: Thu, 12 Nov 2026 12:23:49 +0800 Subject: [PATCH 2/4] conformance: pin the generators at their core-a5bebdf bumps and re-bless handshake_none The generators now render an @unverified protocol's frozen reasons, not a recomputed cause, so the '(handshake `none`)' parenthetical is gone. --- conformance/Cargo.toml | 4 ++-- conformance/tests/golden/handshake_none/rust/conformance.rs | 4 ++-- .../tests/golden/handshake_none/typescript/conformance.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/conformance/Cargo.toml b/conformance/Cargo.toml index 90b06de..7ca9183 100644 --- a/conformance/Cargo.toml +++ b/conformance/Cargo.toml @@ -19,5 +19,5 @@ comline-codegen = { path = "../codegen" } [dev-dependencies] eyre = "0.6.8" serde_json = "1.0" -comline-codegen-rust = { git = "https://github.com/ComlineProject/comline-rust", rev = "7763f1bdf085b57b6c46d1b1be99da7e522f430b" } -comline-codegen-typescript = { git = "https://github.com/ComlineProject/comline-typescript", rev = "79e15384f2d9e0644971bf6282d601182afb1537" } +comline-codegen-rust = { git = "https://github.com/ComlineProject/comline-rust", rev = "e11bff7513a80ada7a22451bc356620882002a71" } +comline-codegen-typescript = { git = "https://github.com/ComlineProject/comline-typescript", rev = "1917f8204595926d0c7b0c4c6c36093b7237302b" } diff --git a/conformance/tests/golden/handshake_none/rust/conformance.rs b/conformance/tests/golden/handshake_none/rust/conformance.rs index 207dc47..19b6f1e 100644 --- a/conformance/tests/golden/handshake_none/rust/conformance.rs +++ b/conformance/tests/golden/handshake_none/rust/conformance.rs @@ -35,7 +35,7 @@ pub trait Gateway { pub const GATEWAY_CALLS: &[&str] = &["ping"]; -/// **Unverified:** gives up schema agreement and encoding agreement (handshake `none`). +/// **Unverified:** gives up schema agreement and encoding agreement. /// Reason given: the gateway predates Comline pub struct GatewayDispatcher(pub S); @@ -105,7 +105,7 @@ impl GatewayDispatcher { } } -/// **Unverified:** gives up schema agreement and encoding agreement (handshake `none`). +/// **Unverified:** gives up schema agreement and encoding agreement. /// Reason given: the gateway predates Comline /// Calls protocol `Gateway` on the other end of a connection: the peer a /// `Connection` reaches, or the one a handler was given. diff --git a/conformance/tests/golden/handshake_none/typescript/conformance.ts b/conformance/tests/golden/handshake_none/typescript/conformance.ts index 9681f61..199024f 100644 --- a/conformance/tests/golden/handshake_none/typescript/conformance.ts +++ b/conformance/tests/golden/handshake_none/typescript/conformance.ts @@ -39,7 +39,7 @@ export interface Gateway { export const GATEWAY_CALLS = ["ping"] as const; /** - * **Unverified:** gives up schema agreement and encoding agreement (handshake `none`). + * **Unverified:** gives up schema agreement and encoding agreement. * Reason given: the gateway predates Comline */ export class GatewayDispatcher implements Dispatch { @@ -85,7 +85,7 @@ export class GatewayDispatcher implements Dispatch { } /** - * **Unverified:** gives up schema agreement and encoding agreement (handshake `none`). + * **Unverified:** gives up schema agreement and encoding agreement. * Reason given: the gateway predates Comline */ /** Calls protocol `Gateway` on the other end of a connection: the peer a `Connection` reaches, or the one a handler was given. */ From cd63473e7029542ef1358accbc5fc61059824577 Mon Sep 17 00:00:00 2001 From: Kinflou Date: Thu, 12 Nov 2026 12:46:03 +0800 Subject: [PATCH 3/4] Bump core to 263e583 (core#263 squash-merged: unverified::frozen_reasons) --- codegen/Cargo.toml | 4 ++-- conformance/Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/codegen/Cargo.toml b/codegen/Cargo.toml index ca4a3ce..9c2667f 100644 --- a/codegen/Cargo.toml +++ b/codegen/Cargo.toml @@ -12,7 +12,7 @@ license = "GPL-3.0-only" # The IR only (`default-features = false`): a generator reads frozen IR and # never parses, and without core's parser (tree-sitter) a generator binary # can be built for `wasm32-wasip1`. -comline-core = { git = "https://github.com/ComlineProject/core", rev = "a5bebdfbf71c57dba742a465bd4a08d53d650e56", default-features = false } +comline-core = { git = "https://github.com/ComlineProject/core", rev = "263e58378bb7efcaa466542ca644228ad14e2884", default-features = false } eyre = "0.6.8" serde_json = "1.0" @@ -30,4 +30,4 @@ schemars = "=1.2.3" jsonschema = { version = "=0.58.6", default-features = false } toml = "0.8" # The tests compile schemas, so they need core's compiler. -comline-core = { git = "https://github.com/ComlineProject/core", rev = "a5bebdfbf71c57dba742a465bd4a08d53d650e56" } +comline-core = { git = "https://github.com/ComlineProject/core", rev = "263e58378bb7efcaa466542ca644228ad14e2884" } diff --git a/conformance/Cargo.toml b/conformance/Cargo.toml index 7ca9183..4971015 100644 --- a/conformance/Cargo.toml +++ b/conformance/Cargo.toml @@ -11,7 +11,7 @@ publish = false # to their own repos. See design/runtime-repo-structure.md (rollout step 3). [dependencies] -comline-core = { git = "https://github.com/ComlineProject/core", rev = "a5bebdfbf71c57dba742a465bd4a08d53d650e56" } +comline-core = { git = "https://github.com/ComlineProject/core", rev = "263e58378bb7efcaa466542ca644228ad14e2884" } # Not dev-only: a `Fixture` states the `Mode` it exercises, so the contract # types are part of the corpus's own public shape. comline-codegen = { path = "../codegen" } From d6ca41a1e5aeb13cc1e9fdf86de6ebe876a535bf Mon Sep 17 00:00:00 2001 From: Kinflou Date: Thu, 12 Nov 2026 12:46:33 +0800 Subject: [PATCH 4/4] conformance: pin the generators at their core-263e583 bumps --- conformance/Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/conformance/Cargo.toml b/conformance/Cargo.toml index 4971015..ec52af5 100644 --- a/conformance/Cargo.toml +++ b/conformance/Cargo.toml @@ -19,5 +19,5 @@ comline-codegen = { path = "../codegen" } [dev-dependencies] eyre = "0.6.8" serde_json = "1.0" -comline-codegen-rust = { git = "https://github.com/ComlineProject/comline-rust", rev = "e11bff7513a80ada7a22451bc356620882002a71" } -comline-codegen-typescript = { git = "https://github.com/ComlineProject/comline-typescript", rev = "1917f8204595926d0c7b0c4c6c36093b7237302b" } +comline-codegen-rust = { git = "https://github.com/ComlineProject/comline-rust", rev = "eebf97ad3e09b760a1be51bf359a8b3b6e36c54d" } +comline-codegen-typescript = { git = "https://github.com/ComlineProject/comline-typescript", rev = "964278cb8f6608afa66a6d99430886db57c0caf0" }