From debec7c19b5a31521a279cc9e3d34ca12100e76c Mon Sep 17 00:00:00 2001 From: Conduction Release Bot Date: Fri, 28 Aug 2026 10:51:41 +0200 Subject: [PATCH] fix(e2e): move the three fixme reasons where the gate can read them MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The skip-discipline gate now runs here (hydra-gates 1.10.0, #777) and reports three V3 findings — exclusions with no reason recorded: 1 workflows/crud-persistence.spec.ts 1 workflows/org-export-workflow.spec.ts 1 workflows/organisatie-crud.spec.ts All three DO have a reason. None of them are where a machine can see it: - crud-persistence : a twelve-line comment above the test - org-export : in the test title, in parentheses - organisatie-crud : in the test title, in parentheses The gate reads report.json, and `test.fixme(title, fn)` records no description there. A title is not an annotation, and a comment is invisible to every tool. So each reason moves into `test.fixme(true, '')` and the titles lose the parenthetical, which is what a title should look like anyway. Nothing about what runs changes: the same three tests are still excluded, for the same documented reasons. They are simply attributable now, which is the whole point of turning the gate on. Verified: npm ci rc=0, npm run lint rc=0 (0 errors), prettier clean, and `playwright test --list` compiles all 14 tests across the three files. Part of ConductionNL/.github#609. --- tests/e2e/workflows/crud-persistence.spec.ts | 8 +++++--- tests/e2e/workflows/org-export-workflow.spec.ts | 3 ++- tests/e2e/workflows/organisatie-crud.spec.ts | 8 +++++--- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/tests/e2e/workflows/crud-persistence.spec.ts b/tests/e2e/workflows/crud-persistence.spec.ts index 7587c34e..849ed64a 100644 --- a/tests/e2e/workflows/crud-persistence.spec.ts +++ b/tests/e2e/workflows/crud-persistence.spec.ts @@ -181,9 +181,11 @@ test.describe('Contactpersoon CRUD-persistence', () => { // pre-fill assertion below (the editor loads the row's stored values) and by // the data-layer findAll cross-check. Re-enable once the deployed shell // renders an object-data detail surface for the View action. - test.fixme('detail (View) -> shows the entered field values', async ({ - page, - }) => { + test('detail (View) -> shows the entered field values', async ({ page }) => { + test.fixme( + true, + "the deployed nextcloud-vue CnIndexPage shell opens Nextcloud's generic right sidebar (Files / Notes / Tags / Audit trail) for the View action rather than an object-data detail panel, so the stored field values are not rendered for a UI assertion. A deployed-shell limitation, not a stackiq bug: persistence is proven by the Edit form pre-fill assertion below and the data-layer findAll cross-check.", + ) await gotoAppRoute(page, '/contactpersonen') await dismissSupportDialog(page) diff --git a/tests/e2e/workflows/org-export-workflow.spec.ts b/tests/e2e/workflows/org-export-workflow.spec.ts index e53868cf..f8e4d01f 100644 --- a/tests/e2e/workflows/org-export-workflow.spec.ts +++ b/tests/e2e/workflows/org-export-workflow.spec.ts @@ -190,7 +190,8 @@ test('export workflow: the seeded export org is retrievable via findAll', async // container; every export endpoint returns "AMEF register ID is not // configured"). Asserts a real AMEF/ArchiMate XML artifact once configured. // --------------------------------------------------------------------------- -test.fixme('export workflow: produces an AMEF/ArchiMate artifact for the org (blocked: AMEF register not configured)', async () => { +test('export workflow: produces an AMEF/ArchiMate artifact for the org', async () => { + test.fixme(true, 'blocked: the AMEF register is not configured on this instance') const res = await apiCtx.get( `/index.php/apps/stackiq/api/archimate/export/organization/${seededOrgId}?modules=true&deelnames=true`, ) diff --git a/tests/e2e/workflows/organisatie-crud.spec.ts b/tests/e2e/workflows/organisatie-crud.spec.ts index f860f73f..b5c14a02 100644 --- a/tests/e2e/workflows/organisatie-crud.spec.ts +++ b/tests/e2e/workflows/organisatie-crud.spec.ts @@ -183,9 +183,11 @@ test('the create action opens the create dialog', async ({ page }) => { // exactly like a passing test, and this one hid the fact that the whole create // path had moved. // --------------------------------------------------------------------------- -test.fixme('UI create -> new organisation card appears (unverified: body still drives the removed ObjectModal cascade)', async ({ - page, -}) => { +test('UI create -> new organisation card appears', async ({ page }) => { + test.fixme( + true, + 'unverified: the body still drives the removed ObjectModal cascade', + ) await navClickTo(page, 'Organisations') await dismissSupportDialog(page) const uiOrgName = `${RUN_ID} UI Organisatie`