From f6b66ae214f71d1ae18421f397f90ddfa2657eec Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Thu, 24 Sep 2026 11:08:38 +0200 Subject: [PATCH] Pin json below 3.0 json 3.0 is incompatible with current Rails test setups until rails/rails#58601 makes it into a release. Pin below 3.0 in the Gemfile and appraisal gemfiles, and tell dependabot to skip >= 3.0.0. --- .github/dependabot.yml | 2 ++ Appraisals | 2 ++ Gemfile | 2 ++ gemfiles/rails_7.2.gemfile | 1 + gemfiles/rails_8.0.gemfile | 1 + gemfiles/rails_8.1.gemfile | 1 + gemfiles/rails_edge.gemfile | 1 + 7 files changed, 10 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index af01eb6b..ba5491fb 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -16,6 +16,8 @@ updates: ignore: - dependency-name: sqlite3 versions: ">= 2" # FIXME: Remove when rails/rails#51636 will be released + - dependency-name: json + versions: ">= 3.0.0" # TODO: remove when a Rails release includes rails/rails#58601 - package-ecosystem: npm directory: "/" schedule: diff --git a/Appraisals b/Appraisals index bfba44e8..910254fa 100644 --- a/Appraisals +++ b/Appraisals @@ -1,5 +1,7 @@ # frozen_string_literal: true +gem 'json', '< 3.0' # TODO: relax this constraint when rails/rails#58601 will be released + appraise 'rails-7.2' do gem 'rails', '~> 7.2.0' diff --git a/Gemfile b/Gemfile index 0eb554f0..aa5ee83a 100644 --- a/Gemfile +++ b/Gemfile @@ -5,6 +5,8 @@ source 'https://rubygems.org' # Specify your gem's dependencies in client_side_validations.gemspec gemspec +gem 'json', '< 3.0' # TODO: relax this constraint when rails/rails#58601 will be released + gem 'appraisal2' gem 'byebug' gem 'm' diff --git a/gemfiles/rails_7.2.gemfile b/gemfiles/rails_7.2.gemfile index 8b8082cf..42a6e3a8 100644 --- a/gemfiles/rails_7.2.gemfile +++ b/gemfiles/rails_7.2.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "json", "< 3.0" gem "appraisal2" gem "byebug" gem "m" diff --git a/gemfiles/rails_8.0.gemfile b/gemfiles/rails_8.0.gemfile index 9063b737..66b2f6a0 100644 --- a/gemfiles/rails_8.0.gemfile +++ b/gemfiles/rails_8.0.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "json", "< 3.0" gem "appraisal2" gem "byebug" gem "m" diff --git a/gemfiles/rails_8.1.gemfile b/gemfiles/rails_8.1.gemfile index 26dbbf87..95eb7871 100644 --- a/gemfiles/rails_8.1.gemfile +++ b/gemfiles/rails_8.1.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "json", "< 3.0" gem "appraisal2" gem "byebug" gem "m" diff --git a/gemfiles/rails_edge.gemfile b/gemfiles/rails_edge.gemfile index d871346e..4a5f918a 100644 --- a/gemfiles/rails_edge.gemfile +++ b/gemfiles/rails_edge.gemfile @@ -2,6 +2,7 @@ source "https://rubygems.org" +gem "json", "< 3.0" gem "appraisal2" gem "byebug" gem "m"