vms.remote.ts has some code that needs to be cleaned up for getting lists of VMs.
there are three instances of the same massive sql query. these and the surrounding code such as mapVmRow could likely be combined into one function for better code reuse.
|
const result = await db.execute(sql` |
|
const result = await db.execute(sql` |
|
const result = await db.execute(sql` |
There is also likely other code in this that could simplified or documented better.
As an example, the getKnownLive, mergeKnownLive, and mapVmRow functions seem like they could be merged together, and it doesn't seem self explanatory what "known live" even means, but that could be due to me being unfamiliar with this section of the code base.
vms.remote.ts has some code that needs to be cleaned up for getting lists of VMs.
there are three instances of the same massive sql query. these and the surrounding code such as mapVmRow could likely be combined into one function for better code reuse.
dashboard/apps/dashboard/src/lib/remote/vms.remote.ts
Line 197 in 0b813b3
dashboard/apps/dashboard/src/lib/remote/vms.remote.ts
Line 241 in 0b813b3
dashboard/apps/dashboard/src/lib/remote/vms.remote.ts
Line 403 in 0b813b3
There is also likely other code in this that could simplified or documented better.
As an example, the getKnownLive, mergeKnownLive, and mapVmRow functions seem like they could be merged together, and it doesn't seem self explanatory what "known live" even means, but that could be due to me being unfamiliar with this section of the code base.