diff --git a/pull_request_template.md b/pull_request_template.md deleted file mode 100644 index ceb04880..00000000 --- a/pull_request_template.md +++ /dev/null @@ -1,36 +0,0 @@ -# What was the ticket? - -WT-65 UI Design: Construct JSX page to match the UI of Teams landing page. - [Link to Ticket](https://generatenu.atlassian.net/jira/software/projects/WT/boards/2?selectedIssue=WT-65) - -# What did I do? - -Created new Teams page with route at /teams, based off the figma design for it. Currently waiting for images to populate -the rest of the page, and works to be completed on the figma for an expanded view of each of the teams - -# How did I test it? - -Describe in detail steps you used to test the changes you have made. -Key Parts - -Compared the figma and current page to ensure it correctly reflected what the design should be. Ran tests for resizing the window to ensure page -did not ahve any scaling issues. - - Required checks: - -- [Y] Did you conduct a self-review? -- [NA] Have you written unit or integration tests? - -# What could go wrong in the future? What parts of your code should the reviewer pay the most attention to? - -Describe aspects of the PR that may become problems in the future. -Key Questions - -Currently the page doesn't go anywhere, it is mainly jsut a simple gray space to build onto morechanges as figma designs are updated - -# Additional comments for the reviewers - -[!image](./public/images/PRImages/Screenshot%202023-03-20%20at%208.15.02%20PM.png) - -![image](./public/images/PRImages/Screenshot%202023-03-20%20204229.png) -![image](./public/images/PRImages/Screenshot%202023-03-20%20204258.png) diff --git a/src/component/ScrollToTop.js b/src/component/ScrollToTop.js index 8bb9e4c7..c006d740 100644 --- a/src/component/ScrollToTop.js +++ b/src/component/ScrollToTop.js @@ -3,11 +3,11 @@ import { useLocation } from "react-router-dom"; export default function ScrollToTop() { - const { pathName } = useLocation; + const { pathname } = useLocation(); useEffect(() => { window.scrollTo(0, 0); - }, [pathName]); + }, [pathname]); return null; -} \ No newline at end of file +}