diff --git a/planning/session-log.md b/planning/session-log.md index 585d800..f3851af 100644 --- a/planning/session-log.md +++ b/planning/session-log.md @@ -2,6 +2,13 @@ Newest first. Keep each entry to a few lines: what was done, what is next, where things are. +## 2026-10-01 — Previews live; open pull requests brought up to date (B. Pacheco with Claude) +- #124 (D-025) and #126 merged; the Pages source is switched to the `gh-pages` branch. The site and every `pr-/` preview are served from it: `https://genomicdatainfrastructure.github.io/system-architecture/` and `…/pr-/`. +- Lessons from the switch, for the record: the first switch was saved with branch `main`, which served a Jekyll rendering of the repository for a few minutes; it was set right with `gh api -X PUT repos/…/pages -f build_type=legacy -f 'source[branch]=gh-pages' -f 'source[path]=/'`, and a build had to be requested (`gh api -X POST repos/…/pages/builds`) because the switch alone started none. Previews come from pushes: closing and reopening a pull request started no run. +- #126: `.nojekyll` is now created by the production deploy only (`touch build/.nojekyll`), not from `static/`, because the deploy action never deletes it and the folder of a closed pull request survived as an empty `pr-124/.nojekyll`. That leftover was removed by hand from `gh-pages`. +- The six open page branches (#84, #92, #110, #114, #117, #118) merged `main` (a merge, not a rebase: shared branches, signed commits). Only #118 conflicted, in chapter 11 (`genome-edic-operational`): main's GDI D3.4 citation kept, together with the branch's link to the ADR's *Implementation in steps*. #110 also closed a merge of 3.3 into 3.1 that had been left uncommitted in the primary checkout, then merged the updated 3.3. All six have a passing *Check* run, a preview comment and a live preview. +- Next: reviewers for the six branches at the kick-off (they can now read each page in its preview); legal review of the VI.1.3 reading in #118. + ## 2026-10-01 — Reader test of the seven open pages against the published governance; fixes applied (B. Pacheco with Claude) - Fact check of 8.12, ADR-0002, 12 Glossary, 1.3, 3.1, 2.2 and 3.3 against the full D2.4 (body and annex, version 2025-12), role-playing legal expert, DPO, implementer, security advisor, ELSI specialist and policy maker. Findings and fixes are posted on each page issue (#88, #83, #69, #13, #11, #7, #4). The main ones: - **VI.1.3** already gives the Member Country the national strategy for downstream disclosure and the nomination of 1+MG Data Holders: the basis of ADR-0002 option B1. What stays open (#85) is the level of the choice and whether a country may nominate no 1+MG Data Holder. @@ -15,12 +22,12 @@ Newest first. Keep each entry to a few lines: what was done, what is next, where - GDI D3.4 (dropped into `~/Downloads` during the session) confirms the claims cited to it: the May 2025 member-state vote for decentralised controllership as an interim governance until genomics is shared through the EHDS (section 4.3); the Genome EDIC can't be assumed before GDI ends (section 1); Genome of Europe data for the Genome of Europe consortium (sections 4.3, 4.8); allele frequencies and metadata search without an access decision (sections 4.1.2, 4.8). Two nuances recorded on the pages: D3.4 frames the Genome of Europe data as primary use under that project's own legal basis (the architecture reads them as externally governed datasets), and it expects the project to end about a year after late 2025; the pages say March 2027 (architecture lead). Section numbers added in prose next to each ``; `gdi-d3.4` set to `published` in `sources.json`. - Next: - reviewers for the six branches at the kick-off; legal review of the VI.1.3 reading in #118; - - per-PR site previews for reviewers (suggested; GitHub Pages serves one site, so previews go into per-PR subfolders of the `gh-pages` branch, or a preview service). + - per-PR site previews for reviewers (suggested; GitHub Pages serves one site, so previews go into per-PR subfolders of the `gh-pages` branch, or a preview service). Done the same day: D-025, entry above. ## 2026-10-01 — Pull request previews (B. Pacheco with Claude) - Decided D-025: every pull request gets a rendered preview of the whole site at `…/system-architecture/pr-/`, on the `gh-pages` branch next to the published site; Netlify / Cloudflare Pages documented as the alternative. - Done: `.github/workflows/preview.yml` (build with `PR_NUMBER`, publish to `pr-/`, one comment per pull request, folder removed on close); `deploy.yml` now publishes `main` to the root of `gh-pages` and keeps the `pr-*` folders; `docusaurus.config.ts` derives `baseUrl`, `noIndex` and a preview banner from `PR_NUMBER`. Checked locally: `PR_NUMBER=999 npm run build` passes with `onBrokenLinks`/`onBrokenAnchors: 'throw'`, and every asset and page link is under `/system-architecture/pr-999/` (`` uses `useBaseUrl`). CONTRIBUTING ("Previews and publication"), choreography steps 6 and 9, plan and changelog updated. -- Next, once this is merged (in this order): wait for the *Deploy to GitHub Pages* run to create the `gh-pages` branch; in *Settings > Pages* switch the source to *Deploy from a branch*, `gh-pages`, `/ (root)`; check the site and open a test pull request to see its preview comment. Until the switch, the published site is simply not updated. +- Next, once this is merged (in this order): wait for the *Deploy to GitHub Pages* run to create the `gh-pages` branch; in *Settings > Pages* switch the source to *Deploy from a branch*, `gh-pages`, `/ (root)`; check the site and open a test pull request to see its preview comment. Until the switch, the published site is simply not updated. Done the same day: entry above. ## 2026-09-28 — 3.3 and 2.2 re-checked against the glossary, ADR-0002 and 1.3 (B. Pacheco with Claude) - 3.3 *Scopes* (#13, draft PR #84): the Member Country chooses between the two 1+MG types, and the level of the choice is still to be confirmed (as in ADR-0002); flag what GDI delivers (D-006, cites `gdi-d3.4`). The glossary already follows 3.3.