From a3096f8245631f826f1fe51402829cca4e200fd4 Mon Sep 17 00:00:00 2001 From: Aleksandr Pirogov Date: Tue, 16 Jun 2026 09:20:05 +0300 Subject: [PATCH] Fix implisit conversion from bool to int32 * sequence number is less or eq than latest received messqge - it's a duplicated of an old message, it needs to be skipped. Returing 0 --- rd-cpp/src/rd_framework_cpp/src/main/wire/SocketWire.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rd-cpp/src/rd_framework_cpp/src/main/wire/SocketWire.cpp b/rd-cpp/src/rd_framework_cpp/src/main/wire/SocketWire.cpp index be594ed44..bc7c91c40 100644 --- a/rd-cpp/src/rd_framework_cpp/src/main/wire/SocketWire.cpp +++ b/rd-cpp/src/rd_framework_cpp/src/main/wire/SocketWire.cpp @@ -329,7 +329,8 @@ int32_t SocketWire::Base::read_package() const send_ack(seqn); if (seqn <= max_received_seqn && seqn != 1) { - return true; + logger->trace("{}: duplicate package seqn={} (max_received_seqn={}), skipping", this->id, seqn, max_received_seqn); + return 0; } max_received_seqn = seqn;