From cfd3d9a98954398338315e17852649f809eb956b Mon Sep 17 00:00:00 2001
From: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com>
Date: Wed, 28 Oct 2026 01:58:40 +0000
Subject: [PATCH] [TRTLLM-17261][infra] Give the trtllm-serve test directories
 the owners of the code they test

Add three CODEOWNERS rules so that test ownership follows source
ownership, as it already does for /tests/unittest/llmapi and
/tests/unittest/_torch/visual_gen:

- /tests/test_common/serve -> @NVIDIA/trt-llm-runtime-devs
  (shared fixtures and fakes for trtllm-serve tests)
- /tests/unittest/serve -> @NVIDIA/trt-llm-runtime-devs
  (tests mirroring tensorrt_llm/serve/, owned by runtime-devs)
- /tests/unittest/serve/api/visual_gen -> @NVIDIA/trt-llm-torch-visual-gen-devs
  (VisualGen serving tests)

Without these rules the directories fall to @NVIDIA/trt-llm-devs through
the broad /tests/test_common and /tests/unittest fallback rules. The
directories do not exist on main yet; a CODEOWNERS rule that matches no
file is valid to GitHub and takes effect as soon as the upcoming
test-only change creates them. Each line is placed after the broader
rule it overrides, because the last matching pattern wins.

No behavior change: no code, test or test-list change.

Signed-off-by: JunyiXu-nv <219237550+JunyiXu-nv@users.noreply.github.com>
---
 .github/CODEOWNERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 4ca9dc19d450..ba31e7647372 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -135,6 +135,7 @@
 /tensorrt_llm/serve @NVIDIA/trt-llm-runtime-devs
 /tensorrt_llm/tokenizer @NVIDIA/trt-llm-runtime-devs
 /tensorrt_llm/usage @NVIDIA/trt-llm-runtime-devs
+/tests/test_common/serve @NVIDIA/trt-llm-runtime-devs
 /tests/torch @NVIDIA/trt-llm-runtime-devs
 /tests/unittest/_torch/compilation @NVIDIA/trt-llm-runtime-devs
 # Matches nothing today -- PR #17968 moved these tests out -- but kept so a recreated custom_ops/ lands here instead of on the global fallback.
@@ -155,6 +156,7 @@
 /tests/unittest/llmapi @NVIDIA/trt-llm-runtime-devs
 /tests/unittest/llmapi/apps/*multimodal* @NVIDIA/trt-llm-runtime-devs @NVIDIA/trt-llm-models-devs
 /tests/unittest/pyexecutor @NVIDIA/trt-llm-runtime-devs
+/tests/unittest/serve @NVIDIA/trt-llm-runtime-devs
 
 # ===== KERNELS - MISC =====
 /cpp/include/tensorrt_llm/deep_gemm @NVIDIA/trt-llm-kernels-devs
@@ -377,6 +379,7 @@
 /tests/integration/defs/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs
 /tests/scripts/perf-sanity/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs
 /tests/unittest/_torch/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs
+/tests/unittest/serve/api/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs
 /tests/unittest/visual_gen @NVIDIA/trt-llm-torch-visual-gen-devs
 
 # ===== SCAFFOLDING =====