From e3a18e1cc204f7b6f0ad9a555fc402ce0ab70e71 Mon Sep 17 00:00:00 2001 From: "kitokey-marc[bot]" <356215105+kitokey-marc[bot]@users.noreply.github.com> Date: Fri, 13 Nov 2026 13:00:11 +0100 Subject: [PATCH] capture: Feed's drop matches every variant, no irrefutable if let off Linux On Windows and macOS, Feed has one variant, Cpal, so the `if let` in its Drop was irrefutable and rustc warned (irrefutable_let_patterns, seen in the Windows run of main). A match with the Linux-only Passive arm under its cfg compiles clean on every system. Supersedes #644. Agent-Session: 14f73956-90b9-46a3-9fcc-52dc45c43948 Co-authored-by: dime-hermes[bot] <349604419+dime-hermes[bot]@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 --- modules/capture/src/main.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/capture/src/main.rs b/modules/capture/src/main.rs index 645de6bd..8d531816 100644 --- a/modules/capture/src/main.rs +++ b/modules/capture/src/main.rs @@ -508,8 +508,10 @@ impl Feed { impl Drop for Feed { fn drop(&mut self) { - if let Feed::Cpal { closing, .. } = self { - closing.store(true, Ordering::SeqCst); + match self { + Feed::Cpal { closing, .. } => closing.store(true, Ordering::SeqCst), + #[cfg(target_os = "linux")] + Feed::Passive(_) => {} } } }