Is combineWithConfig no longer supported?

[fpaaske]

As title suggests, I'm no longer able to get combineWithConfig to work in my setup, even though it's present in the schema.json.
Is this no longer supported?

[NathanWalker]

Ever since v20 and the move to more Nx style valid definitions in project.json, combineWithConfig wasn't needed.
There's still a way to make it work, just let me know your thoughts.
https://github.com/NativeScript/nx/releases/tag/20.0.0
https://github.com/NativeScript/nx/wiki/Migrate-guide-for-Nx-19-to-20

[fpaaske]

Yes, it looks like a good upgrade, and I followed the migration guide to set things up nicely.
The main issue with the new config is that the shared target config in nx.json is not merged with the corresponding project.json. It's always replaced with the more local config.

For example;

I have this in nx.json:

  "targetDefaults": {
    "build": {
      "cache": true,
      "dependsOn": ["^build"],
      "inputs": ["production", "^production"],
      "defaultConfiguration": "prod",
      "configurations": {
        "prod": {
          "fileReplacements": [
            {
              "replace": "./src/environments/environment.ts",
              "with": "./src/environments/environment.prod.ts"
            }
          ]
        },
        "preprod": {
          "fileReplacements": [
            {
              "replace": "./src/environments/environment.ts",
              "with": "./src/environments/environment.preprod.ts"
            }
          ]
        },
        "test": {
          "fileReplacements": [
            {
              "replace": "./src/environments/environment.ts",
              "with": "./src/environments/environment.test.ts"
            }
          ]
        },
        "dev": {
          "fileReplacements": [
            {
              "replace": "./src/environments/environment.ts",
              "with": "./src/environments/environment.dev.ts"
            }
          ]
        },
        "local": {
          "fileReplacements": [
            {
              "replace": "./src/environments/environment.ts",
              "with": "./src/environments/environment.local.ts"
            }
          ]
        }
      }
    },

Then, in one of the apps project.json I want to do something like this:

  "targets": {
    "build": {
      "executor": "@nativescript/nx:build",
      "options": {
        ..
      },
      "configurations": {
        "prod": {
          "fileReplacements": [
            {
              "replace": "./App_Resources/iOS/GoogleService-Info.plist",
              "with": "./firebase/GoogleService-Info.plist"
            }
          ]
        },
        "test": {
          "fileReplacements": [
            {
              "replace": "./App_Resources/iOS/GoogleService-Info.plist",
              "with": "./firebase/GoogleService-Info-test.plist"
            }
          ]
        },

But this doesn't work, as the the default config from nx.json is completely overwritten, so I loose the file replacement for the environments.

And even when not using the fileReplacements in project.json I still loose the defaults from nx.json:

  "targets": {
    "build": {
      "executor": "@nativescript/nx:build",
      "options": {
        ..
      },
      "configurations": {
        "test": {
          "flags": "--config=nativescript.config.test.ts",
        },

This is a bit frustrating as now I have to copy all the configuration from nx.json everytime I have something I want to overwrite locally. And on top of that I have to do this for every target in the project.json.

It could be that I am doing something wrong, or that this is a limitation of NX, I don't know. But I'd love to get some input on how to improve this!

[fpaaske]

I've got another issue with this setup too:

  "targets": {
    "debug": {
      "executor": "@nativescript/nx:debug",
      "options": {
        ..
      },
      "configurations": {
        "prod": {
          // no flags config, using default nativescript.config.ts, id: my.company.app
        },
        "test": {
          "flags": "--config=nativescript.config.test.ts", // id: my.company.app.test
        },

The NX caching will prevent the bundle/app ids to be updated, so after debugging -c=prod I get this error when debugging -c=test:

Application my.company.app.test is not running on device emulator-5554.
This issue may be caused by:
	* crash at startup (try `ns debug android --debug-brk` to check why it crashes)
	* different application identifier in your package.json and in your gradle files (check your identifier in `package.json` and in all *.gradle files in your App_Resources directory)
	* device is locked
	* manual closing of the application

Doing a nx clean will let me debug the app with a new id again, but that kind of defeats one of the biggest advantages to NX, the caching.