Groupby in menu geeft factor expected error in 20.8.0 niet in 17.9.6 op bgt vegetatieobject

[basvanbemmel]

download https://www.pdok.nl/downloadviewer/-/article/basisregistratie-grootschalige-topografie-bgt- , Deel NL, citygml, Met plaatsbepalingspunten
Haal uit zip bgt_vegetatieobject.gml

lees in dmv
container BGT
{
//GeoDMS 20.8.0 comp
//https://app.pdok.nl/lv/bgt/download-viewer/ , Deel NL, citygml, Met plaatsbepalingspunten

unit<Float32> Meter := BaseUnit('m', float32);

parameter<Meter> x_min := 0[Meter];
parameter<Meter> x_max := 280000[Meter];
parameter<Meter> y_min := 300000[Meter];
parameter<Meter> y_max := 625000[Meter];

unit<fpoint> rdc_meter_base : SpatialReference = "EPSG:28992";

unit<fpoint> rdc_meter      := range(rdc_meter_base, point_yx(y_min, x_min), point_yx(y_max, x_max));

unit<uint32> bgt_vegetatieobject
:	StorageName     = "K:/BGT/bgt_vegetatieobject.gml"
,	StorageType     = "gdal.vect"
,	StorageReadOnly = "True"
, 	DialogData      = "rdc_meter"
, 	SyncMode        = "AllTables"
//,	SqlString       = "SELECT * FROM bgt_vegetatieobject WHERE plus_type == 'boom'"
{
}

}

open tabel (let op duurt waarschijnlijk heel lang bij mij een uur). Groupby op "plus_type" kolom.
Error verschijnt in 20.8.0 maar niet 17.9.6

[MaartenHilferink]

Root cause found: this is fallout from the boost::format -> std::format migration, not something specific to the BGT data (the long load time is unrelated — any group-by on any table reproduces it).

DataItemColumn.cpp / OperExprFormat() builds the expression for the aggregation column from a format string that still used boost's %1%/%2%/%3% placeholders. std::vformat leaves such text untouched (it only interprets {}), so for plus_type the generated expression came out literally as

%1%(%2%, %3%)

instead of

modus(/BGT/bgt_vegetatieobject/plus_type, ../GroupBy/per_Row)

which the DMS parser then rejects with "factor expected" — exactly the dialog in the screenshot. 17.9.6 predates the migration, hence the difference.

Fixed on the working branch (85f25bf):

• shv/dll/src/DataItemColumn.cpp — all OperExprFormat() variants converted to positional {0}/{1}/{2}. Positional rather than {} is required because the three arguments (operator name, attribute full name, group-by item) are reused and reordered within one format string, e.g. "{1}[{0}(ID(DomainUnit({2})), {2})]" for first/last, and several variants (sum, min, max, count, bounds, ...) don't use argument 0 at all.
• shv/dll/src/WmsLayer.cpp:456 — same leftovers in TileLoader::report(), which was printing %1%:%2%\nRequest: %3%... instead of the actual WMS request/response in the message log. Not user-reported, but the same defect class.

A repo-wide grep for %[0-9]% over the C++ sources is now clean, so these were the last two.

Builds clean; still to be verified interactively in the GUI (group-by on a table column).

[MaartenHilferink]

Fix will be available in GeoDms 20.9.0

[basvanbemmel]

ok mooi dank