From cc9b4577e91707a0fa483ebd81c7126a6faf6a2d Mon Sep 17 00:00:00 2001 From: RobLe3 Date: Fri, 6 Nov 2026 18:16:43 +0100 Subject: [PATCH 1/2] fix: refuse disabled TLS certificate verification --- src/iicp_client/client.py | 6 ++++++ src/iicp_client/types.py | 1 + tests/test_tls_policy.py | 22 ++++++++++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 tests/test_tls_policy.py diff --git a/src/iicp_client/client.py b/src/iicp_client/client.py index 38a53f0..73e33cc 100644 --- a/src/iicp_client/client.py +++ b/src/iicp_client/client.py @@ -123,6 +123,12 @@ class IicpClient: def __init__(self, config: ClientConfig | None = None) -> None: self._cfg = config or ClientConfig() + if self._cfg.tls_verify is False: + raise IicpError( + code="SDK-05", + message="tls_verify=False is not supported; TLS certificate verification is required", + component="sdk", + ) if self._cfg.timeout_ms > _MAX_TIMEOUT_MS: # SDK-04: reject oversized timeouts at construction time raise ValueError(f"timeout_ms must be ≤ {_MAX_TIMEOUT_MS}; got {self._cfg.timeout_ms}") diff --git a/src/iicp_client/types.py b/src/iicp_client/types.py index 3a549fa..65e5ee9 100644 --- a/src/iicp_client/types.py +++ b/src/iicp_client/types.py @@ -38,6 +38,7 @@ class ClientConfig: region: str | None = None timeout_ms: int = 30_000 max_retries: int = 3 + # False is rejected by IicpClient with SDK-05. tls_verify: bool = True # DEPRECATED/no-op (#360): IICP-CX encryption is mandatory — the client always # encrypts when the node advertises a cx_public_key, regardless of this flag. diff --git a/tests/test_tls_policy.py b/tests/test_tls_policy.py new file mode 100644 index 0000000..9867935 --- /dev/null +++ b/tests/test_tls_policy.py @@ -0,0 +1,22 @@ +"""SDK-05 constructor controls; no request or TLS handshake is performed.""" +from unittest import TestCase, mock + +from iicp_client import ClientConfig, IicpClient, IicpError + + +class TlsCertificatePolicyTests(TestCase): + def test_default_verification_is_accepted(self): + with mock.patch("httpx.AsyncClient", side_effect=AssertionError("unexpected HTTP client")): + self.assertIsInstance(IicpClient(), IicpClient) + + def test_explicit_verification_is_accepted(self): + with mock.patch("httpx.AsyncClient", side_effect=AssertionError("unexpected HTTP client")): + self.assertIsInstance(IicpClient(ClientConfig(tls_verify=True)), IicpClient) + + def test_disabled_verification_is_refused_before_any_request(self): + with mock.patch("httpx.AsyncClient", side_effect=AssertionError("unexpected HTTP client")): + with self.assertRaises(IicpError) as caught: + IicpClient(ClientConfig(tls_verify=False)) + self.assertEqual(caught.exception.code, "SDK-05") + self.assertEqual(caught.exception.component, "sdk") + self.assertFalse(caught.exception.retryable) From 47160894896a9a9506a8e4113ea88010fc1b8452 Mon Sep 17 00:00:00 2001 From: RobLe3 Date: Fri, 6 Nov 2026 18:23:55 +0100 Subject: [PATCH 2/2] fix: isolate validated client configuration from caller mutation --- src/iicp_client/client.py | 3 ++- src/iicp_client/types.py | 2 ++ tests/test_tls_policy.py | 7 +++++++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/iicp_client/client.py b/src/iicp_client/client.py index 73e33cc..9030e67 100644 --- a/src/iicp_client/client.py +++ b/src/iicp_client/client.py @@ -11,6 +11,7 @@ import re import time import uuid +from dataclasses import replace from typing import Any from urllib.parse import urlparse @@ -122,7 +123,7 @@ class IicpClient: """ def __init__(self, config: ClientConfig | None = None) -> None: - self._cfg = config or ClientConfig() + self._cfg = replace(config) if config is not None else ClientConfig() if self._cfg.tls_verify is False: raise IicpError( code="SDK-05", diff --git a/src/iicp_client/types.py b/src/iicp_client/types.py index 65e5ee9..a9381a7 100644 --- a/src/iicp_client/types.py +++ b/src/iicp_client/types.py @@ -34,6 +34,8 @@ class RoutingPolicy: @dataclass class ClientConfig: + """Client options, shallow-copied by IicpClient at construction.""" + directory_url: str = "https://iicp.network/api" region: str | None = None timeout_ms: int = 30_000 diff --git a/tests/test_tls_policy.py b/tests/test_tls_policy.py index 9867935..8471c45 100644 --- a/tests/test_tls_policy.py +++ b/tests/test_tls_policy.py @@ -20,3 +20,10 @@ def test_disabled_verification_is_refused_before_any_request(self): self.assertEqual(caught.exception.code, "SDK-05") self.assertEqual(caught.exception.component, "sdk") self.assertFalse(caught.exception.retryable) + + def test_caller_configuration_mutation_cannot_disable_verification(self): + config = ClientConfig(tls_verify=True) + with mock.patch("httpx.AsyncClient", side_effect=AssertionError("unexpected HTTP client")): + client = IicpClient(config) + config.tls_verify = False + self.assertTrue(client._cfg.tls_verify)