From 3fb5482f0b613c4d8a6ca9b3c464a56624992930 Mon Sep 17 00:00:00 2001 From: ChrisRackauckas-Claude Date: Wed, 23 Sep 2026 08:26:42 -0400 Subject: [PATCH] Re-enable Downstream adjoint tests after SciMLBase RAT v4 compat SciML/SciMLBase.jl#1297 merged and SciMLBase 3.x declares RecursiveArrayTools compat 4, so restore Downstream/adjoints.jl and the ForwardDiff/SciMLBase test deps that were dropped while waiting on that bump. Co-Authored-By: Chris Rackauckas Co-Authored-By: Cursor Agent Agent-Harness: Cursor Agent CLI 2026.09.18-9a7762b Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/rat-tests/log.txt on amdci2 --- test/Downstream/Project.toml | 4 ++++ test/runtests.jl | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/test/Downstream/Project.toml b/test/Downstream/Project.toml index df435b37..89db122f 100644 --- a/test/Downstream/Project.toml +++ b/test/Downstream/Project.toml @@ -1,5 +1,6 @@ [deps] ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9" +ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210" ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78" MonteCarloMeasurements = "0987c9cc-fe09-11e8-30f0-b96dd679fdca" NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56" @@ -7,6 +8,7 @@ OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" OrdinaryDiffEqRosenbrock = "43230ef6-c299-4910-a778-202eb28ce4ce" RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd" RecursiveArrayToolsShorthandConstructors = "39fb7555-b4ad-4efd-8abe-30331df017d3" +SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462" StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5" Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c" @@ -21,6 +23,7 @@ RecursiveArrayToolsShorthandConstructors = {path = "../../lib/RecursiveArrayTool [compat] ArrayInterface = "7" +ForwardDiff = "0.10, 1" ModelingToolkit = "8.33, 9, 10, 11" MonteCarloMeasurements = "1.1" NLsolve = "4" @@ -29,6 +32,7 @@ OrdinaryDiffEqRosenbrock = "2.6.1" StaticArrays = "1" RecursiveArrayTools = "4" RecursiveArrayToolsShorthandConstructors = "1" +SciMLBase = "3" SymbolicIndexingInterface = "0.3" Tables = "1" Test = "1" diff --git a/test/runtests.jl b/test/runtests.jl index d6d0ece1..0c4148f8 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -48,8 +48,7 @@ run_tests(; @time @safetestset "Event Tests with ArrayPartition" include("Downstream/downstream_events.jl") @time @safetestset "Measurements and Units" include("Downstream/measurements_and_units.jl") @time @safetestset "TrackerExt" include("Downstream/TrackerExt.jl") - # TODO: re-enable after SciMLBase compat bump for RAT v4 (SciML/SciMLBase.jl#1297) - # @time @safetestset "Downstream Adjoint Tests" include("Downstream/adjoints.jl") + @time @safetestset "Downstream Adjoint Tests" include("Downstream/adjoints.jl") return @time @safetestset "DiffEqArray Indexing Tests" include("Downstream/symbol_indexing.jl") end, ),