zeroOrMore() and oneOrMore() do not generat correct results

[Tavio]

The expression:

regex().add("Java").zeroOrMore().build();

should generate the regex: /(?:Java)*/, just as the expression:

regex().maybe("Java").build();

generates the regex: /(?:Java)?/. However, the first expression actually generates the regex: /Java*/, which is not correct. The oneOrMore() method suffers from the similar problem.

I propose to change both zeroOrMore() and oneOrMore() to accept a string, much as the maybe() method does so it can return the correct result.

[lanwen]

regex().add("Java").zeroOrMore().build(); should generate Java* as expected - you should use grouping to generate (?:Java)*

[lanwen]

You shouldn't remove current behaviour because this is expected. Just add alias that can return already grouped value. What for we should have 2 maybe methods? :)

[Maaartinus]

IMHO this is wrong. That Java* parses as (?:Jav)(?:a)* is perfectly fine, but when using a higher level more verbose description, I'd expect, it's structure gets preserved. And there's the word Java occurring as a unit in .add("Java").zeroOrMore(), so it should be handled as a unit rather than being split.

[KamasamaK]

add is just supposed to append the literal value -- no additional grouping or sanitizing. It should actually be private, but that would be a breaking change. What you want is then/find, which does group the text passed.