fix(types): preserve duration unit alias across schema extraction (#1213)

Author: bokelley

src/adcp/types/aliases.py

@@ -2070,9 +2070,10 @@ class UnknownGroupAsset(_BaseGroupAsset):
 #     totals view.
 #   - core.notification_config.Authentication makes ``credentials`` optional;
 #     the other four Authentication variants require it.
-#   - the four ``Unit`` enums measure different dimensions (duration, overlay
-#     positioning, real-estate area, vehicle distance). ``adcp.types.DimensionUnit``
-#     is a separate, already-unambiguous enum and is not part of this collision.
+#   - the legacy inline duration ``Unit`` and the three remaining ``Unit``
+#     enums measure different dimensions. ``DurationUnit`` keeps its public
+#     identity when the schema moves the duration vocabulary to a shared enum.
+#     ``adcp.types.DimensionUnit`` is a separate, already-unambiguous enum.
 from adcp.types.generated_poc.account.sync_accounts_response import (
     Account as SyncAccountsAccount,
 )
@@ -2106,9 +2107,15 @@ class UnknownGroupAsset(_BaseGroupAsset):
 from adcp.types.generated_poc.core.canonical_proposal import (
     TotalBudgetGuidance as CanonicalProposalTotalBudgetGuidance,
 )
-from adcp.types.generated_poc.core.duration import (
-    Unit as DurationUnit,
-)
+
+try:
+    from adcp.types.generated_poc.enums.duration_unit import DurationUnit  # type: ignore[import-not-found,unused-ignore]
+except ModuleNotFoundError as exc:
+    if exc.name != "adcp.types.generated_poc.enums.duration_unit":
+        raise
+    from adcp.types.generated_poc.core.duration import (
+        Unit as DurationUnit,
+    )
 from adcp.types.generated_poc.media_buy.change_term_constraints import (
     MediaBuyChangeTermConstraints1 as BudgetChangeConstraints,
 )

tests/test_collision_aliases.py

@@ -142,8 +142,8 @@
     # TmpxMacro — 2 variants
     ("IdentityMatchTmpxMacro", "trusted_match.identity_match_response", "TmpxMacro"),
     ("ProviderRegistrationTmpxMacro", "trusted_match.provider_registration", "TmpxMacro"),
-    # Unit — 4 variants
-    ("DurationUnit", "core.duration", "Unit"),
+    # Unit — 3 remaining inline variants. DurationUnit has a dedicated
+    # compatibility test because its schema source can be inline or shared.
     ("OverlayUnit", "core.overlay", "Unit"),
     ("RealEstateUnit", "core.real_estate_item", "Unit"),
     ("VehicleUnit", "core.vehicle_item", "Unit"),
@@ -155,6 +155,16 @@ def _source_class(module_suffix: str, base_name: str) -> type:
     return getattr(module, base_name)
 
 
+def _duration_unit_source_class() -> type:
+    try:
+        module = importlib.import_module("adcp.types.generated_poc.enums.duration_unit")
+        return module.DurationUnit
+    except ModuleNotFoundError as exc:
+        if exc.name != "adcp.types.generated_poc.enums.duration_unit":
+            raise
+        return _source_class("core.duration", "Unit")
+
+
 @pytest.mark.parametrize(("alias_name", "module_suffix", "base_name"), COLLISION_ALIASES)
 def test_alias_resolves_to_named_module_variant(
     alias_name: str, module_suffix: str, base_name: str
@@ -193,6 +203,18 @@ def test_alias_in_aliases_all(alias_name: str, module_suffix: str, base_name: st
     assert alias_name in aliases.__all__, f"{alias_name} missing from aliases.__all__"
 
 
+def test_duration_unit_alias_survives_shared_enum_extraction() -> None:
+    """The public alias follows either supported generated schema layout."""
+    import adcp.types as types_module
+    from adcp.types import aliases
+
+    expected = _duration_unit_source_class()
+    assert aliases.DurationUnit is expected
+    assert types_module.DurationUnit is expected
+    assert "DurationUnit" in aliases.__all__
+    assert "DurationUnit" in types_module.__all__
+
+
 def test_alias_set_is_internally_consistent() -> None:
     """The alias table has no duplicate alias names and covers each base
     name's set of source modules with one alias per (base, module) pair."""