Housekeeping findings from the post-v1.0 review:
- v2.0.0 was published to npm without a git tag.
CHANGELOG.md:33 links releases/tag/v2.0.0, but git tag is empty — the published artifact is not pinned to a commit. Fix: retroactively tag the publish-era commit (54cf009 lineage) and push; then merge the feat/release-pipeline branch (1 commit ahead of main, unmerged) so future releases tag automatically.
engines: ">=18" is inaccurate. tsup.config.ts targets node20, .nvmrc says 24, and running the repo''s own test (scripts/mock-server-test.js imports ../src/index.ts with type-stripping + JSON import attributes) needs Node >= 23.6. The published dist/ is fine, but a Node 18/20 contributor cannot run npm test. Fix: bump engines to >=20 (the MCP server already requires that) and note the Node-24 dev requirement in the README.- The mock test models the invocation the client''s own docs forbid.
scripts/mock-server-test.js:131 calls runCommand('lua', ['-e', ...]), but src/client.ts:143-146 documents that -e is not accepted over RPC. The mock does not care, so it passes — but as executable protocol documentation it teaches wrong usage. Fix: drop -e from the test args.
- Minor:
scripts/debug-lua.js is an unreferenced one-off probe — delete or wire up.
Housekeeping findings from the post-v1.0 review:
CHANGELOG.md:33linksreleases/tag/v2.0.0, butgit tagis empty — the published artifact is not pinned to a commit. Fix: retroactively tag the publish-era commit (54cf009lineage) and push; then merge thefeat/release-pipelinebranch (1 commit ahead of main, unmerged) so future releases tag automatically.engines: ">=18"is inaccurate.tsup.config.tstargets node20,.nvmrcsays 24, and running the repo''s own test (scripts/mock-server-test.jsimports../src/index.tswith type-stripping + JSON import attributes) needs Node >= 23.6. The publisheddist/is fine, but a Node 18/20 contributor cannot runnpm test. Fix: bump engines to >=20 (the MCP server already requires that) and note the Node-24 dev requirement in the README.scripts/mock-server-test.js:131callsrunCommand('lua', ['-e', ...]), butsrc/client.ts:143-146documents that-eis not accepted over RPC. The mock does not care, so it passes — but as executable protocol documentation it teaches wrong usage. Fix: drop-efrom the test args.scripts/debug-lua.jsis an unreferenced one-off probe — delete or wire up.