fix(menu): keep the profile header for an unnamed account, as iOS does

iOS YouScreen draws the header for every account and puts the claim
prompt where the stats card goes. Android dropped the header, so an
account with no name lost its cover, avatar and Edit Profile button.
Share stays hidden until there is a name to share.

ProfileHeader also gets iOS's 8pt gap (staticGrid.x2) between the
action row and the title, and takes a null title for the unnamed case.

Author: bmc08gt

apps/flipcash/features/menu/src/main/kotlin/com/flipcash/app/menu/internal/MenuScreenContent.kt

@@ -110,8 +110,15 @@ internal fun MenuScreenContent(viewModel: MenuScreenViewModel) {
                 }
 
                 is ProfileState.Unclaimed -> {
-                    item(key = "settings_gear") {
-                        SettingsGear(onClick = { viewModel.dispatchEvent(Event.OpenScreen(AppRoute.Menu.Settings)) })
+                    // As on iOS: the header keeps its cover, avatar and Edit Profile, with no Share
+                    // (there is nothing to share yet), and the claim prompt takes the stats' place.
+                    item(key = "profile_header") {
+                        OwnProfileHeader(
+                            profile = profileState.profile,
+                            onEdit = { viewModel.dispatchEvent(Event.OpenScreen(AppRoute.Menu.Settings)) },
+                            onShare = null,
+                            onSettings = { viewModel.dispatchEvent(Event.OpenScreen(AppRoute.Menu.Settings)) },
+                        )
                     }
                     item(key = "claim_prompt") {
                         Spacer(Modifier.height(UnclaimedTopSpacing))
@@ -169,42 +176,43 @@ internal fun MenuScreenContent(viewModel: MenuScreenViewModel) {
 /** The viewer's profile header with the settings gear over the cover's top trailing corner. */
 @Composable
 private fun OwnProfileHeader(
-    profile: UserProfile,
+    profile: UserProfile?,
     onEdit: () -> Unit,
-    onShare: () -> Unit,
+    onShare: (() -> Unit)?,
     onSettings: () -> Unit,
 ) {
     // The header is what scrolls under the gear, so it is the gear's frosting source.
     val hazeState = rememberHazeState()
     Box {
         ProfileHeader(
             modifier = Modifier.hazeSource(hazeState),
-            cover = profile.coverPicture,
+            cover = profile?.coverPicture,
             // The viewer's own blobs, so no profile id is needed to authorize re-minting them.
             access = BlobAccessContext.Owned,
             avatar = { modifier ->
                 ContactAvatar(
-                    image = profile.profilePicture,
-                    displayName = profile.displayName,
+                    image = profile?.profilePicture,
+                    displayName = profile?.displayName.orEmpty(),
                     access = BlobAccessContext.Owned,
                     modifier = modifier,
                 )
             },
-            title = profile.displayName,
-            subtitle = profile.username?.takeIf { it.isNotEmpty() }?.let { "@$it" },
-            body = profile.bio.ifEmpty { null },
+            title = profile?.displayName?.ifEmpty { null },
+            subtitle = profile?.username?.takeIf { it.isNotEmpty() }?.let { "@$it" },
+            body = profile?.bio?.ifEmpty { null },
             actions = {
                 ProfileActionButton(
                     text = stringResource(R.string.action_editProfile),
                     onClick = onEdit,
                 )
-                // A named profile is the only one that gets here, which is exactly when there is
-                // something to share.
-                ProfileActionButton(
-                    icon = ImageVector.vectorResource(R.drawable.ic_share_os),
-                    contentDescription = stringResource(R.string.action_share),
-                    onClick = onShare,
-                )
+                // Only a named profile has something to share.
+                if (onShare != null) {
+                    ProfileActionButton(
+                        icon = ImageVector.vectorResource(R.drawable.ic_share_os),
+                        contentDescription = stringResource(R.string.action_share),
+                        onClick = onShare,
+                    )
+                }
             },
         )
         SettingsGear(
@@ -245,18 +253,18 @@ private const val YouCardWidthFraction = 0.60f
 private val YouCardWidth: Dp
     @Composable get() = CodeTheme.dimens.screenWidth * YouCardWidthFraction
 
-/** Gap between the gear and the unclaimed stand-in. */
+/** Gap between the header and the unclaimed stand-in (iOS 24). */
 private val UnclaimedTopSpacing: Dp
-    @Composable get() = CodeTheme.dimens.grid.x6
+    @Composable get() = CodeTheme.dimens.staticGrid.x5
 
 /**
  * What the "You" tab shows before the account has a display name: the card it *would* have, blurred
  * out behind a prompt to claim it. Mirrors iOS `YouScreen.setupPrompt`.
  *
  * The stand-in is the account's real scannable payload drawn over an unnamed profile, with the
  * card's own fill turned off so the 8% ground shows through — the same construction iOS uses. It is
- * decoration: not tappable, not expandable, not shareable, and the header, stats and Share button are
- * absent entirely, because there is nothing yet to show or share.
+ * decoration: not tappable, not expandable, not shareable. It takes the stats card's place under the
+ * header, and the header drops its Share button, because there is nothing yet to share.
  *
  * [blurEnabled] is haze's own API-31 gate, surfaced so a preview can render what an API 29/30
  * device draws (see `Preview_UnclaimedTipCardPrompt_NoBlur`). Leave it at the default in app code.

apps/flipcash/features/menu/src/main/kotlin/com/flipcash/app/menu/internal/MenuScreenViewModel.kt

@@ -89,10 +89,14 @@ internal class MenuScreenViewModel @Inject constructor(
         data object Unknown : ProfileState
 
         /**
-         * The account has no display name, so it has no profile worth showing yet. [placeholder] is
-         * a real scannable stand-in drawn blurred behind the claim prompt; it is never shareable.
+         * The account has no display name yet. [placeholder] is a real scannable stand-in drawn
+         * blurred behind the claim prompt; it is never shareable. [profile] is whatever the server
+         * already holds (a cover, say), or null for an account it has never seen.
          */
-        data class Unclaimed(val placeholder: Scannable.TipCard?) : ProfileState
+        data class Unclaimed(
+            val placeholder: Scannable.TipCard?,
+            val profile: UserProfile? = null,
+        ) : ProfileState
 
         /** The viewer's own profile, with [joined] already formatted for the stats card. */
         data class Named(val profile: UserProfile, val joined: String?) : ProfileState
@@ -146,12 +150,12 @@ internal class MenuScreenViewModel @Inject constructor(
             .distinctUntilChanged()
             .onEach { profile ->
                 if (profile == null || profile.displayName.isEmpty()) {
-                    // No name means nothing to show yet — the tab prompts to claim one instead.
-                    // Built locally, so an account whose profile the server has never seen still
+                    // No name yet: the header still draws (cover, avatar, Edit Profile) with the claim
+                    // prompt under it, as on iOS. The placeholder is built locally, so an account whose profile the server has never seen still
                     // gets it.
                     dispatchEvent(
                         Event.OnProfileStateChanged(
-                            ProfileState.Unclaimed(tippingCoordinator.unclaimedTipCard())
+                            ProfileState.Unclaimed(tippingCoordinator.unclaimedTipCard(), profile)
                         )
                     )
                 } else {

apps/flipcash/shared/common-ui/src/main/kotlin/com/flipcash/shared/common/ui/profile/ProfileHeader.kt

@@ -33,7 +33,8 @@ private val AvatarOverlap = 42.dp
 
 /**
  * The top of a profile: [cover], an avatar overlapping it, the actions beside the avatar, and the
- * subject's [title], [subtitle] and [body].
+ * subject's [title], [subtitle] and [body]. A null [title] (an account with no name yet) draws
+ * nothing in its place.
  *
  * It renders a subject, not a user — a person today, a group next — so callers map their model to
  * these inputs. [avatar] receives the size, clip and ring to draw with, which keeps the avatar the
@@ -48,7 +49,7 @@ fun ProfileHeader(
     cover: MediaItem?,
     access: BlobAccessContext,
     avatar: @Composable (Modifier) -> Unit,
-    title: String,
+    title: String?,
     subtitle: String?,
     body: String?,
     actions: @Composable RowScope.() -> Unit,
@@ -83,16 +84,20 @@ fun ProfileHeader(
                     content = actions,
                 )
             }
+            // iOS sets the text 8pt below the action row.
             Column(
                 modifier = Modifier
                     .fillMaxWidth()
-                    .padding(horizontal = inset),
+                    .padding(horizontal = inset)
+                    .padding(top = CodeTheme.dimens.staticGrid.x2),
             ) {
-                Text(
-                    text = title,
-                    style = CodeTheme.typography.displaySmall,
-                    color = CodeTheme.colors.textMain,
-                )
+                if (!title.isNullOrBlank()) {
+                    Text(
+                        text = title,
+                        style = CodeTheme.typography.displaySmall,
+                        color = CodeTheme.colors.textMain,
+                    )
+                }
                 if (!subtitle.isNullOrBlank()) {
                     Text(
                         text = subtitle,