bindparam_test.go

// Copyright 2019 DeepMap, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package runtime

import (
	"encoding/json"
	"fmt"
	"math/big"
	"net/url"
	"reflect"
	"testing"
	"time"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

	"github.com/oapi-codegen/runtime/types"
)

// TestBindStyledParameter_ByteSlice tests that BindStyledParameterWithOptions
// correctly handles *[]byte destinations by base64-decoding the parameter value,
// rather than treating []byte as a generic slice and splitting on commas.
// See: https://github.com/oapi-codegen/runtime/issues/97
func TestBindStyledParameter_ByteSlice(t *testing.T) {
	expected := []byte("test")

	tests := []struct {
		name    string
		style   string
		explode bool
		value   string
	}{
		{"simple/no-explode", "simple", false, "dGVzdA=="},
		{"simple/explode", "simple", true, "dGVzdA=="},
		{"label/no-explode", "label", false, ".dGVzdA=="},
		{"label/explode", "label", true, ".dGVzdA=="},
		{"matrix/no-explode", "matrix", false, ";data=dGVzdA=="},
		{"matrix/explode", "matrix", true, ";data=dGVzdA=="},
		{"form/no-explode", "form", false, "data=dGVzdA=="},
		{"form/explode", "form", true, "data=dGVzdA=="},
	}

	for _, tc := range tests {
		t.Run(tc.name, func(t *testing.T) {
			var dest []byte
			err := BindStyledParameterWithOptions(tc.style, "data", tc.value, &dest, BindStyledParameterOptions{
				ParamLocation: ParamLocationUndefined,
				Explode:       tc.explode,
				Required:      true,
				Type:          "string",
				Format:        "byte",
			})
			require.NoError(t, err)
			assert.Equal(t, expected, dest)
		})
	}
}

// TestBindQueryParameter_ByteSlice tests that BindQueryParameter correctly
// handles *[]byte destinations by base64-decoding the query parameter value.
// See: https://github.com/oapi-codegen/runtime/issues/97
func TestBindQueryParameter_ByteSlice(t *testing.T) {
	expected := []byte("test")

	opts := BindQueryParameterOptions{Type: "string", Format: "byte"}

	t.Run("form/explode/required", func(t *testing.T) {
		var dest []byte
		queryParams := url.Values{"data": {"dGVzdA=="}}
		err := BindQueryParameterWithOptions("form", true, true, "data", queryParams, &dest, opts)
		require.NoError(t, err)
		assert.Equal(t, expected, dest)
	})

	t.Run("form/no-explode/required", func(t *testing.T) {
		var dest []byte
		queryParams := url.Values{"data": {"dGVzdA=="}}
		err := BindQueryParameterWithOptions("form", false, true, "data", queryParams, &dest, opts)
		require.NoError(t, err)
		assert.Equal(t, expected, dest)
	})

	t.Run("form/explode/optional/present", func(t *testing.T) {
		var dest *[]byte
		queryParams := url.Values{"data": {"dGVzdA=="}}
		err := BindQueryParameterWithOptions("form", true, false, "data", queryParams, &dest, opts)
		require.NoError(t, err)
		require.NotNil(t, dest)
		assert.Equal(t, expected, *dest)
	})

	t.Run("form/explode/optional/absent", func(t *testing.T) {
		var dest *[]byte
		queryParams := url.Values{}
		err := BindQueryParameterWithOptions("form", true, false, "data", queryParams, &dest, opts)
		require.NoError(t, err)
		assert.Nil(t, dest)
	})

	t.Run("form/explode/optional/empty", func(t *testing.T) {
		var dest []byte
		queryParams := url.Values{"data": {""}}
		err := BindQueryParameterWithOptions("form", true, false, "data", queryParams, &dest, opts)
		require.NoError(t, err)
		assert.Equal(t, []byte{}, dest)
	})
}

// MockBinder is just an independent version of Binder that has the Bind implemented
type MockBinder struct {
	time.Time
}

func (d *MockBinder) Bind(src string) error {
	// Don't fail on empty string.
	if src == "" {
		return nil
	}
	parsedTime, err := time.Parse(types.DateFormat, src)
	if err != nil {
		return fmt.Errorf("error parsing '%s' as date: %s", src, err)
	}
	d.Time = parsedTime
	return nil
}

func (d MockBinder) MarshalJSON() ([]byte, error) {
	return json.Marshal(d.Format(types.DateFormat))
}

func (d *MockBinder) UnmarshalJSON(data []byte) error {
	var dateStr string
	err := json.Unmarshal(data, &dateStr)
	if err != nil {
		return err
	}
	parsed, err := time.Parse(types.DateFormat, dateStr)
	if err != nil {
		return err
	}
	d.Time = parsed
	return nil
}

// EmbeddedMockBinder has an embedded MockBinder and so keeps the Binder Method from MockBinder.
type EmbeddedMockBinder struct {
	MockBinder
}

// AnotherMockBinder is an entirely new type we have to create a bind method with it to implement Binder as well.
type AnotherMockBinder MockBinder

func (b *AnotherMockBinder) Bind(src string) error {
	// Don't fail on empty string.
	if src == "" {
		return nil
	}
	parsedTime, err := time.Parse(types.DateFormat, src)
	if err != nil {
		return fmt.Errorf("error parsing '%s' as date: %s", src, err)
	}
	b.Time = parsedTime
	return nil
}

func TestSplitParameter(t *testing.T) {
	// Please see the parameter serialization docs to understand these test
	// cases

	expectedPrimitive := []string{"5"}
	expectedArray := []string{"3", "4", "5"}
	expectedObject := []string{"role", "admin", "firstName", "Alex"}
	expectedExplodedObject := []string{"role=admin", "firstName=Alex"}

	var result []string
	var err error
	//  ------------------------ simple style ---------------------------------
	result, err = splitStyledParameter("simple",
		false,
		false,
		"id",
		"5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("simple",
		false,
		false,
		"id",
		"3,4,5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("simple",
		false,
		true,
		"id",
		"role,admin,firstName,Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedObject, result)

	result, err = splitStyledParameter("simple",
		true,
		false,
		"id",
		"5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("simple",
		true,
		false,
		"id",
		"3,4,5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("simple",
		true,
		true,
		"id",
		"role=admin,firstName=Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedExplodedObject, result)

	//  ------------------------ label style ---------------------------------
	result, err = splitStyledParameter("label",
		false,
		false,
		"id",
		".5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("label",
		false,
		false,
		"id",
		".3,4,5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("label",
		false,
		true,
		"id",
		".role,admin,firstName,Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedObject, result)

	result, err = splitStyledParameter("label",
		true,
		false,
		"id",
		".5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("label",
		true,
		false,
		"id",
		".3.4.5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("label",
		true,
		true,
		"id",
		".role=admin.firstName=Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedExplodedObject, result)

	//  ------------------------ matrix style ---------------------------------
	result, err = splitStyledParameter("matrix",
		false,
		false,
		"id",
		";id=5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("matrix",
		false,
		false,
		"id",
		";id=3,4,5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("matrix",
		false,
		true,
		"id",
		";id=role,admin,firstName,Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedObject, result)

	result, err = splitStyledParameter("matrix",
		true,
		false,
		"id",
		";id=5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("matrix",
		true,
		false,
		"id",
		";id=3;id=4;id=5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("matrix",
		true,
		true,
		"id",
		";role=admin;firstName=Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedExplodedObject, result)

	// ------------------------ form style ---------------------------------
	result, err = splitStyledParameter("form",
		false,
		false,
		"id",
		"id=5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("form",
		false,
		false,
		"id",
		"id=3,4,5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("form",
		false,
		true,
		"id",
		"id=role,admin,firstName,Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedObject, result)

	result, err = splitStyledParameter("form",
		true,
		false,
		"id",
		"id=5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedPrimitive, result)

	result, err = splitStyledParameter("form",
		true,
		false,
		"id",
		"id=3&id=4&id=5")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedArray, result)

	result, err = splitStyledParameter("form",
		true,
		true,
		"id",
		"role=admin&firstName=Alex")
	assert.NoError(t, err)
	assert.EqualValues(t, expectedExplodedObject, result)
}

func TestBindQueryParameter(t *testing.T) {
	t.Run("deepObject", func(t *testing.T) {
		type Object struct {
			Count int `json:"count"`
		}
		type Nested struct {
			Object  Object   `json:"object"`
			Objects []Object `json:"objects"`
		}
		type ID struct {
			FirstName *string     `json:"firstName"`
			LastName  *string     `json:"lastName"`
			Role      string      `json:"role"`
			Birthday  *types.Date `json:"birthday"`
			Married   *MockBinder `json:"married"`
			Nested    Nested      `json:"nested"`
		}

		expectedName := "Alex"
		expectedDeepObject := &ID{
			FirstName: &expectedName,
			Role:      "admin",
			Birthday:  &types.Date{Time: time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)},
			Married:   &MockBinder{time.Date(2020, 2, 2, 0, 0, 0, 0, time.UTC)},
			Nested: Nested{
				Object:  Object{Count: 123},
				Objects: []Object{{Count: 1}, {Count: 2}},
			},
		}

		actual := new(ID)
		paramName := "id"
		queryParams := url.Values{
			"id[firstName]":                 {"Alex"},
			"id[role]":                      {"admin"},
			"foo":                           {"bar"},
			"id[birthday]":                  {"2020-01-01"},
			"id[married]":                   {"2020-02-02"},
			"id[nested][object][count]":     {"123"},
			"id[nested][objects][0][count]": {"1"},
			"id[nested][objects][1][count]": {"2"},
		}

		err := BindQueryParameter("deepObject", true, false, paramName, queryParams, &actual)
		assert.NoError(t, err)
		assert.Equal(t, expectedDeepObject, actual)

		// If we require values, we require errors when they're not present.
		err = BindQueryParameter("deepObject", true, true, "notfound", queryParams, &actual)
		assert.Error(t, err)
	})

	t.Run("deepObject/required-and-optional", func(t *testing.T) {
		type SimpleObj struct {
			Name string `json:"name"`
			Age  int    `json:"age"`
		}

		queryWithParam := url.Values{
			"obj[name]": {"Alice"},
			"obj[age]":  {"30"},
		}
		emptyQuery := url.Values{}
		unrelatedQuery := url.Values{
			"other[name]": {"Bob"},
		}

		t.Run("optional/present binds successfully", func(t *testing.T) {
			var dest SimpleObj
			err := BindQueryParameter("deepObject", true, false, "obj", queryWithParam, &dest)
			require.NoError(t, err)
			assert.Equal(t, SimpleObj{Name: "Alice", Age: 30}, dest)
		})

		t.Run("optional/missing returns no error and does not modify dest", func(t *testing.T) {
			var dest SimpleObj
			err := BindQueryParameter("deepObject", true, false, "obj", emptyQuery, &dest)
			require.NoError(t, err)
			assert.Equal(t, SimpleObj{}, dest, "destination should remain zero-valued")
		})

		t.Run("optional/missing with unrelated params returns no error", func(t *testing.T) {
			var dest SimpleObj
			err := BindQueryParameter("deepObject", true, false, "obj", unrelatedQuery, &dest)
			require.NoError(t, err)
			assert.Equal(t, SimpleObj{}, dest, "destination should remain zero-valued")
		})

		t.Run("optional/missing preserves pre-populated dest", func(t *testing.T) {
			dest := SimpleObj{Name: "PreExisting", Age: 99}
			err := BindQueryParameter("deepObject", true, false, "obj", emptyQuery, &dest)
			require.NoError(t, err)
			assert.Equal(t, SimpleObj{Name: "PreExisting", Age: 99}, dest,
				"destination should not be zeroed out when optional param is absent")
		})

		t.Run("required/present binds successfully", func(t *testing.T) {
			var dest SimpleObj
			err := BindQueryParameter("deepObject", true, true, "obj", queryWithParam, &dest)
			require.NoError(t, err)
			assert.Equal(t, SimpleObj{Name: "Alice", Age: 30}, dest)
		})

		t.Run("required/missing returns error", func(t *testing.T) {
			var dest SimpleObj
			err := BindQueryParameter("deepObject", true, true, "obj", emptyQuery, &dest)
			require.Error(t, err)
			assert.Contains(t, err.Error(), "required")
		})

		t.Run("required/missing with unrelated params returns error", func(t *testing.T) {
			var dest SimpleObj
			err := BindQueryParameter("deepObject", true, true, "obj", unrelatedQuery, &dest)
			require.Error(t, err)
			assert.Contains(t, err.Error(), "required")
		})
	})

	t.Run("form", func(t *testing.T) {
		expected := &MockBinder{Time: time.Date(2020, 1, 1, 0, 0, 0, 0, time.UTC)}
		birthday := &MockBinder{}
		queryParams := url.Values{
			"birthday": {"2020-01-01"},
		}
		err := BindQueryParameter("form", true, false, "birthday", queryParams, &birthday)
		assert.NoError(t, err)
		assert.Equal(t, expected, birthday)
	})

	// Regression tests for https://github.com/oapi-codegen/runtime/issues/21
	// types.Date should bind correctly as a query parameter in all configurations.
	t.Run("date_form_explode_required", func(t *testing.T) {
		expectedDate := types.Date{Time: time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC)}
		var date types.Date
		queryParams := url.Values{
			"date": {"2023-01-01"},
		}
		err := BindQueryParameter("form", true, true, "date", queryParams, &date)
		assert.NoError(t, err)
		assert.Equal(t, expectedDate, date)
	})

	t.Run("date_form_explode_optional", func(t *testing.T) {
		expectedDate := types.Date{Time: time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC)}
		var date *types.Date
		queryParams := url.Values{
			"date": {"2023-01-01"},
		}
		err := BindQueryParameter("form", true, false, "date", queryParams, &date)
		assert.NoError(t, err)
		require.NotNil(t, date)
		assert.Equal(t, expectedDate, *date)
	})

	t.Run("date_form_explode_optional_missing", func(t *testing.T) {
		var date *types.Date
		queryParams := url.Values{}
		err := BindQueryParameter("form", true, false, "date", queryParams, &date)
		assert.NoError(t, err)
		assert.Nil(t, date)
	})

	// Regression test for https://github.com/oapi-codegen/runtime/issues/134:
	// an absent *required* date (a struct-typed param) must report a
	// RequiredParameterError, not pass silently. The exploded form path
	// previously returned nil here, dropping the required check.
	t.Run("date_form_explode_required_missing", func(t *testing.T) {
		var date types.Date
		queryParams := url.Values{}
		err := BindQueryParameter("form", true, true, "date", queryParams, &date)
		var requiredErr *RequiredParameterError
		assert.ErrorAs(t, err, &requiredErr)
	})

	t.Run("date_form_no_explode_required_missing", func(t *testing.T) {
		var date types.Date
		queryParams := url.Values{}
		err := BindQueryParameter("form", false, true, "date", queryParams, &date)
		var requiredErr *RequiredParameterError
		assert.ErrorAs(t, err, &requiredErr)
	})

	t.Run("date_form_no_explode_required", func(t *testing.T) {
		expectedDate := types.Date{Time: time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC)}
		var date types.Date
		queryParams := url.Values{
			"date": {"2023-01-01"},
		}
		err := BindQueryParameter("form", false, true, "date", queryParams, &date)
		assert.NoError(t, err)
		assert.Equal(t, expectedDate, date)
	})

	t.Run("date_form_no_explode_optional", func(t *testing.T) {
		expectedDate := types.Date{Time: time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC)}
		var date *types.Date
		queryParams := url.Values{
			"date": {"2023-01-01"},
		}
		err := BindQueryParameter("form", false, false, "date", queryParams, &date)
		assert.NoError(t, err)
		require.NotNil(t, date)
		assert.Equal(t, expectedDate, *date)
	})

	// types.Duration is a scalar binding target like types.Date: it must
	// bind directly via its Binder implementation rather than being
	// decomposed as a struct of key-value pairs.
	// See https://github.com/oapi-codegen/runtime/issues/66
	t.Run("duration_form_explode_required", func(t *testing.T) {
		var duration types.Duration
		queryParams := url.Values{
			"retry": {"P1DT2H30M"},
		}
		err := BindQueryParameter("form", true, true, "retry", queryParams, &duration)
		assert.NoError(t, err)
		assert.Equal(t, types.Duration{Days: 1, Hours: 2, Minutes: 30}, duration)
	})

	t.Run("duration_form_no_explode_optional", func(t *testing.T) {
		var duration *types.Duration
		queryParams := url.Values{
			"retry": {"PT36H"},
		}
		err := BindQueryParameter("form", false, false, "retry", queryParams, &duration)
		assert.NoError(t, err)
		require.NotNil(t, duration)
		assert.Equal(t, types.Duration{Hours: 36}, *duration)
	})

	// Regression test: primitive string with explode=false should not be
	// split on commas. Per the OpenAPI specification, explode has no effect
	// on primitive types — the value must be bound as-is.
	t.Run("string_form_no_explode_required_with_commas", func(t *testing.T) {
		var scope string
		queryParams := url.Values{
			"scope": {"openid,profile,email"},
		}
		err := BindQueryParameter("form", false, true, "scope", queryParams, &scope)
		assert.NoError(t, err)
		assert.Equal(t, "openid,profile,email", scope)
	})

	t.Run("string_form_no_explode_optional_with_commas", func(t *testing.T) {
		var scope *string
		queryParams := url.Values{
			"scope": {"openid,profile,email"},
		}
		err := BindQueryParameter("form", false, false, "scope", queryParams, &scope)
		assert.NoError(t, err)
		require.NotNil(t, scope)
		assert.Equal(t, "openid,profile,email", *scope)
	})

	// time.Time has the same bug as types.Date for form/no-explode.
	t.Run("time_form_no_explode_required", func(t *testing.T) {
		expectedTime := time.Date(2020, 12, 9, 16, 9, 53, 0, time.UTC)
		var ts time.Time
		queryParams := url.Values{
			"ts": {"2020-12-09T16:09:53Z"},
		}
		err := BindQueryParameter("form", false, true, "ts", queryParams, &ts)
		assert.NoError(t, err)
		assert.Equal(t, expectedTime, ts)
	})

	t.Run("date_in_struct_form_explode", func(t *testing.T) {
		type Params struct {
			Name      string     `json:"name"`
			StartDate types.Date `json:"start_date"`
		}
		queryParams := url.Values{
			"name":       {"test"},
			"start_date": {"2023-06-15"},
		}
		var params Params
		err := BindQueryParameter("form", true, true, "params", queryParams, &params)
		assert.NoError(t, err)
		assert.Equal(t, "test", params.Name)
		assert.Equal(t, types.Date{Time: time.Date(2023, 6, 15, 0, 0, 0, 0, time.UTC)}, params.StartDate)
	})

	t.Run("date_pointer_in_struct_form_explode", func(t *testing.T) {
		type Params struct {
			Name      string      `json:"name"`
			StartDate *types.Date `json:"start_date"`
		}
		queryParams := url.Values{
			"name":       {"test"},
			"start_date": {"2023-06-15"},
		}
		var params Params
		err := BindQueryParameter("form", true, true, "params", queryParams, &params)
		assert.NoError(t, err)
		assert.Equal(t, "test", params.Name)
		require.NotNil(t, params.StartDate)
		assert.Equal(t, types.Date{Time: time.Date(2023, 6, 15, 0, 0, 0, 0, time.UTC)}, *params.StartDate)
	})

	t.Run("map_form_no_explode_optional", func(t *testing.T) {
		want := map[string]string{
			"foo": "bar",
			"bim": "baz",
		}
		queryParams := url.Values{
			"tags": {"foo,bar,bim,baz"},
		}
		var got map[string]string
		err := BindQueryParameter("form", false, false, "tags", queryParams, &got)
		assert.NoError(t, err)
		require.NotNil(t, got)
		assert.Equal(t, want, got)
	})

	t.Run("optional", func(t *testing.T) {
		queryParams := url.Values{
			"time":   {"2020-12-09T16:09:53+00:00"},
			"number": {"100"},
			"text":   {"loremipsum"},
		}
		// An optional time will be a pointer to a time in a parameter object
		var optionalTime *time.Time
		err := BindQueryParameter("form", true, false, "notfound", queryParams, &optionalTime)
		require.NoError(t, err)
		assert.Nil(t, optionalTime)

		var optionalNumber *int
		err = BindQueryParameter("form", true, false, "notfound", queryParams, &optionalNumber)
		require.NoError(t, err)
		assert.Nil(t, optionalNumber)

		var optionalNonPointerText = ""
		err = BindQueryParameter("form", true, false, "notfound", queryParams, &optionalNonPointerText)
		require.NoError(t, err)
		assert.Zero(t, optionalNonPointerText)

		err = BindQueryParameter("form", true, false, "text", queryParams, &optionalNonPointerText)
		require.NoError(t, err)
		assert.Equal(t, "loremipsum", optionalNonPointerText)

		// If we require values, we require errors when they're not present.
		err = BindQueryParameter("form", true, true, "notfound", queryParams, &optionalTime)
		assert.Error(t, err)
		err = BindQueryParameter("form", true, true, "notfound", queryParams, &optionalNumber)
		assert.Error(t, err)

		var optionalPointerText *string
		err = BindQueryParameter("form", true, false, "notfound", queryParams, &optionalPointerText)
		require.NoError(t, err)
		assert.Zero(t, optionalPointerText)

		err = BindQueryParameter("form", true, false, "text", queryParams, &optionalPointerText)
		require.NoError(t, err)
		require.NotNil(t, optionalPointerText)
		assert.Equal(t, "loremipsum", *optionalPointerText)
	})
}

func TestBindParameterViaAlias(t *testing.T) {
	// We don't need to check every parameter format type here, since the binding
	// code is identical irrespective of parameter type, buy we do want to test
	// a bunch of types.
	type AString string
	type Aint int
	type Afloat float64
	type Atime = time.Time
	type Adate = MockBinder

	type AliasTortureTest struct {
		S  AString  `json:"s"`
		Sp *AString `json:"sp,omitempty"`
		I  Aint     `json:"i"`
		Ip *Aint    `json:"ip,omitempty"`
		F  Afloat   `json:"f"`
		Fp *Afloat  `json:"fp,omitempty"`
		T  Atime    `json:"t"`
		Tp *Atime   `json:"tp,omitempty"`
		D  Adate    `json:"d"`
		Dp *Adate   `json:"dp,omitempty"`
	}

	now := time.Now().UTC()
	later := now.Add(time.Hour)

	queryParams := url.Values{
		"alias[s]":  {"str"},
		"alias[sp]": {"strp"},
		"alias[i]":  {"1"},
		"alias[ip]": {"2"},
		"alias[f]":  {"3.5"},
		"alias[fp]": {"4.5"},
		"alias[t]":  {now.Format(time.RFC3339Nano)},
		"alias[tp]": {later.Format(time.RFC3339Nano)},
		"alias[d]":  {"2020-11-06"},
		"alias[dp]": {"2020-11-07"},
	}

	dst := new(AliasTortureTest)

	err := BindQueryParameter("deepObject", true, false, "alias", queryParams, &dst)
	require.NoError(t, err)

	var sp AString = "strp"
	var ip Aint = 2
	var fp Afloat = 4.5
	dp := Adate{Time: time.Date(2020, 11, 7, 0, 0, 0, 0, time.UTC)}

	expected := AliasTortureTest{
		S:  "str",
		Sp: &sp,
		I:  1,
		Ip: &ip,
		F:  3.5,
		Fp: &fp,
		T:  now,
		Tp: &later,
		D:  Adate{Time: time.Date(2020, 11, 6, 0, 0, 0, 0, time.UTC)},
		Dp: &dp,
	}

	// Compare field by field, makes errors easier to track.
	assert.EqualValues(t, expected.S, dst.S)
	assert.EqualValues(t, expected.Sp, dst.Sp)
	assert.EqualValues(t, expected.I, dst.I)
	assert.EqualValues(t, expected.Ip, dst.Ip)
	assert.EqualValues(t, expected.F, dst.F)
	assert.EqualValues(t, expected.Fp, dst.Fp)
	assert.EqualValues(t, expected.T, dst.T)
	assert.EqualValues(t, expected.Tp, dst.Tp)
	assert.EqualValues(t, expected.D, dst.D)
	assert.EqualValues(t, expected.Dp, dst.Dp)
}

// bindParamsToExplodedObject has to special case some types. Make sure that
// these non-object types are handled correctly. The other parts of the functionality
// are tested via more generic code above.
func TestBindParamsToExplodedObject(t *testing.T) {
	now := time.Now().UTC()
	values := url.Values{
		"time": {now.Format(time.RFC3339Nano)},
		"date": {"2020-11-06"},
	}

	var dstTime time.Time
	fieldsPresent, err := bindParamsToExplodedObject("time", values, &dstTime)
	assert.NoError(t, err)
	assert.True(t, fieldsPresent)
	assert.EqualValues(t, now, dstTime)

	type AliasedTime time.Time
	var aDstTime AliasedTime
	fieldsPresent, err = bindParamsToExplodedObject("time", values, &aDstTime)
	assert.NoError(t, err)
	assert.True(t, fieldsPresent)
	assert.EqualValues(t, now, aDstTime)

	expectedDate := MockBinder{Time: time.Date(2020, 11, 6, 0, 0, 0, 0, time.UTC)}

	var dstDate MockBinder
	fieldsPresent, err = bindParamsToExplodedObject("date", values, &dstDate)
	assert.NoError(t, err)
	assert.True(t, fieldsPresent)
	assert.EqualValues(t, expectedDate, dstDate)

	var eDstDate EmbeddedMockBinder
	fieldsPresent, err = bindParamsToExplodedObject("date", values, &eDstDate)
	assert.NoError(t, err)
	assert.True(t, fieldsPresent)
	assert.EqualValues(t, expectedDate, dstDate)

	var nTDstDate AnotherMockBinder
	fieldsPresent, err = bindParamsToExplodedObject("date", values, &nTDstDate)
	assert.NoError(t, err)
	assert.True(t, fieldsPresent)
	assert.EqualValues(t, expectedDate, nTDstDate)

	type ObjectWithOptional struct {
		Time *time.Time `json:"time,omitempty"`
	}

	var optDstTime ObjectWithOptional
	fieldsPresent, err = bindParamsToExplodedObject("explodedObject", values, &optDstTime)
	assert.NoError(t, err)
	assert.True(t, fieldsPresent)
	assert.EqualValues(t, &now, optDstTime.Time)
}

func TestFindRawQueryParam(t *testing.T) {
	tests := []struct {
		name       string
		rawQuery   string
		paramName  string
		wantValues []string
		wantFound  bool
	}{
		{
			name:       "simple value",
			rawQuery:   "color=red",
			paramName:  "color",
			wantValues: []string{"red"},
			wantFound:  true,
		},
		{
			name:       "not found",
			rawQuery:   "color=red",
			paramName:  "size",
			wantValues: nil,
			wantFound:  false,
		},
		{
			name:       "empty query",
			rawQuery:   "",
			paramName:  "color",
			wantValues: nil,
			wantFound:  false,
		},
		{
			name:       "multiple values (exploded)",
			rawQuery:   "color=red&color=blue&color=green",
			paramName:  "color",
			wantValues: []string{"red", "blue", "green"},
			wantFound:  true,
		},
		{
			name:       "comma in value stays encoded",
			rawQuery:   "color=a%2Cb",
			paramName:  "color",
			wantValues: []string{"a%2Cb"},
			wantFound:  true,
		},
		{
			name:       "empty value",
			rawQuery:   "color=",
			paramName:  "color",
			wantValues: []string{""},
			wantFound:  true,
		},
		{
			name:       "no equals sign",
			rawQuery:   "color",
			paramName:  "color",
			wantValues: []string{""},
			wantFound:  true,
		},
		{
			name:       "encoded key",
			rawQuery:   "my%20color=red",
			paramName:  "my color",
			wantValues: []string{"red"},
			wantFound:  true,
		},
		{
			name:       "mixed params",
			rawQuery:   "size=large&color=red&shape=round",
			paramName:  "color",
			wantValues: []string{"red"},
			wantFound:  true,
		},
		{
			name:       "value with special chars",
			rawQuery:   "color=red%26blue%3Dgreen",
			paramName:  "color",
			wantValues: []string{"red%26blue%3Dgreen"},
			wantFound:  true,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			values, found := findRawQueryParam(tt.rawQuery, tt.paramName)
			assert.Equal(t, tt.wantFound, found)
			assert.Equal(t, tt.wantValues, values)
		})
	}
}

func TestBindRawQueryParameter(t *testing.T) {
	type TestObject struct {
		FirstName string `json:"firstName"`
		Role      string `json:"role"`
	}

	t.Run("form/explode=false", func(t *testing.T) {
		t.Run("string slice simple", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", false, true, "color", "color=red,green,blue", &dest)
			require.NoError(t, err)
			assert.Equal(t, []string{"red", "green", "blue"}, dest)
		})

		t.Run("string slice with comma in value", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", false, true, "color", "color=a,b,c%2Cd", &dest)
			require.NoError(t, err)
			assert.Equal(t, []string{"a", "b", "c,d"}, dest)
		})

		t.Run("string slice with multiple special chars", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", false, true, "color", "color=a%2Cb,c%26d,e%3Df", &dest)
			require.NoError(t, err)
			assert.Equal(t, []string{"a,b", "c&d", "e=f"}, dest)
		})

		t.Run("int slice", func(t *testing.T) {
			var dest []int
			err := BindRawQueryParameter("form", false, true, "ids", "ids=1,2,3", &dest)
			require.NoError(t, err)
			assert.Equal(t, []int{1, 2, 3}, dest)
		})

		t.Run("primitive string", func(t *testing.T) {
			var dest string
			err := BindRawQueryParameter("form", false, true, "color", "color=red", &dest)
			require.NoError(t, err)
			assert.Equal(t, "red", dest)
		})

		t.Run("primitive int", func(t *testing.T) {
			var dest int
			err := BindRawQueryParameter("form", false, true, "count", "count=42", &dest)
			require.NoError(t, err)
			assert.Equal(t, 42, dest)
		})

		t.Run("struct (object)", func(t *testing.T) {
			var dest TestObject
			err := BindRawQueryParameter("form", false, true, "id", "id=firstName,Alex,role,admin", &dest)
			require.NoError(t, err)
			assert.Equal(t, TestObject{FirstName: "Alex", Role: "admin"}, dest)
		})

		t.Run("struct with encoded comma in value", func(t *testing.T) {
			var dest TestObject
			err := BindRawQueryParameter("form", false, true, "id", "id=firstName,Alex%2CBob,role,admin", &dest)
			require.NoError(t, err)
			assert.Equal(t, TestObject{FirstName: "Alex,Bob", Role: "admin"}, dest)
		})

		t.Run("required missing", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", false, true, "color", "other=red", &dest)
			assert.Error(t, err)
			assert.Contains(t, err.Error(), "required")
		})

		t.Run("optional missing returns nil", func(t *testing.T) {
			var dest *[]string
			err := BindRawQueryParameter("form", false, false, "color", "other=red", &dest)
			require.NoError(t, err)
			assert.Nil(t, dest)
		})

		t.Run("optional present is populated", func(t *testing.T) {
			var dest *string
			err := BindRawQueryParameter("form", false, false, "color", "color=red", &dest)
			require.NoError(t, err)
			require.NotNil(t, dest)
			assert.Equal(t, "red", *dest)
		})

		// Regression test: primitive string with explode=false should not be
		// split on commas. Per the OpenAPI specification, explode has no effect
		// on primitive types.
		t.Run("string with commas required", func(t *testing.T) {
			var dest string
			err := BindRawQueryParameter("form", false, true, "scope", "scope=openid%2Cprofile%2Cemail", &dest)
			require.NoError(t, err)
			assert.Equal(t, "openid,profile,email", dest)
		})

		t.Run("string with commas optional", func(t *testing.T) {
			var dest *string
			err := BindRawQueryParameter("form", false, false, "scope", "scope=openid%2Cprofile%2Cemail", &dest)
			require.NoError(t, err)
			require.NotNil(t, dest)
			assert.Equal(t, "openid,profile,email", *dest)
		})

		t.Run("duplicate param errors", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", false, true, "color", "color=red&color=blue", &dest)
			assert.Error(t, err)
			assert.Contains(t, err.Error(), "not exploded")
		})
	})

	t.Run("form/explode=true", func(t *testing.T) {
		t.Run("string slice", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", true, true, "color", "color=red&color=green&color=blue", &dest)
			require.NoError(t, err)
			assert.Equal(t, []string{"red", "green", "blue"}, dest)
		})

		t.Run("int slice", func(t *testing.T) {
			var dest []int
			err := BindRawQueryParameter("form", true, true, "ids", "ids=1&ids=2&ids=3", &dest)
			require.NoError(t, err)
			assert.Equal(t, []int{1, 2, 3}, dest)
		})

		t.Run("primitive", func(t *testing.T) {
			var dest string
			err := BindRawQueryParameter("form", true, true, "color", "color=red", &dest)
			require.NoError(t, err)
			assert.Equal(t, "red", dest)
		})

		t.Run("struct", func(t *testing.T) {
			var dest TestObject
			err := BindRawQueryParameter("form", true, true, "id", "firstName=Alex&role=admin", &dest)
			require.NoError(t, err)
			assert.Equal(t, TestObject{FirstName: "Alex", Role: "admin"}, dest)
		})

		t.Run("required missing", func(t *testing.T) {
			var dest []string
			err := BindRawQueryParameter("form", true, true, "color", "other=red", &dest)
			assert.Error(t, err)
		})

		t.Run("optional missing", func(t *testing.T) {
			var dest *string
			err := BindRawQueryParameter("form", true, false, "color", "other=red", &dest)
			require.NoError(t, err)
			assert.Nil(t, dest)
		})
	})

	t.Run("deepObject/explode=true", func(t *testing.T) {
		type ID struct {
			FirstName *string `json:"firstName"`
			Role      string  `json:"role"`
		}
		var dest ID
		err := BindRawQueryParameter("deepObject", true, false, "id", "id%5BfirstName%5D=Alex&id%5Brole%5D=admin", &dest)
		require.NoError(t, err)
		expectedName := "Alex"
		assert.Equal(t, ID{FirstName: &expectedName, Role: "admin"}, dest)
	})

	t.Run("error cases", func(t *testing.T) {
		t.Run("deepObject explode=false", func(t *testing.T) {
			var dest TestObject
			err := BindRawQueryParameter("deepObject", false, true, "id", "id=foo", &dest)
			assert.Error(t, err)
			assert.Contains(t, err.Error(), "exploded")
		})

		// Note: spaceDelimited and pipeDelimited are now supported
		// and have their own test functions below.

		t.Run("unknown style", func(t *testing.T) {
			var dest string
			err := BindRawQueryParameter("unknown", false, true, "color", "color=red", &dest)
			assert.Error(t, err)
			assert.Contains(t, err.Error(), "invalid")
		})
	})
}

func TestRoundTripQueryParameter(t *testing.T) {
	type TestObject struct {
		FirstName string `json:"firstName"`
		Role      string `json:"role"`
	}

	tests := []struct {
		name      string
		style     string
		explode   bool
		paramName string
		value     interface{}
		dest      interface{} // pointer to zero value of dest type
		expected  interface{} // expected value after round-trip
	}{
		{
			name:      "form/false string slice",
			style:     "form",
			explode:   false,
			paramName: "color",
			value:     []string{"red", "green", "blue"},
			dest:      &[]string{},
			expected:  []string{"red", "green", "blue"},
		},
		{
			name:      "form/false string slice with commas",
			style:     "form",
			explode:   false,
			paramName: "color",
			value:     []string{"a,b", "c", "d,e,f"},
			dest:      &[]string{},
			expected:  []string{"a,b", "c", "d,e,f"},
		},
		{
			name:      "form/false int slice",
			style:     "form",
			explode:   false,
			paramName: "ids",
			value:     []int{1, 2, 3},
			dest:      &[]int{},
			expected:  []int{1, 2, 3},
		},
		{
			name:      "form/false primitive string",
			style:     "form",
			explode:   false,
			paramName: "color",
			value:     "red",
			dest:      new(string),
			expected:  "red",
		},
		{
			name:      "form/false struct",
			style:     "form",
			explode:   false,
			paramName: "id",
			value:     TestObject{FirstName: "Alex", Role: "admin"},
			dest:      &TestObject{},
			expected:  TestObject{FirstName: "Alex", Role: "admin"},
		},
		{
			name:      "form/true string slice",
			style:     "form",
			explode:   true,
			paramName: "color",
			value:     []string{"red", "green", "blue"},
			dest:      &[]string{},
			expected:  []string{"red", "green", "blue"},
		},
		{
			name:      "form/true int slice",
			style:     "form",
			explode:   true,
			paramName: "ids",
			value:     []int{1, 2, 3},
			dest:      &[]int{},
			expected:  []int{1, 2, 3},
		},
		{
			name:      "form/true struct",
			style:     "form",
			explode:   true,
			paramName: "id",
			value:     TestObject{FirstName: "Alex", Role: "admin"},
			dest:      &TestObject{},
			expected:  TestObject{FirstName: "Alex", Role: "admin"},
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			// Serialize
			raw, err := StyleParamWithLocation(tt.style, tt.explode, tt.paramName, ParamLocationQuery, tt.value)
			require.NoError(t, err, "StyleParamWithLocation failed")

			// Deserialize
			err = BindRawQueryParameter(tt.style, tt.explode, true, tt.paramName, raw, tt.dest)
			require.NoError(t, err, "BindRawQueryParameter failed for raw=%q", raw)

			// Compare
			actual := reflect.ValueOf(tt.dest).Elem().Interface()
			assert.Equal(t, tt.expected, actual)
		})
	}

	t.Run("deepObject/true struct", func(t *testing.T) {
		original := TestObject{FirstName: "Alex", Role: "admin"}

		raw, err := StyleParamWithLocation("deepObject", true, "id", ParamLocationQuery, original)
		require.NoError(t, err)

		var dest TestObject
		err = BindRawQueryParameter("deepObject", true, true, "id", raw, &dest)
		require.NoError(t, err)
		assert.Equal(t, original, dest)
	})
}

func TestBindStyledParameterWithOptions_LabelPrimitive(t *testing.T) {
	tests := []struct {
		name    string
		explode bool
		value   string
		want    int32
	}{
		{"non-exploded", false, ".5", 5},
		{"exploded", true, ".5", 5},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			var dest int32
			err := BindStyledParameterWithOptions("label", "param", tt.value, &dest, BindStyledParameterOptions{
				ParamLocation: ParamLocationPath,
				Explode:       tt.explode,
				Required:      true,
			})
			require.NoError(t, err)
			assert.Equal(t, tt.want, dest)
		})
	}
}

func TestBindStyledParameterWithOptions_MatrixPrimitive(t *testing.T) {
	tests := []struct {
		name    string
		explode bool
		value   string
		want    int32
	}{
		{"non-exploded", false, ";param=5", 5},
		{"exploded", true, ";param=5", 5},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			var dest int32
			err := BindStyledParameterWithOptions("matrix", "param", tt.value, &dest, BindStyledParameterOptions{
				ParamLocation: ParamLocationPath,
				Explode:       tt.explode,
				Required:      true,
			})
			require.NoError(t, err)
			assert.Equal(t, tt.want, dest)
		})
	}
}

func TestBindStyledParameterWithLocation(t *testing.T) {
	t.Run("bigNumber", func(t *testing.T) {
		expectedBig := big.NewInt(12345678910)
		var dstBigNumber big.Int

		err := BindStyledParameterWithOptions("simple", "id", "12345678910", &dstBigNumber, BindStyledParameterOptions{
			ParamLocation: ParamLocationUndefined,
			Explode:       false,
			Required:      false,
		})
		assert.NoError(t, err)
		assert.Equal(t, *expectedBig, dstBigNumber)
	})

	t.Run("object", func(t *testing.T) {
		type Object struct {
			Key1 string `json:"key1"`
			Key2 string `json:"key2"`
		}
		expectedObject := Object{
			Key1: "value1",
			Key2: "42",
		}
		var dstObject Object

		err := BindStyledParameterWithOptions("simple", "map", "key1,value1,key2,42", &dstObject, BindStyledParameterOptions{
			ParamLocation: ParamLocationUndefined,
			Explode:       false,
			Required:      false,
		})
		assert.NoError(t, err)
		assert.EqualValues(t, expectedObject, dstObject)
	})

	t.Run("map", func(t *testing.T) {
		expectedMap := map[string]any{
			"key1": "value1",
			"key2": "42",
		}
		var dstMap map[string]any

		err := BindStyledParameterWithOptions("simple", "map", "key1,value1,key2,42", &dstMap, BindStyledParameterOptions{
			ParamLocation: ParamLocationUndefined,
			Explode:       false,
			Required:      false,
		})
		assert.NoError(t, err)
		assert.EqualValues(t, expectedMap, dstMap)
	})
}

// TestBindStyledParameter_HeaderWithCommas reproduces
// https://github.com/oapi-codegen/runtime/issues/114
// Header parameters using simple style should accept string values containing
// commas without treating them as array delimiters.
func TestBindStyledParameter_HeaderWithCommas(t *testing.T) {
	t.Run("primitive string with commas", func(t *testing.T) {
		var dest string
		// A JSON string header value that happens to contain commas.
		err := BindStyledParameterWithOptions("simple", "X-My-Header", `{"key":"value","other":"data"}`, &dest, BindStyledParameterOptions{
			ParamLocation: ParamLocationHeader,
			Explode:       false,
			Required:      true,
		})
		assert.NoError(t, err)
		assert.Equal(t, `{"key":"value","other":"data"}`, dest)
	})

	t.Run("primitive string with many commas", func(t *testing.T) {
		var dest string
		err := BindStyledParameterWithOptions("simple", "X-My-Header", "a,b,c,d,e", &dest, BindStyledParameterOptions{
			ParamLocation: ParamLocationHeader,
			Explode:       false,
			Required:      true,
		})
		assert.NoError(t, err)
		assert.Equal(t, "a,b,c,d,e", dest)
	})

	t.Run("primitive string without commas still works", func(t *testing.T) {
		var dest string
		err := BindStyledParameterWithOptions("simple", "X-My-Header", "simple-value", &dest, BindStyledParameterOptions{
			ParamLocation: ParamLocationHeader,
			Explode:       false,
			Required:      true,
		})
		assert.NoError(t, err)
		assert.Equal(t, "simple-value", dest)
	})

	t.Run("array of strings still splits on commas", func(t *testing.T) {
		var dest []string
		err := BindStyledParameterWithOptions("simple", "X-My-Header", "a,b,c", &dest, BindStyledParameterOptions{
			ParamLocation: ParamLocationHeader,
			Explode:       false,
			Required:      true,
		})
		assert.NoError(t, err)
		assert.Equal(t, []string{"a", "b", "c"}, dest)
	})
}

func TestBindQueryParameter_SpaceDelimited(t *testing.T) {
	t.Run("unexploded int array", func(t *testing.T) {
		var dest []int
		q := make(url.Values)
		q.Set("ids", "3 4 5")
		err := BindQueryParameterWithOptions("spaceDelimited", false, true, "ids", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("unexploded string array", func(t *testing.T) {
		var dest []string
		q := make(url.Values)
		q.Set("color", "red green blue")
		err := BindQueryParameterWithOptions("spaceDelimited", false, true, "color", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Equal(t, []string{"red", "green", "blue"}, dest)
	})

	t.Run("exploded int array", func(t *testing.T) {
		var dest []int
		q := make(url.Values)
		q["ids"] = []string{"3", "4", "5"}
		err := BindQueryParameterWithOptions("spaceDelimited", true, true, "ids", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("optional missing", func(t *testing.T) {
		var dest *[]int
		q := make(url.Values)
		err := BindQueryParameterWithOptions("spaceDelimited", false, false, "ids", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Nil(t, dest)
	})

	t.Run("required missing", func(t *testing.T) {
		var dest []int
		q := make(url.Values)
		err := BindQueryParameterWithOptions("spaceDelimited", false, true, "ids", q, &dest, BindQueryParameterOptions{})
		assert.Error(t, err)
		assert.Contains(t, err.Error(), "required")
	})
}

func TestBindQueryParameter_PipeDelimited(t *testing.T) {
	t.Run("unexploded int array", func(t *testing.T) {
		var dest []int
		q := make(url.Values)
		q.Set("ids", "3|4|5")
		err := BindQueryParameterWithOptions("pipeDelimited", false, true, "ids", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("unexploded string array", func(t *testing.T) {
		var dest []string
		q := make(url.Values)
		q.Set("color", "red|green|blue")
		err := BindQueryParameterWithOptions("pipeDelimited", false, true, "color", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Equal(t, []string{"red", "green", "blue"}, dest)
	})

	t.Run("exploded int array", func(t *testing.T) {
		var dest []int
		q := make(url.Values)
		q["ids"] = []string{"3", "4", "5"}
		err := BindQueryParameterWithOptions("pipeDelimited", true, true, "ids", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("optional missing", func(t *testing.T) {
		var dest *[]int
		q := make(url.Values)
		err := BindQueryParameterWithOptions("pipeDelimited", false, false, "ids", q, &dest, BindQueryParameterOptions{})
		require.NoError(t, err)
		assert.Nil(t, dest)
	})

	t.Run("required missing", func(t *testing.T) {
		var dest []int
		q := make(url.Values)
		err := BindQueryParameterWithOptions("pipeDelimited", false, true, "ids", q, &dest, BindQueryParameterOptions{})
		assert.Error(t, err)
		assert.Contains(t, err.Error(), "required")
	})
}

func TestBindRawQueryParameter_SpaceDelimited(t *testing.T) {
	t.Run("unexploded with %20", func(t *testing.T) {
		var dest []int
		err := BindRawQueryParameter("spaceDelimited", false, true, "ids", "ids=3%204%205", &dest)
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("unexploded with +", func(t *testing.T) {
		var dest []int
		err := BindRawQueryParameter("spaceDelimited", false, true, "ids", "ids=3+4+5", &dest)
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("unexploded strings", func(t *testing.T) {
		var dest []string
		err := BindRawQueryParameter("spaceDelimited", false, true, "color", "color=red%20green%20blue", &dest)
		require.NoError(t, err)
		assert.Equal(t, []string{"red", "green", "blue"}, dest)
	})

	t.Run("exploded", func(t *testing.T) {
		var dest []int
		err := BindRawQueryParameter("spaceDelimited", true, true, "ids", "ids=3&ids=4&ids=5", &dest)
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("optional missing", func(t *testing.T) {
		var dest *[]int
		err := BindRawQueryParameter("spaceDelimited", false, false, "ids", "other=val", &dest)
		require.NoError(t, err)
		assert.Nil(t, dest)
	})
}

func TestBindRawQueryParameter_PipeDelimited(t *testing.T) {
	t.Run("unexploded", func(t *testing.T) {
		var dest []int
		err := BindRawQueryParameter("pipeDelimited", false, true, "ids", "ids=3|4|5", &dest)
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("unexploded strings", func(t *testing.T) {
		var dest []string
		err := BindRawQueryParameter("pipeDelimited", false, true, "color", "color=red|green|blue", &dest)
		require.NoError(t, err)
		assert.Equal(t, []string{"red", "green", "blue"}, dest)
	})

	t.Run("exploded", func(t *testing.T) {
		var dest []int
		err := BindRawQueryParameter("pipeDelimited", true, true, "ids", "ids=3&ids=4&ids=5", &dest)
		require.NoError(t, err)
		assert.Equal(t, []int{3, 4, 5}, dest)
	})

	t.Run("optional missing", func(t *testing.T) {
		var dest *[]int
		err := BindRawQueryParameter("pipeDelimited", false, false, "ids", "other=val", &dest)
		require.NoError(t, err)
		assert.Nil(t, dest)
	})
}

func TestRoundTripQueryParameter_Delimited(t *testing.T) {
	tests := []struct {
		name      string
		style     string
		explode   bool
		paramName string
		value     interface{}
		dest      interface{}
		expected  interface{}
	}{
		{
			name:      "spaceDelimited/false int slice",
			style:     "spaceDelimited",
			explode:   false,
			paramName: "ids",
			value:     []int{1, 2, 3},
			dest:      &[]int{},
			expected:  []int{1, 2, 3},
		},
		{
			name:      "spaceDelimited/false string slice",
			style:     "spaceDelimited",
			explode:   false,
			paramName: "color",
			value:     []string{"red", "green", "blue"},
			dest:      &[]string{},
			expected:  []string{"red", "green", "blue"},
		},
		{
			name:      "spaceDelimited/true int slice",
			style:     "spaceDelimited",
			explode:   true,
			paramName: "ids",
			value:     []int{1, 2, 3},
			dest:      &[]int{},
			expected:  []int{1, 2, 3},
		},
		{
			name:      "pipeDelimited/false int slice",
			style:     "pipeDelimited",
			explode:   false,
			paramName: "ids",
			value:     []int{1, 2, 3},
			dest:      &[]int{},
			expected:  []int{1, 2, 3},
		},
		{
			name:      "pipeDelimited/false string slice",
			style:     "pipeDelimited",
			explode:   false,
			paramName: "color",
			value:     []string{"red", "green", "blue"},
			dest:      &[]string{},
			expected:  []string{"red", "green", "blue"},
		},
		{
			name:      "pipeDelimited/true int slice",
			style:     "pipeDelimited",
			explode:   true,
			paramName: "ids",
			value:     []int{1, 2, 3},
			dest:      &[]int{},
			expected:  []int{1, 2, 3},
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			raw, err := StyleParamWithLocation(tt.style, tt.explode, tt.paramName, ParamLocationQuery, tt.value)
			require.NoError(t, err, "StyleParamWithLocation failed")

			err = BindRawQueryParameter(tt.style, tt.explode, true, tt.paramName, raw, tt.dest)
			require.NoError(t, err, "BindRawQueryParameter failed for raw=%q", raw)

			actual := reflect.ValueOf(tt.dest).Elem().Interface()
			assert.Equal(t, tt.expected, actual)
		})
	}
}

// TestBindStyledParameterValueIsUnescaped covers issue #35: routers differ
// in whether they deliver path parameters raw or already decoded, so the
// generated wrapper declares it via ValueIsUnescaped rather than the binder
// unconditionally unescaping (which double-decoded values containing
// literal percent signs). The zero value preserves the historical
// unescaping for existing callers.
func TestBindStyledParameterValueIsUnescaped(t *testing.T) {
	var dst string

	// By default, values are treated as escaped and unescaped by location —
	// the historical behavior of existing generated code.
	err := BindStyledParameterWithOptions("simple", "param1", "discount%2520", &dst, BindStyledParameterOptions{
		ParamLocation: ParamLocationPath,
		Required:      true,
	})
	require.NoError(t, err)
	assert.Equal(t, "discount%20", dst)

	err = BindStyledParameterWithOptions("form", "param1", "a+b%2Fc", &dst, BindStyledParameterOptions{
		ParamLocation: ParamLocationQuery,
		Required:      true,
	})
	require.NoError(t, err)
	assert.Equal(t, "a b/c", dst)

	// A router-decoded value binds verbatim when the wrapper says so: a
	// value that legitimately contains a percent sequence is not decoded
	// again...
	err = BindStyledParameterWithOptions("simple", "param1", "discount%20", &dst, BindStyledParameterOptions{
		ParamLocation:    ParamLocationPath,
		Required:         true,
		ValueIsUnescaped: true,
	})
	require.NoError(t, err)
	assert.Equal(t, "discount%20", dst)

	// ...and a bare percent doesn't fail as an invalid escape.
	err = BindStyledParameterWithOptions("simple", "param1", "15%off", &dst, BindStyledParameterOptions{
		ParamLocation:    ParamLocationPath,
		Required:         true,
		ValueIsUnescaped: true,
	})
	require.NoError(t, err)
	assert.Equal(t, "15%off", dst)

	// The deprecated entry points always unescaped; the zero value keeps
	// that behavior for the old generated code that calls them.
	err = BindStyledParameterWithLocation("simple", false, "param1", ParamLocationPath, "discount%2520", &dst)
	require.NoError(t, err)
	assert.Equal(t, "discount%20", dst)

	err = BindStyledParameter("simple", false, "param1", "a+b", &dst)
	require.NoError(t, err)
	assert.Equal(t, "a b", dst)
}