From 011e31a32028d91827066f5ee89cf0e24c501049 Mon Sep 17 00:00:00 2001 From: hpoeche Date: Thu, 29 Oct 2026 15:39:36 +0100 Subject: [PATCH] CI: Fix sdk dependency in `server-docker` job (#680) This commit tackles the same issue that commit a29d190 solved for the `server-test` job. See the message of that commit for further details. The `server-docker` job runs integration tests from `server/test/docker_integration` which imports modules from `server/app` which again imports modules from the sdk package. These imports fail, when they refer to elements that are not existing in the last released sdk version. Therefore we apply the same fix as in a291d90 as workaround for #592. Fixes #680 --- .github/workflows/pr.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index dd20862c..142d6a45 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -425,6 +425,11 @@ jobs: steps: - name: Checkout Repository uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 #v5.1.0 + with: + # TODO(#592): revisit when the sdk<->server version pinning is fixed. + # Need tags so setuptools_scm builds the local sdk as >=1.0.0, else the loose + # `basyx-python-sdk>=1.0.0` pin lets pip replace it with the PyPI release. + fetch-depth: 0 - uses: ./.github/actions/load-versions @@ -459,7 +464,7 @@ jobs: run: | python -m pip install --upgrade pip python -m pip install ../sdk - python -m pip install . + python -m pip install .[dev] - name: Run Docker integration tests # Each profile has its own test module working-directory: ./server