From e2d6dac04aae4b355ea5af0c2dea494461f752e0 Mon Sep 17 00:00:00 2001
From: Richard Webb <Richard.Webb@BoldonJames.com>
Date: Tue, 28 Jul 2026 23:38:40 +0100
Subject: [PATCH] Core: upgrade FCS to v43.12.204

Update to the latest version

Picks up the breaking API change from
https://github.com/dotnet/fsharp/pull/19298
to make BasicQualifiedName an option instead of throwing when
there is no value
---
 Directory.Packages.props                  |  4 ++--
 src/FSharpLint.Core/Rules/NamingHelper.fs | 22 ++++++++--------------
 2 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/Directory.Packages.props b/Directory.Packages.props
index b58b86286..579d6bfee 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -8,9 +8,9 @@
     <PackageVersion Include="BenchmarkDotNet" Version="0.15.2" />
     <PackageVersion Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.15.2" />
     <PackageVersion Include="FParsec" Version="1.1.1" />
-    <PackageVersion Include="FSharp.Compiler.Service" Version="43.12.201" />
+    <PackageVersion Include="FSharp.Compiler.Service" Version="43.12.204" />
     <PackageVersion Include="FSharp.Control.Reactive" Version="6.1.2" />
-    <PackageVersion Include="FSharp.Core" Version="10.1.201" />
+    <PackageVersion Include="FSharp.Core" Version="10.1.204" />
     <PackageVersion Include="FSharpx.Collections" Version="3.1.0" />
     <PackageVersion Include="Ionide.ProjInfo.ProjectSystem" Version="0.70.2" />
     <PackageVersion Include="Ionide.ProjInfo.FCS" Version="0.70.2" />
diff --git a/src/FSharpLint.Core/Rules/NamingHelper.fs b/src/FSharpLint.Core/Rules/NamingHelper.fs
index 0c60915fc..34b80706c 100644
--- a/src/FSharpLint.Core/Rules/NamingHelper.fs
+++ b/src/FSharpLint.Core/Rules/NamingHelper.fs
@@ -499,17 +499,11 @@ module Asynchronous =
         | _ -> ReturnsNonAsync
     
     let (|FSharpTypeAsync|FSharpTypeTask|FSharpTypeTaskNonGeneric|FSharpTypeNonAsync|) (fSharpType: FSharpType) =
-        try
-            // BasicQualifiedName may throw InvalidOperationException for some types
-            // e.g. arrays, but not for Async<'T> or Task<'T>, so assume non-async type.
-            match fSharpType.BasicQualifiedName with
-            | "Microsoft.FSharp.Control.FSharpAsync`1" -> FSharpTypeAsync
-            | name when name.StartsWith "System.Threading.Tasks.Task" ->
-                if fSharpType.GenericArguments.Count > 0 then
-                    FSharpTypeTask
-                else
-                    FSharpTypeTaskNonGeneric
-            | _ -> FSharpTypeNonAsync
-        with
-        | :? InvalidOperationException ->
-            FSharpTypeNonAsync
+        match fSharpType.BasicQualifiedName with
+        | Some "Microsoft.FSharp.Control.FSharpAsync`1" -> FSharpTypeAsync
+        | Some name when name.StartsWith "System.Threading.Tasks.Task" ->
+            if fSharpType.GenericArguments.Count > 0 then
+                FSharpTypeTask
+            else
+                FSharpTypeTaskNonGeneric
+        | _ -> FSharpTypeNonAsync