lint.yml

name: Lint
permissions:
  contents: read

on:
  push:
    branches: ["main"]
  pull_request:

jobs:
  markdownlint:
    runs-on: ubuntu-latest
    env:
      DOC_GLOBS: |
        docs/**/*.md
        README.md
        README.zh-CN.md
        CODE_OF_CONDUCT.md
        CONTRIBUTING.md
        DEVELOPMENT.md
        SECURITY.md
        SUPPORT.md
        spec-driven.md
        integrations/*.md
        presets/*.md
        workflows/*.md
    steps:
      - name: Checkout
        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
        with:
          fetch-depth: 1

      - name: Run git diff --check
        shell: bash
        env:
          EVENT_NAME: ${{ github.event_name }}
          PR_BASE_SHA: ${{ github.event.pull_request.base.sha }}
          PUSH_BEFORE_SHA: ${{ github.event.before }}
          GITHUB_SHA: ${{ github.sha }}
        run: |
          set -euo pipefail

          if [ "$EVENT_NAME" = "pull_request" ]; then
            git fetch --no-tags --depth=1 origin "+${PR_BASE_SHA}:refs/checks/pr-base"
            git diff --check refs/checks/pr-base HEAD
          elif [ "$PUSH_BEFORE_SHA" = "0000000000000000000000000000000000000000" ]; then
            git diff-tree --check --no-commit-id --root -r "$GITHUB_SHA"
          else
            git fetch --no-tags --depth=1 origin "+${PUSH_BEFORE_SHA}:refs/checks/push-before"
            git diff --check refs/checks/push-before HEAD
          fi

      # Documentation only. Commands, skills, prompt templates, agent
      # instructions (AGENTS.md) and .github/ content are inputs to coding
      # agents rather than prose, and are deliberately left unlinted so a
      # documentation pass never reformats them. Add new documentation
      # paths to the DOC_GLOBS list above.
      - name: Verify the documentation globs match files
        shell: bash
        run: |
          set -euo pipefail
          shopt -s globstar nullglob

          # Checked per glob, not on the total: one stale entry among several
          # still leaves that part of the documentation unlinted, which is the
          # failure #4526 was about.
          count=0
          empty=()
          while IFS= read -r glob; do
            [ -z "$glob" ] && continue
            matched=0
            for path in $glob; do
              [ -f "$path" ] && matched=$((matched + 1))
            done
            # An array, not a string: nullglob is on, so re-expanding an
            # unquoted list of unmatched globs would erase it.
            [ "$matched" -eq 0 ] && empty+=("$glob")
            count=$((count + matched))
          done <<< "$DOC_GLOBS"

          echo "documentation files matched: $count"
          if [ ${#empty[@]} -gt 0 ]; then
            for glob in "${empty[@]}"; do
              echo "::error::markdownlint glob matches no files: $glob (see #4526)"
            done
            exit 1
          fi

      - name: Run markdownlint-cli2
        uses: DavidAnson/markdownlint-cli2-action@21c1be1b93ad9ed58fa840aacc3f279cde2a72ff # v24.2.0
        with:
          globs: ${{ env.DOC_GLOBS }}

  shellcheck:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

      # shellcheck is preinstalled on ubuntu-latest runners.
      # Start at --severity=error to block real bugs without flagging style
      # (notably SC2155). Tighten in a follow-up after cleanup.
      - name: Run shellcheck on shell scripts
        run: git ls-files -z -- '*.sh' | xargs -0 shellcheck --severity=error

      # macOS ships bash 3.2, where bash 4+ case-modification parameter
      # expansions error with "bad substitution". shellcheck assumes bash 4+
      # from the shebang and cannot flag these, so guard explicitly; use tr
      # for portable case conversion.
      - name: Reject bash 4+ case-modification expansions
        run: |
          matches=$(git ls-files -z -- '*.sh' | xargs -0 grep -nE '\$\{[A-Za-z_][A-Za-z0-9_]*(\[[^]]*\])?(\^\^?|,,?|~~?|@[UuLl])[^}]*\}' || true)
          if [ -n "$matches" ]; then
            echo "Found bash 4+ case-modification expansion(s); use tr for portability (macOS ships bash 3.2):"
            echo "$matches"
            exit 1
          fi