Skip to content

Commit 6c4469d

Browse files
test(workflows): correct two filter test comments
The upper test said non-ASCII passes through unchanged while asserting that "café" becomes "CAFÉ": Unicode case mapping applies and nothing is transliterated or lost. The split test called split the inverse of join, which is not generally true when an element contains the separator; the assertion converts a delimiter by composing split with join. Both were the two low-severity findings on the current head. Assisted-by: opencode (model: mimo-v2.6-flash-free, autonomous)
1 parent f662854 commit 6c4469d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎tests/test_workflows.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ def test_filter_upper_and_lower(self):
611611
assert evaluate_expression("{{ inputs.empty | lower }}", ctx) == ""
612612
# Case-only transforms are no-ops on already-conforming input.
613613
assert evaluate_expression("{{ inputs.mixed | upper }}", ctx) == "ABC"
614-
# Non-ASCII must pass through unchanged (no transliteration/loss).
614+
# Non-ASCII text uses Unicode case mapping without transliteration or loss.
615615
assert evaluate_expression("{{ inputs.uni | upper }}", StepContext(inputs={"uni": "café"})) == "CAFÉ"
616616
# Filters compose left to right with the rest of the chain.
617617
assert evaluate_expression("{{ inputs.s | upper | lower }}", ctx) == "hello world"
@@ -662,7 +662,7 @@ def test_filter_split(self):
662662
assert evaluate_expression("{{ inputs.nodelim | split(',') }}", ctx) == ["abc"]
663663
# Trailing empty field is preserved, so round-tripping is lossless.
664664
assert evaluate_expression("{{ inputs.trailing | split(',') }}", ctx) == ["a", "b", ""]
665-
# split is the inverse of join.
665+
# split composes with join to convert delimiters.
666666
assert evaluate_expression("{{ inputs.csv | split(',') | join('-') }}", ctx) == "a-b-c"
667667

668668
def test_filter_split_rejects_non_string_inputs(self):

0 commit comments

Comments
 (0)