From 195739f53a0f4fda38b8c06fdc466c0414b8033f Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 10:09:29 +0200 Subject: [PATCH 01/41] Respect per-turn interview question budgets in Brunch Carry the current allowance alongside immutable Flue birth data, preserve Off requests, and keep budget context separate from human evidence and transcript display. Co-authored-by: Amp --- .../src/agents/chat-agent/agent.ts | 15 ++++- .../test/chat-agent-mounting.test.ts | 49 ++++++++++++++++ .../packages/plugin-sdcpn/src/flue.ts | 12 ++++ .../packages/plugin-sdcpn/src/index.ts | 4 ++ .../packages/plugin-sdcpn/src/initial-data.ts | 7 ++- .../plugin-sdcpn/src/interview-budget.ts | 44 +++++++++++++++ .../src/skills/sdcpn-modelling/SKILL.md | 13 +++++ .../test/interview-budget.test.ts | 56 +++++++++++++++++++ .../src/contextual-user-message.ts | 34 ++++++++--- .../packages/transport-aisdk/src/index.ts | 10 +++- .../transport-aisdk/src/transcript.ts | 12 +++- .../test/interview-budget.test.ts | 43 ++++++++++++++ .../transport-aisdk/test/transcript.test.ts | 49 +++++++++++++++- 13 files changed, 335 insertions(+), 13 deletions(-) create mode 100644 libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/interview-budget.ts create mode 100644 libs/@hashintel/brunch-agent/packages/plugin-sdcpn/test/interview-budget.test.ts create mode 100644 libs/@hashintel/brunch-agent/packages/transport-aisdk/test/interview-budget.test.ts diff --git a/apps/brunch-agent/src/agents/chat-agent/agent.ts b/apps/brunch-agent/src/agents/chat-agent/agent.ts index ecb9a0226b7..903e66f5760 100644 --- a/apps/brunch-agent/src/agents/chat-agent/agent.ts +++ b/apps/brunch-agent/src/agents/chat-agent/agent.ts @@ -9,6 +9,7 @@ import { useContextProjection, + useDelivery, useInitialData, useInstruction, useTool, @@ -16,14 +17,17 @@ import { } from "@flue/runtime"; import { createAgentRouter } from "@flue/runtime/routing"; import { createFlueClient } from "@flue/sdk"; +import * as v from "valibot"; import { createWorkpieceReadTool } from "@hashintel/brunch-agent"; import { canonicalContent, + interviewBudgetSchema, sdcpnInitialDataSchema, type SdcpnInitialData, } from "@hashintel/brunch-agent-plugin-sdcpn"; import { useSdcpnPlugin } from "@hashintel/brunch-agent-plugin-sdcpn/flue"; +import { parsePetrinautUserMessageBody } from "@hashintel/brunch-agent-transport-aisdk"; import { useBrunchAgent } from "@hashintel/brunch-agent/flue"; import { getLatestNetDefinitionToolName } from "@hashintel/petrinaut-core"; @@ -56,6 +60,14 @@ const chatModelOptions = { export function ChatAgent({ id }: AgentProps) { const initialData = useInitialData(); + // Flue initialData is immutable birth data. The durable current delivery + // carries the changing allowance and an ordinary body explicitly means Off. + const delivery = useDelivery(); + const body = parsePetrinautUserMessageBody(delivery.body); + const interviewBudget = v.parse( + v.optional(interviewBudgetSchema), + body.kind === "contextual" ? body.interviewBudget : undefined, + ); useContextProjection(projectBrunchContext); // Agent-local acquisition of this already-authorized instance's public history. // Reuse the existing router and storage; no listener, companion log or private records. @@ -77,6 +89,7 @@ export function ChatAgent({ id }: AgentProps) { useSdcpnPlugin( initialData ? { + interviewBudget, authorizeDraft: async (draftCallId: string) => { if (!latestNetReadBefore(await history(), draftCallId)) throw new Error( @@ -100,7 +113,7 @@ export function ChatAgent({ id }: AgentProps) { return { output: result.output, metadata: result.metadata }; }, } - : {}, + : { interviewBudget }, ); if (initialData) { useTool(createWorkpieceReadTool({ currentRevision, readSources })); diff --git a/apps/brunch-agent/test/chat-agent-mounting.test.ts b/apps/brunch-agent/test/chat-agent-mounting.test.ts index e1cee9580b1..8b0f935e187 100644 --- a/apps/brunch-agent/test/chat-agent-mounting.test.ts +++ b/apps/brunch-agent/test/chat-agent-mounting.test.ts @@ -3,6 +3,7 @@ import { afterEach, beforeEach, expect, test, vi } from "vitest"; import { brunchTools } from "@hashintel/brunch-agent"; import { sdcpnInitialDataSchema } from "@hashintel/brunch-agent-plugin-sdcpn"; +import { petrinautContextualUserMessageBody } from "@hashintel/brunch-agent-transport-aisdk"; import { petrinautAiCapabilityGuidance, petrinautAiTools, @@ -16,6 +17,7 @@ import { const mounted = vi.hoisted(() => ({ initialData: undefined as unknown, + body: "Four agents", contextProjections: 0, instructions: [] as string[], models: [] as string[], @@ -28,6 +30,7 @@ vi.mock("@flue/runtime", async (importOriginal) => ({ mounted.contextProjections += 1; }, useInitialData: () => mounted.initialData, + useDelivery: () => ({ kind: "user", body: mounted.body }), useInstruction: (instruction: string) => mounted.instructions.push(instruction), useModel: (model: string) => mounted.models.push(model), @@ -59,6 +62,7 @@ beforeEach(() => { vi.stubEnv("BRUNCH_CHAT_MODEL", "claude-sonnet-4-6"); vi.stubEnv("NODE_ENV", "test"); mounted.initialData = undefined; + mounted.body = "Four agents"; mounted.contextProjections = 0; mounted.instructions.length = 0; mounted.models.length = 0; @@ -107,6 +111,51 @@ test("the agent admits a document binding or no initial data", () => { expect(v.parse(sdcpnInitialDataSchema, undefined)).toBeUndefined(); }); +test("current budget replaces birth data and switching Off restores exactly the baseline prompt", async () => { + mounted.initialData = bound; + const { ChatAgent: renderChatAgent } = + await import("../src/agents/chat-agent/agent.ts"); + const baseline = renderChatAgent({ id: "budget" }); + const baselineInstructions = [...mounted.instructions]; + mounted.initialData = { + ...bound, + interviewBudget: { + level: "standard", + questionCap: 6, + asked: 0, + remaining: 6, + }, + }; + for (const remaining of [1, 0]) { + mounted.instructions.length = 0; + mounted.body = petrinautContextualUserMessageBody({ + userText: "Four agents", + diagnosticsContext: "", + interviewBudget: { + level: "quick", + questionCap: 3, + asked: 3 - remaining, + remaining, + }, + }); + expect(renderChatAgent({ id: "budget" })).toBe(baseline); + const budgetInstructions = mounted.instructions.filter( + (instruction) => !baselineInstructions.includes(instruction), + ); + expect(budgetInstructions).toHaveLength(1); + expect(budgetInstructions[0]).toContain(`remaining: ${remaining}`); + expect(budgetInstructions[0]).toContain( + remaining + ? "most consequential open fact" + : "do not ask another question", + ); + } + mounted.instructions.length = 0; + mounted.body = "Four agents"; + expect(renderChatAgent({ id: "budget" })).toBe(baseline); + expect(mounted.instructions).toEqual(baselineInstructions); +}); + test("the Brunch catalogue classifies every canonical tool", () => { const canonicalNames = Object.keys(petrinautAiTools); expect(canonicalPetrinautToolCatalogue.map(({ name }) => name)).toEqual( diff --git a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/flue.ts b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/flue.ts index 67bcb7088a5..1094c68dc6e 100644 --- a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/flue.ts +++ b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/flue.ts @@ -15,6 +15,10 @@ import sdcpnModellingSkill from "@hashintel/brunch-agent-plugin-sdcpn/skills/sdc import { petrinautAiCapabilityGuidance } from "@hashintel/petrinaut-core/ai"; import { type SdcpnInitialData } from "./initial-data"; +import { + interviewBudgetInstruction, + type InterviewBudget, +} from "./interview-budget"; import sdcpnAppend from "./prompts/APPEND_SYSTEM.md?raw"; import { createDraftExperimentTool } from "./tools/draft-experiment"; import { @@ -23,12 +27,20 @@ import { } from "./tools/petrinaut-construction"; export const useSdcpnPlugin = (options?: { + /** Current delivery overrides creation-only initialData, including Off. */ + readonly interviewBudget?: InterviewBudget; readonly executeBrowserTool?: BrowserToolExecutor; readonly authorizeDraft?: Parameters< typeof createDraftExperimentTool >[0]["authorizeDraft"]; }): void => { const initialData = useInitialData(); + const instruction = interviewBudgetInstruction( + options && "interviewBudget" in options + ? options.interviewBudget + : initialData?.interviewBudget, + ); + if (instruction) useInstruction(instruction); if (initialData) { useInstruction(sdcpnAppend.trim()); useInstruction(petrinautAiCapabilityGuidance); diff --git a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/index.ts b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/index.ts index 05d70cdb3a0..f07009876f3 100644 --- a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/index.ts +++ b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/index.ts @@ -18,6 +18,10 @@ export { type BrowserContext, type SdcpnInitialData, } from "./initial-data"; +export { + interviewBudgetSchema, + type InterviewBudget, +} from "./interview-budget"; export { draftPetrinautExperimentInputSchema, draftPetrinautExperimentOutputSchema, diff --git a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/initial-data.ts b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/initial-data.ts index 93ce64f5874..85d9a176789 100644 --- a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/initial-data.ts +++ b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/initial-data.ts @@ -1,5 +1,7 @@ import * as v from "valibot"; +import { interviewBudgetSchema } from "./interview-budget"; + const browserBindingSchema = v.strictObject({ conversationId: v.string(), documentId: v.string(), @@ -7,7 +9,10 @@ const browserBindingSchema = v.strictObject({ }); export const sdcpnInitialDataSchema = v.optional( - v.object({ binding: browserBindingSchema }), + v.object({ + binding: browserBindingSchema, + interviewBudget: v.optional(interviewBudgetSchema), + }), ); export type SdcpnInitialData = v.InferOutput; diff --git a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/interview-budget.ts b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/interview-budget.ts new file mode 100644 index 00000000000..847d6332c7c --- /dev/null +++ b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/interview-budget.ts @@ -0,0 +1,44 @@ +import * as v from "valibot"; + +const count = v.pipe(v.number(), v.integer(), v.minValue(0)); + +/** A question allowance, never a clock or evidence that the model is complete. */ +export const interviewBudgetSchema = v.pipe( + v.strictObject({ + level: v.picklist(["quick", "standard", "thorough", "deep"]), + questionCap: v.nullable(v.pipe(count, v.minValue(1))), + asked: count, + remaining: v.nullable(count), + }), + v.check( + (budget) => + budget.level === "deep" + ? budget.questionCap === null && budget.remaining === null + : budget.questionCap !== null && + budget.remaining === Math.max(0, budget.questionCap - budget.asked), + "The remaining question allowance must match the level, cap and count.", + ), +); + +export type InterviewBudget = v.InferOutput; + +export const interviewBudgetInstruction = ( + budget: InterviewBudget | undefined, +): string | undefined => { + if (!budget) return undefined; + const timeGuide = { + quick: "about 5 minutes", + standard: "about 10 minutes", + thorough: "about 20 minutes", + deep: "no limit", + }[budget.level]; + const next = + budget.remaining === null + ? "There is no cap; offer a pause between topics rather than closing because of the count." + : budget.remaining === 0 + ? "The cap is reached: settle this answer, then close with stated facts, Assumed facts and open items listed by name; do not ask another question." + : budget.remaining === 1 + ? "Make the last question the most consequential open fact." + : "Choose the next question according to this level."; + return `Interview budget: the person chose ${budget.level} (${timeGuide}; minutes are a guide, not a timer). Follow the Budget section of sdcpn-modelling. Record the level on the first turn under "Available time and assumption appetite", and update it when changed without repeating settled facts. Questions asked: ${budget.asked}; cap: ${budget.questionCap ?? "none"}; remaining: ${budget.remaining ?? "unlimited"}. ${next} Never invent operational facts, ranges or units. Reaching the cap is not completion; leave unsupported facts open.`; +}; diff --git a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/skills/sdcpn-modelling/SKILL.md b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/skills/sdcpn-modelling/SKILL.md index 0de443d9591..543c9382874 100644 --- a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/skills/sdcpn-modelling/SKILL.md +++ b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/src/skills/sdcpn-modelling/SKILL.md @@ -21,6 +21,19 @@ Establish enough purpose and context to select one focused next action: the inte For a new account, follow one concrete case and re-evaluate the active gap after each useful answer. For an existing account, first locate the disputed or changed material and its consequence for the objective. Use the `elicitation` skill's universal guidance and `references/profile.md` for detailed operations and coverage; do not turn their register order into question order. +#### Budget + +Apply this section only when an interview budget is supplied. Without one, follow the ordinary procedure unchanged. The panel supplies a level shown in minutes and a question cap for the current mode. Minutes are the person's guide, not a timer. Treat this as posture already stated; do not ask for it again. Record the level on the first turn under **Available time and assumption appetite**. The budget changes which absences you pursue and how many, never what counts as evidence. Every reply before closing consumes one question, including confirmations; a grouped question counts as one. + +- **Quick:** Pursue only essentials the net cannot be built without. Group related questions only when they share one frame. Use only authorized construction defaults, recording each as **Assumed**, with its reason and how to check it. Selecting Quick does not authorize inventing operational facts, ranges or units. Leave unsupported facts open. Do not propose an experiment. +- **Standard:** One thread per question, quantities with their units. Offer a supported default and ask; do not adopt an unconfirmed operational default just because the cap is reached. Propose an experiment only with the person's stated range and unit and the existing readiness checks satisfied. +- **Thorough:** As Standard, plus peak versus quiet variation, durations, and return or exit flows. Leave missing facts **Unknown**. Ask for the range the person would consider before proposing an experiment. +- **Deep:** As Thorough, plus units, ranges, edge cases and restrictions. Never assume missing facts. No cap: offer a pause between topics instead of closing because of the count. + +When **remaining is 1**, ask for the most consequential open fact. When **remaining is 0**, settle the latest answer and close without another question, including a correction question: list stated facts, **Assumed** facts and open items by name. Reaching the cap does not make the model complete or runnable. Gaps are listed, not filled. Mention that continuing at a higher level is available without opening a new question. + +When the level changes, update the recorded level in the next settlement and replan. Earlier questions still count against the new cap. Do not repeat a settled fact. + ### Maintain the workpiece Treat the workpiece as the recoverable operational account. Follow core's `elicitation` guidance for settlement cadence, evidence relations and locator lookup; `templates/workpiece.md` supplies the process-specific recording shape. diff --git a/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/test/interview-budget.test.ts b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/test/interview-budget.test.ts new file mode 100644 index 00000000000..5f56a9ed41f --- /dev/null +++ b/libs/@hashintel/brunch-agent/packages/plugin-sdcpn/test/interview-budget.test.ts @@ -0,0 +1,56 @@ +import * as v from "valibot"; +import { describe, expect, it } from "vitest"; + +import { sdcpnInitialDataSchema } from "../src/initial-data"; +import { + interviewBudgetInstruction, + interviewBudgetSchema, +} from "../src/interview-budget"; + +describe("interview budget", () => { + it("preserves the Off initialization exactly", () => { + const input = { + binding: { conversationId: "c", documentId: "d", incarnationId: "i" }, + }; + expect(v.parse(sdcpnInitialDataSchema, input)).toEqual(input); + expect(interviewBudgetInstruction(undefined)).toBeUndefined(); + }); + + it("retains a current budget and distinguishes the last question from closing", () => { + const budget = { + level: "quick", + questionCap: 3, + asked: 2, + remaining: 1, + } as const; + expect(v.parse(interviewBudgetSchema, budget)).toEqual(budget); + expect(interviewBudgetInstruction(budget)).toContain( + "most consequential open fact", + ); + expect( + interviewBudgetInstruction({ ...budget, asked: 4, remaining: 0 }), + ).toContain("do not ask another question"); + }); + + it("keeps Deep unlimited", () => { + expect( + interviewBudgetInstruction({ + level: "deep", + questionCap: null, + asked: 14, + remaining: null, + }), + ).toContain("pause between topics"); + }); + + it.each([ + { level: "off", questionCap: null, asked: 0, remaining: null }, + { level: "quick", questionCap: 3, asked: -1, remaining: 4 }, + { level: "quick", questionCap: 3, asked: 1.5, remaining: 1.5 }, + { level: "quick", questionCap: null, asked: 0, remaining: null }, + { level: "deep", questionCap: 3, asked: 0, remaining: 3 }, + { level: "standard", questionCap: 6, asked: 5, remaining: 3 }, + ])("rejects an invalid budget: %j", (budget) => { + expect(v.safeParse(interviewBudgetSchema, budget).success).toBe(false); + }); +}); diff --git a/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/contextual-user-message.ts b/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/contextual-user-message.ts index d2b489dcaa5..c3f6ed06e08 100644 --- a/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/contextual-user-message.ts +++ b/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/contextual-user-message.ts @@ -2,12 +2,15 @@ import { CLIENT_TOOL_RESULT_CONTEXT_MAX_LENGTH } from "./browser-tool-result"; export const PETRINAUT_CONTEXTUAL_USER_MESSAGE_PREFIX = "petrinaut-contextual-user-message:v1\n"; +const budgetContextPrefix = "petrinaut-contextual-user-message:v2\n"; export const PETRINAUT_CONTEXTUAL_USER_TEXT_MAX_LENGTH = 32_000; const PETRINAUT_CONTEXTUAL_USER_BODY_MAX_LENGTH = 256_000; export interface PetrinautContextualUserMessagePayload { readonly userText: string; readonly diagnosticsContext: string; + /** Host-owned per-submission data, validated by the domain plugin. */ + readonly interviewBudget?: unknown; } export type PetrinautUserMessageBody = @@ -42,7 +45,8 @@ export const petrinautContextualUserMessageBody = ( payload.userText.length === 0 || Array.from(payload.userText).length > PETRINAUT_CONTEXTUAL_USER_TEXT_MAX_LENGTH || - payload.diagnosticsContext.length === 0 || + (payload.diagnosticsContext.length === 0 && + payload.interviewBudget === undefined) || Array.from(payload.diagnosticsContext).length > CLIENT_TOOL_RESULT_CONTEXT_MAX_LENGTH ) { @@ -50,7 +54,11 @@ export const petrinautContextualUserMessageBody = ( "The contextual user message payload is invalid or too long.", ); } - const body = `${PETRINAUT_CONTEXTUAL_USER_MESSAGE_PREFIX}${JSON.stringify(payload)}`; + const prefix = + payload.interviewBudget === undefined + ? PETRINAUT_CONTEXTUAL_USER_MESSAGE_PREFIX + : budgetContextPrefix; + const body = `${prefix}${JSON.stringify(payload)}`; if (Array.from(body).length > PETRINAUT_CONTEXTUAL_USER_BODY_MAX_LENGTH) { throw new Error("The contextual user message body is too long."); } @@ -61,7 +69,10 @@ export const petrinautContextualUserMessageBody = ( export const parsePetrinautUserMessageBody = ( body: string, ): PetrinautUserMessageBody => { - if (!body.startsWith(PETRINAUT_CONTEXTUAL_USER_MESSAGE_PREFIX)) { + const prefix = body.startsWith(budgetContextPrefix) + ? budgetContextPrefix + : PETRINAUT_CONTEXTUAL_USER_MESSAGE_PREFIX; + if (!body.startsWith(prefix)) { return { kind: "ordinary", userText: body }; } if (Array.from(body).length > PETRINAUT_CONTEXTUAL_USER_BODY_MAX_LENGTH) { @@ -69,16 +80,19 @@ export const parsePetrinautUserMessageBody = ( } let parsed: unknown; try { - parsed = JSON.parse( - body.slice(PETRINAUT_CONTEXTUAL_USER_MESSAGE_PREFIX.length), - ); + parsed = JSON.parse(body.slice(prefix.length)); } catch { return { kind: "invalid-contextual" }; } const payload = asRecord(parsed); if ( payload === null || - !hasExactKeys(payload, ["diagnosticsContext", "userText"]) || + !hasExactKeys( + payload, + prefix === budgetContextPrefix + ? ["diagnosticsContext", "interviewBudget", "userText"] + : ["diagnosticsContext", "userText"], + ) || typeof payload.userText !== "string" || typeof payload.diagnosticsContext !== "string" ) { @@ -88,6 +102,9 @@ export const parsePetrinautUserMessageBody = ( petrinautContextualUserMessageBody({ userText: payload.userText, diagnosticsContext: payload.diagnosticsContext, + ...(prefix === budgetContextPrefix + ? { interviewBudget: payload.interviewBudget } + : {}), }); } catch { return { kind: "invalid-contextual" }; @@ -96,5 +113,8 @@ export const parsePetrinautUserMessageBody = ( kind: "contextual", userText: payload.userText, diagnosticsContext: payload.diagnosticsContext, + ...(prefix === budgetContextPrefix + ? { interviewBudget: payload.interviewBudget } + : {}), }; }; diff --git a/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/index.ts b/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/index.ts index baba0dddd02..377abb95336 100644 --- a/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/index.ts +++ b/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/index.ts @@ -61,6 +61,8 @@ export interface FlueChatTransportOptions extends ClientToolProjectionOptions { readonly client: FlueClient; /** Opaque host-owned initialization, sent on user submissions only. */ readonly initialData?: AgentPromptOptions["initialData"]; + /** Current host budget, carried durably because initialData is creation-only. */ + readonly interviewBudget?: unknown; /** Best-effort pre-admission presentation; canonical Flue history remains authoritative. */ readonly liveToolStream?: LiveToolStreamOptions; readonly onAdmission?: (event: { @@ -384,11 +386,15 @@ export const createFlueChatTransport = < const message: DeliveredMessage = { kind: "user", body: - diagnosticsContext === undefined + diagnosticsContext === undefined && + options.interviewBudget === undefined ? userMessage.text : petrinautContextualUserMessageBody({ userText: userMessage.text, - diagnosticsContext, + diagnosticsContext: diagnosticsContext ?? "", + ...(options.interviewBudget === undefined + ? {} + : { interviewBudget: options.interviewBudget }), }), }; const idempotencyKey = `ai-sdk:user:${userMessage.id}`; diff --git a/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/transcript.ts b/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/transcript.ts index 1eb8f75219e..d8f8dea0e4b 100644 --- a/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/transcript.ts +++ b/libs/@hashintel/brunch-agent/packages/transport-aisdk/src/transcript.ts @@ -1,3 +1,5 @@ +import { parsePetrinautUserMessageBody } from "./contextual-user-message"; + import type { ClientToolProjectionOptions } from "./ui-stream"; import type { FlueConversationMessage, @@ -92,7 +94,15 @@ const partsFrom = ( const parts: UiMessagePart[] = []; for (const part of message.parts) { if (part.type === "text") { - parts.push({ type: "text", text: part.text, state: "done" }); + const body = + message.role === "user" + ? parsePetrinautUserMessageBody(part.text) + : undefined; + parts.push({ + type: "text", + text: body?.kind === "contextual" ? body.userText : part.text, + state: "done", + }); continue; } if (part.type === "reasoning") { diff --git a/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/interview-budget.test.ts b/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/interview-budget.test.ts new file mode 100644 index 00000000000..b15c259ea8e --- /dev/null +++ b/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/interview-budget.test.ts @@ -0,0 +1,43 @@ +import { expect, it } from "vitest"; + +import { + parsePetrinautUserMessageBody, + petrinautContextualUserMessageBody, +} from "../src/contextual-user-message"; + +it("keeps budget context separate from human evidence across submissions", () => { + for (const remaining of [3, 1, 0]) { + const interviewBudget = { + level: "quick", + questionCap: 3, + asked: 3 - remaining, + remaining, + }; + const body = petrinautContextualUserMessageBody({ + userText: "Four agents", + diagnosticsContext: "", + interviewBudget, + }); + expect(parsePetrinautUserMessageBody(body)).toEqual({ + kind: "contextual", + userText: "Four agents", + diagnosticsContext: "", + interviewBudget, + }); + } +}); + +it("does not change ordinary or diagnostic-only Off bodies", () => { + expect(parsePetrinautUserMessageBody("Four agents")).toEqual({ + kind: "ordinary", + userText: "Four agents", + }); + expect( + petrinautContextualUserMessageBody({ + userText: "Four agents", + diagnosticsContext: "diagnostic", + }), + ).toBe( + 'petrinaut-contextual-user-message:v1\n{"userText":"Four agents","diagnosticsContext":"diagnostic"}', + ); +}); diff --git a/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/transcript.test.ts b/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/transcript.test.ts index f30ae9ec08e..8bbfd0f9f59 100644 --- a/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/transcript.test.ts +++ b/libs/@hashintel/brunch-agent/packages/transport-aisdk/test/transcript.test.ts @@ -1,6 +1,9 @@ import { expect, test } from "vitest"; -import { snapshotToUiMessages } from "../src"; +import { + petrinautContextualUserMessageBody, + snapshotToUiMessages, +} from "../src"; import type { FlueConversationSnapshot } from "@flue/sdk"; @@ -33,6 +36,50 @@ const projectionOptions = { clientToolNames: new Set(["readPetrinautDoc"]), }; +test("rehydrates budget messages as human text, never as transport metadata", () => { + const body = petrinautContextualUserMessageBody({ + userText: "Four agents", + diagnosticsContext: "", + interviewBudget: { level: "quick", questionCap: 3, asked: 1, remaining: 2 }, + }); + const snapshot: FlueConversationSnapshot = { + ...snapshotWithPendingClientTool, + messages: [ + { + id: "user", + role: "user", + purpose: "user", + display: "visible", + parts: [{ type: "text", text: body, state: "done" }], + }, + { + id: "assistant", + role: "assistant", + purpose: "assistant", + display: "visible", + parts: [{ type: "text", text: body, state: "done" }], + }, + ], + }; + expect(snapshotToUiMessages(snapshot, projectionOptions)).toEqual([ + { + id: "user", + role: "user", + parts: [{ type: "text", text: "Four agents", state: "done" }], + }, + { + id: "assistant", + role: "assistant", + parts: [{ type: "text", text: body, state: "done" }], + }, + ]); + expect(snapshot.messages[0]?.parts[0]).toEqual({ + type: "text", + text: body, + state: "done", + }); +}); + test("marks only the durably aborted assistant response stopped after reopen", () => { const snapshot: FlueConversationSnapshot = { ...snapshotWithPendingClientTool, From 6c288e7fe61075ec5d1a3757282e6339de2083a7 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 10:18:24 +0200 Subject: [PATCH 02/41] Add interview budget controls to Chat and Voice Count canonical replies against per-mode allowances, show question-derived estimates, and carry level changes into Live sessions without interrupting speech. Keep budget notes visible in both modes and remove retired sweep formatting. Co-authored-by: Amp --- .changeset/interview-budget-controls.md | 5 + .../brunch-panel-transport.test.ts | 84 +++++ .../brunch-panel-transport.ts | 152 ++------- .../interview-budget-control.test.tsx | 71 ++++ .../interview-budget-control.tsx | 308 ++++++++++++++++++ .../local-storage-demo-app.tsx | 84 ++++- .../local-storage-demo/voice-preference.ts | 21 ++ .../live-conversation-control.test.tsx | 1 + .../live-conversation-control.tsx | 15 +- .../voice-interview/live-conversation.test.ts | 33 +- .../app/voice-interview/live-conversation.ts | 46 ++- .../voice-interview-control.tsx | 4 + .../server/voice/openai-live-session.test.ts | 34 ++ .../src/server/voice/openai-live-session.ts | 14 +- .../src/shared/interview-budget.test.ts | 72 ++++ .../src/shared/interview-budget.ts | 121 +++++++ .../@hashintel/petrinaut/docs/ai-assistant.md | 10 + .../@hashintel/petrinaut/src/ui/petrinaut.tsx | 2 + .../ui/types/ai-assistant-composer-control.ts | 2 + .../Editor/panels/ai-assistant-panel.tsx | 4 + .../ai-assistant-contents.test.tsx | 34 ++ .../ai-assistant-contents.tsx | 21 ++ .../ai-assistant-contents/voice-dock.tsx | 6 + 23 files changed, 1007 insertions(+), 137 deletions(-) create mode 100644 .changeset/interview-budget-controls.md create mode 100644 apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx create mode 100644 apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx create mode 100644 apps/petrinaut-website/src/shared/interview-budget.test.ts create mode 100644 apps/petrinaut-website/src/shared/interview-budget.ts diff --git a/.changeset/interview-budget-controls.md b/.changeset/interview-budget-controls.md new file mode 100644 index 00000000000..f19874cb7f4 --- /dev/null +++ b/.changeset/interview-budget-controls.md @@ -0,0 +1,5 @@ +--- +"@hashintel/petrinaut": patch +--- + +Support host-owned status above the assistant composer and Voice dock, keep composer controls available during live Voice sessions, and supply the current input mode to host controls. Display system messages as visible notes in Chat and Voice. diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.test.ts b/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.test.ts index 8ac3059593f..53733fec3ee 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.test.ts +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.test.ts @@ -1,6 +1,9 @@ import { FlueApiError } from "@flue/sdk"; import { expect, test, vi } from "vitest"; +import { parsePetrinautUserMessageBody } from "@hashintel/brunch-agent-transport-aisdk"; + +import { interviewBudgetLevels } from "../../../shared/interview-budget"; import { canonicalPetrinautClientToolNames } from "./brunch-client-tools"; import { BrunchPanelConversationTracker, @@ -10,6 +13,87 @@ import { import type { AgentSendResult, FlueClient } from "@flue/sdk"; +test.each(interviewBudgetLevels)( + "sends current %s budget on each submission, with Off identical to the legacy request", + async (level) => { + const send = vi.fn(async () => { + throw new FlueApiError(503, "test admission unavailable"); + }); + const initialData = { + binding: { + documentId: "document", + conversationId: "conversation", + incarnationId: "incarnation", + }, + }; + const transport = createBrunchPanelTransport( + Promise.resolve({ send } as unknown as FlueClient), + new BrunchPanelConversationTracker(), + { initialData, interviewBudgetLevel: level }, + ); + for (const source of ["text", "voice"] as const) { + for (const asked of [0, 2, 9]) { + await expect( + transport.sendMessages({ + trigger: "submit-message", + chatId: "conversation", + messageId: undefined, + abortSignal: undefined, + messages: [ + ...Array.from({ length: asked }, (_, index) => ({ + id: `reply-${index}`, + role: "assistant" as const, + parts: [{ type: "text" as const, text: "Recorded." }], + })), + { + id: "answer", + role: "user", + ...(source === "voice" ? { metadata: { source } } : {}), + parts: [{ type: "text", text: "Four agents" }], + }, + ], + }), + ).rejects.toThrow(); + const request = send.mock.lastCall?.[0]; + if (level === "off") { + expect(JSON.stringify(request)).toBe( + JSON.stringify({ + idempotencyKey: "ai-sdk:user:answer", + message: { kind: "user", body: "Four agents" }, + initialData, + }), + ); + } else { + const caps = + source === "text" + ? { quick: 3, standard: 6, thorough: 10, deep: null } + : { quick: 2, standard: 4, thorough: 7, deep: null }; + const questionCap = caps[level]; + const budget = { + level, + questionCap, + asked, + remaining: + questionCap === null ? null : Math.max(0, questionCap - asked), + }; + expect(request?.initialData).toEqual({ + ...initialData, + interviewBudget: budget, + }); + expect( + parsePetrinautUserMessageBody(request?.message.body ?? ""), + ).toEqual({ + kind: "contextual", + userText: "Four agents", + diagnosticsContext: "", + interviewBudget: budget, + }); + } + } + } + }, +); + test("publishes Stop immediately and supports unsubscribe", () => { const tracker = new BrunchPanelConversationTracker(); const listener = vi.fn(); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.ts b/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.ts index 3a4a3f7c526..833a2a6fa86 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.ts +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/brunch-panel-transport.ts @@ -2,28 +2,26 @@ import { createFlueChatTransport, FlueChatAdmissionError, } from "@hashintel/brunch-agent-transport-aisdk"; -import { SWEEP_TOOL_NAME } from "@hashintel/brunch-agent/client-tools"; -import { sweepOutputSchema } from "../brunch-sweep-output"; +import { + countInterviewReplies, + getInterviewBudget, + type InterviewBudgetLevel, +} from "../../../shared/interview-budget"; import { canonicalPetrinautClientToolNames } from "./brunch-client-tools"; -import type { - SweepCapture, - SweepCompletionFailure, - SweepCompletionReport, -} from "../brunch-sweep-output"; import type { AgentSendResult, FlueClient, FlueConversationState, } from "@flue/sdk"; +import type { BrowserContext } from "@hashintel/brunch-agent-plugin-sdcpn"; import type { FlueChatResponseMessageCompletedEvent, FlueChatResponseMessageStartedEvent, FlueChatTransportOptions, } from "@hashintel/brunch-agent-transport-aisdk"; import type { PetrinautAiChatTransport } from "@hashintel/petrinaut/ui"; -import type { UIMessageChunk } from "ai"; export type BrunchPanelAdmission = Parameters< NonNullable @@ -206,128 +204,13 @@ export class BrunchPanelConversationTracker { } } -const formatFailure = (failure: SweepCompletionFailure): string => { - const location = - failure.nodeId === undefined - ? "" - : ` at ${failure.nodeId}${failure.slot === undefined ? "" : `.${failure.slot}`}`; - const captures = - failure.captureIds.length === 0 - ? "" - : ` Captures: ${failure.captureIds.join(", ")}`; - return `Completion gap [${failure.diagnostic}]${location}: needs ${failure.requirement}; actual ${failure.actual}. ${failure.message}${captures}`; -}; - -const formatCapture = (capture: SweepCapture): string => { - const content = - "value" in capture.content - ? JSON.stringify(capture.content.value) - : `absence: ${capture.content.absence}`; - const provenance = - capture.evidence !== undefined - ? capture.evidence.map((evidence) => `“${evidence.excerpt}”`).join("; ") - : capture.basis === undefined - ? "no provenance" - : `${capture.basis.type}: ${capture.basis.description}`; - const history = [ - capture.alternativeGroup === undefined - ? undefined - : `alternative group ${capture.alternativeGroup}`, - capture.supersedes === undefined - ? undefined - : `supersedes ${capture.supersedes}`, - ].filter((fact) => fact !== undefined); - return `Capture ${capture.id} (${capture.status}; ${capture.epistemicStatus}; confidence ${capture.confidence}): ${content} — ${provenance}${history.length === 0 ? "" : `; ${history.join("; ")}`}`; -}; - -const formatCompletion = (report: SweepCompletionReport): string[] => [ - `Completion: ${report.complete ? "complete" : "incomplete"} · plugin ${report.pluginVersion} · revision ${report.revision}`, - `Completion slice: ${report.sliceNodeIds.join(", ") || "none"}`, - ...report.failures.map(formatFailure), - ...report.outsideSlice.flatMap((node) => [ - `Outside completion slice: ${node.nodeId} (${node.kind}); ${node.open.length} open requirement${node.open.length === 1 ? "" : "s"}`, - ...node.open.map((failure) => `Outside-slice ${formatFailure(failure)}`), - ]), -]; - -const summarizeSweepOutput = ( - output: unknown, -): - | { - readonly title: string; - readonly detail: string; - readonly items?: readonly string[]; - } - | undefined => { - const parsed = sweepOutputSchema.safeParse(output); - if (!parsed.success) return undefined; - - const sweep = parsed.data; - switch (sweep.status) { - case "no-settled-range": - return { - title: "No settled range to sweep", - detail: "The conversation has no settled user entries.", - }; - case "refused": - return { - title: "Sweep refused", - detail: sweep.refusal.message, - items: [`Refusal: ${sweep.refusal.code}`], - }; - case "applied": - return { - title: "Sweep applied", - detail: `${sweep.appliedCaptureIds.length} new capture${sweep.appliedCaptureIds.length === 1 ? "" : "s"} · ${sweep.captures.length} total · ${sweep.completion?.complete === true ? "complete" : "incomplete"}`, - items: [ - ...sweep.captures.map(formatCapture), - ...(sweep.completion === undefined - ? [] - : formatCompletion(sweep.completion)), - ], - }; - } -}; - -const decorateBrunchStream = ( - stream: ReadableStream, -): ReadableStream => { - const toolNamesByCallId = new Map(); - return stream.pipeThrough( - new TransformStream({ - transform(chunk, controller) { - if (chunk.type === "tool-input-available") { - toolNamesByCallId.set(chunk.toolCallId, chunk.toolName); - } - if ( - chunk.type === "tool-output-available" && - toolNamesByCallId.get(chunk.toolCallId) === SWEEP_TOOL_NAME - ) { - const summary = summarizeSweepOutput(chunk.output); - if ( - summary !== undefined && - typeof chunk.output === "object" && - chunk.output !== null - ) { - controller.enqueue({ - ...chunk, - output: { ...chunk.output, ...summary }, - }); - return; - } - } - controller.enqueue(chunk); - }, - }), - ); -}; - /** Adapt one mounted Flue conversation to Petrinaut's AI SDK rendering contract. */ export const createBrunchPanelTransport = ( clientPromise: Promise, tracker: BrunchPanelConversationTracker, options?: { - readonly initialData?: FlueChatTransportOptions["initialData"]; + readonly initialData?: BrowserContext; + readonly interviewBudgetLevel?: InterviewBudgetLevel; /** Browser tools executed by Petrinaut's static panel registry. */ readonly clientToolNames?: ReadonlySet; readonly dynamicClientToolNames?: FlueChatTransportOptions["dynamicClientToolNames"]; @@ -342,11 +225,24 @@ export const createBrunchPanelTransport = ( tracker.trackSubmission( (async () => { const client = await clientPromise; + const budget = getInterviewBudget( + options?.interviewBudgetLevel ?? "off", + sendOptions.messages.at(-1)?.metadata?.source === "voice" + ? "voice" + : "text", + countInterviewReplies(sendOptions.messages), + ); const transport = createFlueChatTransport({ client, ...(options?.initialData === undefined ? {} - : { initialData: options.initialData }), + : { + initialData: + budget === undefined + ? options.initialData + : { ...options.initialData, interviewBudget: budget }, + }), + ...(budget === undefined ? {} : { interviewBudget: budget }), clientToolNames: options?.clientToolNames ?? canonicalPetrinautClientToolNames, dynamicClientToolNames: options?.dynamicClientToolNames, @@ -362,9 +258,7 @@ export const createBrunchPanelTransport = ( onToolOutputError: options?.onToolOutputError, }); try { - return decorateBrunchStream( - await transport.sendMessages(sendOptions), - ); + return await transport.sendMessages(sendOptions); } catch (error) { const messageId = sendOptions.messageId ?? sendOptions.messages.at(-1)?.id; diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx new file mode 100644 index 00000000000..6785f3ffe7d --- /dev/null +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -0,0 +1,71 @@ +// @vitest-environment jsdom +import { cleanup, fireEvent, render, screen } from "@testing-library/react"; +import { useState } from "react"; +import { afterEach, expect, test, vi } from "vitest"; + +import { type InterviewBudgetLevel } from "../../../shared/interview-budget"; +import { + InterviewBudgetControl, + InterviewBudgetPill, +} from "./interview-budget-control"; + +import type { PetrinautAiComposerControlContext } from "@hashintel/petrinaut/ui"; + +afterEach(cleanup); + +const Harness = () => { + const [level, setLevel] = useState("standard"); + return ; +}; + +test("opens a five-stop control with hover descriptions and keyboard-accessible level selection", async () => { + render(); + fireEvent.click( + screen.getByRole("button", { + name: "Interview budget: Standard · ~10 min", + }), + ); + const slider = await screen.findByRole("slider", { + name: "Interview budget level", + }); + expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); + fireEvent.mouseEnter(screen.getByRole("button", { name: "Deep" })); + expect( + screen.getByText("Explore edge cases; pause between topics."), + ).toBeTruthy(); + fireEvent.change(slider, { target: { value: "1" } }); + expect(slider.getAttribute("aria-valuetext")).toBe("Quick · ~5 min"); + fireEvent.click(screen.getByRole("button", { name: "Off" })); + expect( + screen.getByRole("button", { name: "Interview budget: Off · No budget" }), + ).toBeTruthy(); +}); + +test("pill counts canonical replies, changes with mode and disappears for Off", () => { + const context: PetrinautAiComposerControlContext = { + conversationId: "conversation", + status: "ready" as const, + messages: Array.from({ length: 5 }, (_, index) => ({ + id: `reply-${index}`, + role: "assistant" as const, + parts: [{ type: "text" as const, text: "Recorded." }], + })), + stop: vi.fn(), + submitText: vi.fn(), + }; + const { rerender } = render( + , + ); + expect(screen.getByRole("status").textContent).toBe("Last question · ~2 min"); + rerender( + , + ); + expect(screen.getByRole("status").textContent).toBe("Wrapping up"); + rerender(); + expect(screen.getByRole("status").textContent).toBe("Question 5 · no limit"); + rerender(); + expect(screen.queryByRole("status")).toBeNull(); +}); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx new file mode 100644 index 00000000000..a58fb1296b9 --- /dev/null +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -0,0 +1,308 @@ +import { useRef, useState } from "react"; +import { + PiGauge, + PiLightning, + PiMagnifyingGlass, + PiPower, + PiStack, +} from "react-icons/pi"; + +import { Button, Popover } from "@hashintel/ds-components"; +import { css } from "@hashintel/ds-helpers/css"; + +import { + countInterviewReplies, + getInterviewBudget, + interviewBudgetLabel, + interviewBudgetLevels, + interviewBudgetLevelsConfig, + type InterviewBudgetLevel, +} from "../../../shared/interview-budget"; + +import type { PetrinautAiComposerControlContext } from "@hashintel/petrinaut/ui"; + +const icons = { + off: PiPower, + quick: PiLightning, + standard: PiGauge, + thorough: PiMagnifyingGlass, + deep: PiStack, +}; +// Host colors override the library's separately compiled Button utility layer. +const levelStyle = { + off: css({ + color: "neutral.fg.body !important", + backgroundColor: "neutral.bgSolid.surface !important", + borderColor: "neutral.bd.subtle !important", + }), + quick: css({ + color: "yellow.fg.body !important", + backgroundColor: "yellow.bgSolid.subtle !important", + borderColor: "yellow.bd.subtle !important", + }), + standard: css({ + color: "blue.fg.body !important", + backgroundColor: "blue.bgSolid.subtle !important", + borderColor: "blue.bd.subtle !important", + }), + thorough: css({ + color: "green.fg.body !important", + backgroundColor: "green.bgSolid.subtle !important", + borderColor: "green.bd.subtle !important", + }), + deep: css({ + color: "purple.fg.body !important", + backgroundColor: "purple.bgSolid.subtle !important", + borderColor: "purple.bd.subtle !important", + }), +}; + +export const InterviewBudgetControl = ({ + level, + onChange, +}: { + level: InterviewBudgetLevel; + onChange: (level: InterviewBudgetLevel) => void; +}) => { + const [open, setOpen] = useState(false); + const [hovered, setHovered] = useState(null); + const triggerRef = useRef(null); + const config = interviewBudgetLevelsConfig[level]; + const CurrentIcon = icons[level]; + const selectedIndex = interviewBudgetLevels.indexOf(level); + const preview = interviewBudgetLevelsConfig[hovered ?? level]; + + return ( + <> + + ))} + + +

+ {preview.description} +

+ + + + + )} + + ); +}; + +export const InterviewBudgetPill = ({ + level, + context, +}: { + level: InterviewBudgetLevel; + context: PetrinautAiComposerControlContext; +}) => { + const asked = countInterviewReplies(context.messages); + const mode = context.inputMode ?? "text"; + const label = interviewBudgetLabel(level, mode, asked); + const budget = getInterviewBudget(level, mode, asked); + if (!budget || label === null) return null; + const config = interviewBudgetLevelsConfig[level]; + const detail = `${config.name} · ${config.guide}. ${asked} replies counted; ${budget.questionCap ?? "no"} question cap in ${mode}; ${budget.remaining ?? "unlimited"} left. ${budget.questionCap === null ? "Pause between topics." : "At the cap, wrap up with facts, assumptions and open items; gaps stay open."} This is an estimate, not a countdown.`; + return ( +
+ + {label} + +
+ ); +}; diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx index 2f13d2c03c5..16f87a5cb7e 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx @@ -52,6 +52,10 @@ import { useSharedSearchNavigation, withClearedSharedLocation, } from "../../../examples/use-shared-search-navigation"; +import { + interviewBudgetLevelsConfig, + type InterviewBudgetLevel, +} from "../../../shared/interview-budget"; import { VOICE_REQUEST_ID_HEADER } from "../../../voice-diagnostics"; import { CommandPalette } from "../command-palette"; import { useSentryFeedbackAction } from "../sentry-feedback-button"; @@ -108,11 +112,19 @@ import { foldBrunchWorkpieceHistory } from "./brunch-workpiece-history"; import { BrunchWorkpiecePane } from "./brunch-workpiece-pane"; import { useDocumentController } from "./documents/use-document-controller"; import { createInBandBrowserCalls } from "./in-band-browser-call"; +import { + InterviewBudgetControl, + InterviewBudgetPill, +} from "./interview-budget-control"; import { useFlueChatHistory } from "./use-flue-chat-history"; import { useLocalStorageAiMessages } from "./use-local-storage-ai-messages"; import { emptySDCPN } from "./use-local-storage-sdcpns"; import { useVoiceMediationHistory } from "./use-voice-mediation-history"; -import { useRealtimePreference, useVoicePreference } from "./voice-preference"; +import { + useInterviewBudgetPreference, + useRealtimePreference, + useVoicePreference, +} from "./voice-preference"; import { walkthroughSteps } from "./walkthrough/walkthrough-steps"; import type { SharedExampleSearch } from "../../../examples/example-search"; @@ -234,6 +246,7 @@ export const getBrunchVoiceMode = ( settlements?: readonly FlueConversationSettlement[], snapshot?: FlueConversationState, mediationHistory?: VoiceMediationHistory, + interviewBudgetLevel?: InterviewBudgetLevel, ): PetrinautAiVoiceMode | undefined => { if (!config) return undefined; @@ -260,6 +273,7 @@ export const getBrunchVoiceMode = ( ([]); const { enabled: realtimeEnabled, ready: realtimePreferenceReady, @@ -822,6 +841,7 @@ export const LocalStorageDemoApp = ({ flueHistory.settlements, flueHistory.snapshot, mediationHistory, + interviewBudgetLevel, ), [ brunchSelected, @@ -829,6 +849,7 @@ export const LocalStorageDemoApp = ({ flueHistory.settlements, flueHistory.snapshot, mediationHistory, + interviewBudgetLevel, openAIVoiceConfig, realtimeEnabled, realtimePreferenceReady, @@ -843,6 +864,7 @@ export const LocalStorageDemoApp = ({ transportClientPromise, conversationTracker, { + interviewBudgetLevel, ...(constructionBrowser ? { initialData: { binding: constructionBrowser.binding } } : {}), @@ -890,6 +912,7 @@ export const LocalStorageDemoApp = ({ flueHistory.refresh, reportBrunchFailure, transportClientPromise, + interviewBudgetLevel, ]); const inBandBrowserTools = useMemo( @@ -967,12 +990,64 @@ export const LocalStorageDemoApp = ({ ? { primaryLabel: "Chat", presentation: "brunch" as const, - mapMessagesForDisplay: mapVoiceMessages, + mapMessagesForDisplay: (messages: PetrinautAiMessage[]) => { + const withNotes = messages.flatMap((message) => [ + message, + ...budgetNotes + .filter( + (note) => + note.conversationId === conversationId && + note.after === message.id, + ) + .map((note) => note.message), + ]); + return mapVoiceMessages?.(withNotes) ?? withNotes; + }, resolveToolPresentation: resolveBrunchToolPresentation, workingLabel: "Brunch is working", renderComposerControl: ( context: PetrinautAiComposerControlContext, - ) => , + ) => ( + <> + + { + if (level === interviewBudgetLevel) return; + const after = context.messages.at(-1)?.id; + if (after) { + const config = interviewBudgetLevelsConfig[level]; + setBudgetNotes((notes) => [ + ...notes, + { + conversationId: context.conversationId, + after, + message: { + id: `interview-budget:${crypto.randomUUID()}`, + role: "system", + parts: [ + { + type: "text", + text: `Interview budget changed to ${config.name} · ${config.guide}. Earlier questions still count.`, + }, + ], + }, + }, + ]); + } + setInterviewBudgetLevel(level); + }} + /> + + ), + renderComposerStatus: ( + context: PetrinautAiComposerControlContext, + ) => ( + + ), } : {}), ...(conversationId === null ? {} : { conversationId }), @@ -1045,6 +1120,9 @@ export const LocalStorageDemoApp = ({ }; }, [ aiMessagesByNetId, + budgetNotes, + interviewBudgetLevel, + setInterviewBudgetLevel, mapVoiceMessages, brunchSelected, brunchVoiceMode, diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts b/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts index 22d6809cf29..2950bfd1c05 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts @@ -1,3 +1,7 @@ +import { + isInterviewBudgetLevel, + type InterviewBudgetLevel, +} from "../../../shared/interview-budget"; import { readBrowserStorage, writeBrowserStorage } from "./browser-storage"; import { usePersistedState } from "./use-persisted-state"; @@ -18,6 +22,23 @@ export const useVoicePreference = () => { return { enabled, ready, setEnabled }; }; +const interviewBudgetStorageKey = "petrinaut-website:interview-budget"; +const readInterviewBudget = (): InterviewBudgetLevel => { + const value = readBrowserStorage(localStorage, interviewBudgetStorageKey); + return isInterviewBudgetLevel(value) ? value : "standard"; +}; +const writeInterviewBudget = (level: InterviewBudgetLevel): void => + writeBrowserStorage(localStorage, interviewBudgetStorageKey, level); + +export const useInterviewBudgetPreference = () => { + const [level, setLevel] = usePersistedState({ + fallback: "standard", + read: readInterviewBudget, + write: writeInterviewBudget, + }); + return { level, setLevel }; +}; + const realtimePreferenceStorageKey = "petrinaut-website:realtime-enabled"; const readRealtimePreference = (): boolean => diff --git a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.test.tsx b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.test.tsx index 86a52270401..6a51c56db94 100644 --- a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.test.tsx @@ -41,6 +41,7 @@ vi.mock("./live-conversation", () => ({ appendInstructions: vi.fn(() => true), appendThinking: vi.fn(() => true), speechPending: vi.fn(() => true), + setInterviewBudgetLevel: vi.fn(), setMicrophoneMuted: liveConversationMocks.setMicrophoneMuted, setSpeakerMuted: liveConversationMocks.setSpeakerMuted, setSpeakerVolume: liveConversationMocks.setSpeakerVolume, diff --git a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.tsx b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.tsx index 5e97070e152..63aea058f4c 100644 --- a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.tsx +++ b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation-control.tsx @@ -23,6 +23,7 @@ import { } from "./voice-interview-disclosure"; import { VoiceMediationHistory } from "./voice-mediation-history"; +import type { InterviewBudgetLevel } from "../../../shared/interview-budget"; import type { VoiceInterviewControl } from "./voice-interview-control"; import type { PetrinautAiVoiceModeContext } from "@hashintel/petrinaut/ui"; @@ -39,6 +40,7 @@ type LiveControlsContext = PetrinautAiVoiceModeContext & | "subscribeToResponseMessageCompleted" | "subscribeToStopRequested" > & { + readonly interviewBudgetLevel?: InterviewBudgetLevel; readonly mediationHistory?: VoiceMediationHistory; readonly acknowledgeDisclosure: () => void; readonly submit: ConstructorParameters< @@ -64,6 +66,7 @@ const prepareVoice = async ( }; export const LiveConversationControl = ({ + interviewBudgetLevel = "off", mediationHistory, acknowledgeDisclosure, inputMode, @@ -330,6 +333,7 @@ export const LiveConversationControl = ({ }, closed: () => captions.close(), }, + interviewBudgetLevel, ); next.setMicrophoneMuted(false); next.setSpeakerMuted(false); @@ -363,7 +367,16 @@ export const LiveConversationControl = ({ setVoiceActive(true); void next.start(); return true; - }, [audioSettingsStore, connectionTimeoutMs, phase, setVoiceActive]); + }, [ + audioSettingsStore, + connectionTimeoutMs, + phase, + setVoiceActive, + interviewBudgetLevel, + ]); + useEffect(() => { + session.current?.setInterviewBudgetLevel(interviewBudgetLevel); + }, [interviewBudgetLevel, state.phase]); useLayoutEffect(() => { if (inputMode !== "voice" || !isAiAssistantOpen) { handledVoiceSelection.current = false; diff --git a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.test.ts b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.test.ts index 34f60e89d22..8bc6872ae32 100644 --- a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.test.ts +++ b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.test.ts @@ -200,7 +200,7 @@ const setup = ({ ); const getUserMedia = vi.fn(async () => stream); vi.stubGlobal("navigator", { mediaDevices: { getUserMedia } }); - const fetch = vi.fn(async (url: string) => + const fetch = vi.fn(async (url: string, _init?: RequestInit) => Response.json( url.endsWith("transcription-session") ? { sdp: "v=0\r\no=transcription-answer" } @@ -1518,6 +1518,37 @@ test("telemetry shows activity but silence and late samples never settle or revi expect(fixture.onState).toHaveBeenCalledTimes(calls); }); +test("sends the startup budget once and coalesces quiet session-wide changes", async () => { + const fixture = setup(); + fixture.conversation.setInterviewBudgetLevel("standard"); + await connect(fixture); + const startup = fixture.fetch.mock.calls.find( + ([url]) => url === "/api/voice/live-session", + ); + expect( + new Headers(startup?.[1]?.headers).get("x-petrinaut-interview-budget"), + ).toBe("standard"); + fixture.conversation.setInterviewBudgetLevel("standard"); + await Promise.resolve(); + expect(fixture.sent[0]).toHaveLength(0); + fixture.conversation.setInterviewBudgetLevel("quick"); + fixture.conversation.setInterviewBudgetLevel("deep"); + await Promise.resolve(); + expect(fixture.sent[0]).toHaveLength(1); + expect(JSON.parse(fixture.sent[0][0]!)).toMatchObject({ + type: "session.thinking.append", + delegation_id: null, + }); + expect(fixture.sent[0][0]).toContain("Deep (No limit)"); + fixture.conversation.setInterviewBudgetLevel("off"); + await Promise.resolve(); + expect(JSON.parse(fixture.sent[0][1]!)).toMatchObject({ + type: "session.thinking.append", + delegation_id: null, + }); + expect(fixture.sent[0][1]).toContain("now Off"); +}); + test("quiet interruption context requires its own acknowledgement and leaves the delegation open", async () => { const fixture = setup(); await connect(fixture); diff --git a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.ts b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.ts index d500bb50229..7b3dbc895fa 100644 --- a/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.ts +++ b/apps/petrinaut-website/src/main/app/voice-interview/live-conversation.ts @@ -1,3 +1,8 @@ +import { + interviewBudgetHeader, + liveInterviewBudgetInstruction, + type InterviewBudgetLevel, +} from "../../../shared/interview-budget"; import { voicePreferenceHeader } from "../../../shared/voice-settings"; import { createOutputEchoTrace, @@ -70,6 +75,7 @@ export const createLiveConversation = ( readonly output: (fragment: LiveTranscriptFragment) => void; readonly closed: () => void; }, + initialBudgetLevel: InterviewBudgetLevel = "off", ) => { const abort = new AbortController(); const sessionId = crypto.randomUUID(); @@ -111,6 +117,8 @@ export const createLiveConversation = ( let speakerMuted = false; let speakerVolume = 1; let voice = "marin"; + let budgetLevel = initialBudgetLevel; + let sentBudgetLevel = initialBudgetLevel; let detachAudioSettings: (() => void) | undefined; let started = false; let playbackBlocked = false; @@ -823,13 +831,23 @@ export const createLiveConversation = ( abort.signal.throwIfAborted(); const sdp = connection.localDescription?.sdp; if (!sdp) throw new Error("Missing local SDP"); - if (kind === "live") liveCreationRequested = true; + if (kind === "live") { + liveCreationRequested = true; + sentBudgetLevel = budgetLevel; + } connectionStages.set(kind, "waiting for session HTTP response"); const response = await fetch(`/api/voice/${kind}-session`, { method: "POST", headers: { "content-type": "application/sdp", - ...(kind === "live" ? { [voicePreferenceHeader]: voice } : {}), + ...(kind === "live" + ? { + [voicePreferenceHeader]: voice, + ...(budgetLevel === "off" + ? {} + : { [interviewBudgetHeader]: budgetLevel }), + } + : {}), }, body: sdp, signal: abort.signal, @@ -987,6 +1005,30 @@ export const createLiveConversation = ( retryPlayback: playAudio, start, stop, + setInterviewBudgetLevel: (level: InterviewBudgetLevel) => { + budgetLevel = level; + // Coalesce changes made in the same turn; this is quiet context, never + // an instruction redirect and never a reason to interrupt speech. + queueMicrotask(() => { + if ( + stopping || + finished || + budgetLevel === sentBudgetLevel || + ready.size !== 2 + ) + return; + if ( + append( + "thinking", + budgetLevel === "off" + ? "Interview budget is now Off. Follow Brunch's ordinary interview pacing; Brunch still decides the questions. Do not speak this note." + : liveInterviewBudgetInstruction(budgetLevel), + null, + ) + ) + sentBudgetLevel = budgetLevel; + }); + }, setMicrophoneMuted, setSpeakerMuted, setSpeakerVolume, diff --git a/apps/petrinaut-website/src/main/app/voice-interview/voice-interview-control.tsx b/apps/petrinaut-website/src/main/app/voice-interview/voice-interview-control.tsx index cbcf6c0e74b..d33fe5d0e02 100644 --- a/apps/petrinaut-website/src/main/app/voice-interview/voice-interview-control.tsx +++ b/apps/petrinaut-website/src/main/app/voice-interview/voice-interview-control.tsx @@ -30,6 +30,7 @@ import { type VoiceTurnSnapshot, } from "./voice-turn-controller"; +import type { InterviewBudgetLevel } from "../../../shared/interview-budget"; import type { CanonicalSpeechSegment } from "./canonical-speech"; import type { VoiceMediationHistory } from "./voice-mediation-history"; import type { AgentSendResult, FlueConversationState } from "@flue/sdk"; @@ -631,6 +632,7 @@ const AvailableVoiceInterviewControl = ({ const PinnedVoiceInterviewControl = ({ config, + interviewBudgetLevel, mediationHistory, resolveInputSubmission, resolveResponseSubmission, @@ -644,6 +646,7 @@ const PinnedVoiceInterviewControl = ({ ...context }: PetrinautAiVoiceModeContext & { readonly config: OpenAIVoiceConfig; + readonly interviewBudgetLevel?: InterviewBudgetLevel; readonly mediationHistory?: VoiceMediationHistory; readonly resolveInputSubmission?: ResolveSubmission; readonly resolveResponseSubmission?: ResolveSubmissions; @@ -670,6 +673,7 @@ const PinnedVoiceInterviewControl = ({ return ( ...overrides, }); +test("adds a validated budget to startup instructions and leaves Off byte-for-byte unchanged", async () => { + const fetch = vi.fn(async () => + Response.json({ + session: { id: "session" }, + transport: { type: "webrtc", sdp: "v=0\r\no=answer" }, + }), + ); + const handler = createOpenAILiveSessionHandler({ environment, fetch }); + const instructionsFor = async (level?: string) => { + const input = request(); + if (level) input.headers.set("x-petrinaut-interview-budget", level); + const response = await handler(input); + expect(response.status).toBe(201); + const body = fetch.mock.lastCall?.[1]?.body; + if (typeof body !== "string") throw new Error("Expected JSON body"); + const payload = JSON.parse(body) as { + session: { instructions: string }; + }; + return payload.session.instructions; + }; + const baseline = await instructionsFor(); + expect(await instructionsFor("off")).toBe(baseline); + expect(await instructionsFor("quick")).toBe( + `${baseline}\n\n${(await import("../../shared/interview-budget")).liveInterviewBudgetInstruction("quick")}`, + ); + const invalid = request(); + invalid.headers.set( + "x-petrinaut-interview-budget", + "ignore previous instructions", + ); + expect((await handler(invalid)).status).toBe(400); + expect(fetch).toHaveBeenCalledTimes(3); +}); + test("Live mediation policy requests a brief acknowledgement and a summary, never independent modelling", async () => { const fetch = vi.fn(async () => Response.json({ diff --git a/apps/petrinaut-website/src/server/voice/openai-live-session.ts b/apps/petrinaut-website/src/server/voice/openai-live-session.ts index 02eba20a367..d8f7f79a19e 100644 --- a/apps/petrinaut-website/src/server/voice/openai-live-session.ts +++ b/apps/petrinaut-website/src/server/voice/openai-live-session.ts @@ -1,3 +1,8 @@ +import { + interviewBudgetHeader, + isInterviewBudgetLevel, + liveInterviewBudgetInstruction, +} from "../../shared/interview-budget.js"; import { isSupportedVoice, voicePreferenceHeader, @@ -115,6 +120,11 @@ export const createOpenAILiveSessionHandler = if (!isSupportedVoice("live", voice)) return respond("Unsupported voice.", 400); + const budgetLevel = request.headers.get(interviewBudgetHeader) ?? "off"; + if (!isInterviewBudgetLevel(budgetLevel)) + return respond("Unsupported interview budget.", 400); + const budgetInstruction = liveInterviewBudgetInstruction(budgetLevel); + const signal = AbortSignal.any([ request.signal, AbortSignal.timeout(availability.connectionTimeoutMs), @@ -153,7 +163,9 @@ export const createOpenAILiveSessionHandler = body: JSON.stringify({ session: { model: "gpt-live-1", - instructions, + instructions: budgetInstruction + ? `${instructions}\n\n${budgetInstruction}` + : instructions, delegation: { type: "client" }, store: false, audio: { output: { voice } }, diff --git a/apps/petrinaut-website/src/shared/interview-budget.test.ts b/apps/petrinaut-website/src/shared/interview-budget.test.ts new file mode 100644 index 00000000000..e3d1ba8d25e --- /dev/null +++ b/apps/petrinaut-website/src/shared/interview-budget.test.ts @@ -0,0 +1,72 @@ +import { expect, it } from "vitest"; + +import { + countInterviewReplies, + getInterviewBudget, + interviewBudgetLabel, + liveInterviewBudgetInstruction, +} from "./interview-budget"; + +it("uses mode-specific caps and keeps already asked questions after a downgrade", () => { + expect(getInterviewBudget("quick", "text", 4)).toEqual({ + level: "quick", + questionCap: 3, + asked: 4, + remaining: 0, + }); + expect(getInterviewBudget("standard", "voice", 1)).toEqual({ + level: "standard", + questionCap: 4, + asked: 1, + remaining: 3, + }); + expect(getInterviewBudget("thorough", "voice", 2)?.questionCap).toBe(7); + expect(getInterviewBudget("thorough", "text", 2)?.questionCap).toBe(10); + expect(getInterviewBudget("quick", "voice", 0)?.questionCap).toBe(2); + expect(getInterviewBudget("deep", "voice", 12)).toEqual({ + level: "deep", + questionCap: null, + asked: 12, + remaining: null, + }); + expect(getInterviewBudget("off", "text", 12)).toBeUndefined(); +}); + +it("renders a question-derived estimate, never a clock", () => { + expect(interviewBudgetLabel("standard", "text", 2)).toBe("~7 min left"); + expect(interviewBudgetLabel("standard", "text", 5)).toBe( + "Last question · ~2 min", + ); + expect(interviewBudgetLabel("standard", "text", 6)).toBe("Wrapping up"); + expect(interviewBudgetLabel("standard", "voice", 3)).toBe( + "Last question · ~3 min", + ); + expect(interviewBudgetLabel("deep", "text", 4)).toBe("Question 4 · no limit"); + expect(interviewBudgetLabel("off", "voice", 2)).toBeNull(); +}); + +it("counts batched and confirmation replies once, excluding tool-only and streaming messages", () => { + expect( + countInterviewReplies([ + { role: "user", parts: [{ type: "text", text: "hello" }] }, + { + role: "assistant", + parts: [ + { type: "text", text: "Who? How many?" }, + { type: "text", text: "What unit?" }, + ], + }, + { role: "assistant", parts: [{ type: "text", text: "Recorded." }] }, + { + role: "assistant", + parts: [{ type: "text", text: "Not done", state: "streaming" }], + }, + { role: "assistant", parts: [{ type: "tool-x" }] }, + ]), + ).toBe(2); +}); + +it("adds no startup instruction for Off", () => { + expect(liveInterviewBudgetInstruction("off")).toBe(""); + expect(liveInterviewBudgetInstruction("quick")).toContain("Brunch decides"); +}); diff --git a/apps/petrinaut-website/src/shared/interview-budget.ts b/apps/petrinaut-website/src/shared/interview-budget.ts new file mode 100644 index 00000000000..aebcd0dcd68 --- /dev/null +++ b/apps/petrinaut-website/src/shared/interview-budget.ts @@ -0,0 +1,121 @@ +export const interviewBudgetLevels = [ + "off", + "quick", + "standard", + "thorough", + "deep", +] as const; +export type InterviewBudgetLevel = (typeof interviewBudgetLevels)[number]; +export const interviewBudgetHeader = "x-petrinaut-interview-budget"; +export const interviewBudgetLevelsConfig = { + off: { + name: "Off", + guide: "No budget", + minutes: 0, + text: null, + voice: null, + description: "Interview without a budget.", + }, + quick: { + name: "Quick", + guide: "~5 min", + minutes: 5, + text: 3, + voice: 2, + description: "Focus on the essentials.", + }, + standard: { + name: "Standard", + guide: "~10 min", + minutes: 10, + text: 6, + voice: 4, + description: "Explore one topic at a time.", + }, + thorough: { + name: "Thorough", + guide: "~20 min", + minutes: 20, + text: 10, + voice: 7, + description: "Explore variation and return flows.", + }, + deep: { + name: "Deep", + guide: "No limit", + minutes: 0, + text: null, + voice: null, + description: "Explore edge cases; pause between topics.", + }, +} as const; + +export const isInterviewBudgetLevel = ( + value: unknown, +): value is InterviewBudgetLevel => + typeof value === "string" && + interviewBudgetLevels.some((level) => level === value); + +export const getInterviewBudget = ( + level: InterviewBudgetLevel, + mode: "text" | "voice", + asked: number, +) => { + if (level === "off") return undefined; + const questionCap = interviewBudgetLevelsConfig[level][mode]; + return { + level, + questionCap, + asked, + remaining: questionCap === null ? null : Math.max(0, questionCap - asked), + }; +}; + +/** Completed canonical replies only, never Live captions or tool-only messages. */ +export const countInterviewReplies = ( + messages: readonly { + readonly role: string; + readonly parts: readonly { + readonly type: string; + readonly text?: string; + readonly state?: string; + }[]; + }[], +): number => + messages.filter( + (message) => + message.role === "assistant" && + message.parts.some( + (part) => + part.type === "text" && + part.text?.trim() && + part.state !== "streaming", + ), + ).length; + +export const interviewBudgetLabel = ( + level: InterviewBudgetLevel, + mode: "text" | "voice", + asked: number, +): string | null => { + const budget = getInterviewBudget(level, mode, asked); + if (!budget) return null; + if (budget.remaining === null || budget.questionCap === null) + return `Question ${asked} · no limit`; + if (budget.remaining === 0) return "Wrapping up"; + const minutes = Math.round( + (budget.remaining * interviewBudgetLevelsConfig[level].minutes) / + budget.questionCap, + ); + return budget.remaining === 1 + ? `Last question · ~${minutes} min` + : `~${minutes} min left`; +}; + +export const liveInterviewBudgetInstruction = ( + level: InterviewBudgetLevel, +): string => { + if (level === "off") return ""; + const config = interviewBudgetLevelsConfig[level]; + return `Interview budget: ${config.name} (${config.guide}). Minutes are a guide, not a timer. Brunch decides what questions to ask and how many; you decide how to say them. ${level === "quick" ? "Keep phrasing brief and give the person room to answer." : level === "deep" || level === "thorough" ? "Give the person room to elaborate and preserve Brunch's pauses between topics." : "Use concise, natural phrasing and give the person room to finish."} Relay Brunch's closing turn faithfully; never add a question or invent missing facts, ranges or units.`; +}; diff --git a/libs/@hashintel/petrinaut/docs/ai-assistant.md b/libs/@hashintel/petrinaut/docs/ai-assistant.md index d3e9c9df537..ae265fc8eae 100644 --- a/libs/@hashintel/petrinaut/docs/ai-assistant.md +++ b/libs/@hashintel/petrinaut/docs/ai-assistant.md @@ -33,6 +33,16 @@ The header text is not selectable. Header icons animate on hover and click unles ## The conversation +### Interview budget + +In the website's Brunch assistant, the round icon beside Send opens an interview budget. The same control appears in the Voice dock. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level. + +The pill above the composer estimates time from questions left; it is not a countdown. Hover it for the question count. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The pill progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off hides the pill and uses the ordinary interview without a budget. + +Changing the level adds a note to this session's transcript. Earlier questions still count towards the new cap; Brunch applies the change on the next submission. At the cap, Brunch records the latest answer and closes with stated facts, labelled assumptions and open items. A cap does not mean the model is complete or runnable: missing facts, ranges and units remain open rather than being invented. You can choose a higher level to continue. + +### Messages and activity + In the stock assistant, an empty conversation asks you to **Describe the process you want to create**; later turns say **Continue iterating...**. Press **Enter** or choose **Send message**. **Shift+Enter** adds a line. The field starts as a single line beside the action button and grows with your message. In Brunch Chat, the field always says **Continue iterating...**, and its button switches between Voice for an empty field, Send for typed text, and Stop while a response is running. **Waiting for your decision** marks an open approval; **Experiment running** marks an active run. Suggestion chips hide while Brunch is working and return when idle. Scrolling up keeps your reading position; new text follows automatically only when you are within 96 pixels of the bottom. The primary tab reads **AI** unless the host names it. In Brunch it reads **Chat**, or **Voice** while Voice mode is selected. Your messages appear in right-aligned grey bubbles. Each Brunch turn groups its work in a neutral disclosure, followed by a light-blue answer and any produced cards. In Voice, the written Brunch answer is inside the work disclosure instead. The stock assistant keeps plain answers and a horizontally scrolling row of suggestion chips; Brunch's chips wrap to fit the panel. diff --git a/libs/@hashintel/petrinaut/src/ui/petrinaut.tsx b/libs/@hashintel/petrinaut/src/ui/petrinaut.tsx index c3f900326a6..2d176d91513 100644 --- a/libs/@hashintel/petrinaut/src/ui/petrinaut.tsx +++ b/libs/@hashintel/petrinaut/src/ui/petrinaut.tsx @@ -171,6 +171,8 @@ export type PetrinautAiAssistant = { requestStop?: () => Promise; /** Render a host-owned control inside the assistant composer. */ renderComposerControl?: PetrinautAiComposerControl; + /** Render host-owned status above the text composer or Voice dock. */ + renderComposerStatus?: PetrinautAiComposerControl; /** Render one persistent, provider-neutral Voice mode. */ renderVoiceMode?: PetrinautAiVoiceMode; transport: PetrinautAiTransport; diff --git a/libs/@hashintel/petrinaut/src/ui/types/ai-assistant-composer-control.ts b/libs/@hashintel/petrinaut/src/ui/types/ai-assistant-composer-control.ts index aca401ebdaf..398ac65b6c6 100644 --- a/libs/@hashintel/petrinaut/src/ui/types/ai-assistant-composer-control.ts +++ b/libs/@hashintel/petrinaut/src/ui/types/ai-assistant-composer-control.ts @@ -42,6 +42,8 @@ export type PetrinautAiComposerSubmitText = (params: { export type PetrinautAiComposerControlContext = { /** Effective AI SDK identity, whether host-supplied or generated by `useChat`. */ conversationId: string; + /** Current input surface, supplied by the panel to host-owned controls. */ + inputMode?: PetrinautAiInputMode; messages: PetrinautAiMessage[]; status: PetrinautAiComposerStatus; /** Logical response stopped, including a withheld follow-up; not a Flue settlement claim. */ diff --git a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel.tsx b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel.tsx index 938c49dd099..c1f18c214d3 100644 --- a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel.tsx +++ b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel.tsx @@ -2307,6 +2307,7 @@ const ConversationAiAssistantPanel = ({ const composerControlContext: PetrinautAiComposerControlContext = { conversationId, + inputMode: interactionMode, messages, status, stopped, @@ -2344,6 +2345,9 @@ const ConversationAiAssistantPanel = ({ } composerFocusRequest={composerFocusRequest + focusRequest} composerControl={composerControl} + composerStatus={aiAssistant.renderComposerStatus?.( + composerControlContext, + )} error={streamError ?? error} experimentStates={experimentStates} hostExperimentRunning={hostExperimentReport?.running ?? false} diff --git a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx index dfbbb80baee..507a2d9e721 100644 --- a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx +++ b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx @@ -191,6 +191,7 @@ test("live-capability dock keeps microphone direct and Realtime controls absent" canRepeatQuestion={false} canTakeTurn={false} collapsed={false} + composerControl={} indicator={} microphoneMuted={false} onStop={noop} @@ -201,6 +202,7 @@ test("live-capability dock keeps microphone direct and Realtime controls absent" />, ); expect(screen.getByText("Connected")).toBeTruthy(); + expect(screen.getByRole("button", { name: "Interview budget" })).toBeTruthy(); const microphone = screen.getByRole("button", { name: "Mute microphone" }); expect(microphone).not.toBeNull(); expect(screen.queryByRole("button", { name: "Your turn" })).toBeNull(); @@ -2919,6 +2921,38 @@ describe("AiAssistantContents", () => { expect(renderMarkdown).toHaveBeenCalledOnce(); }); + test.each(["text", "voice"] as const)( + "keeps system notes visible outside assistant activity in %s mode", + (inputMode) => { + render( + , + ); + + expect(screen.getByRole("note").textContent).toBe( + "Interview budget changed to Quick.", + ); + expect(screen.queryByText("Activity")).toBeNull(); + }, + ); + test("hides a closed chat-only panel from the accessibility tree", () => { const { container } = render( ; @@ -695,6 +696,23 @@ const AiAssistantMessage = memo( ); const { work, answers, cards, brief, voiceAgentReply, voiceAgentWrapUp } = renderItems; + if (message.role === "system") { + return ( +
+ {answers.map((item) => ( +
{item.part.text}
+ ))} +
+ ); + } const wasStopped = stopped || message.metadata?.stopped === true; const awaitingApproval = work.tools.some( (tool) => tool.interactive && tool.state === "input-available", @@ -982,6 +1000,7 @@ export const AiAssistantContents = ({ onCancelExperiment, clearMessagesDisabled = false, composerControl, + composerStatus, composerFocusRequest = 0, error, input, @@ -1665,11 +1684,13 @@ export const AiAssistantContents = ({ )} + {composerStatus} {isVoiceSessionLive ? (
+ {composerControl} {actions !== null && ( <> {canRetryPlayback && actions.retryPlayback && ( @@ -411,6 +414,7 @@ export const VoiceDock = ({ export const LiveVoiceDock = ({ assistantBusy, collapsed, + composerControl, errorIndicator, onCollapsedEnd, onCollapsedToggle, @@ -418,6 +422,7 @@ export const LiveVoiceDock = ({ }: { assistantBusy: boolean; collapsed: boolean; + composerControl?: ReactNode; errorIndicator?: ReactNode; onCollapsedEnd?: () => void; onCollapsedToggle: () => void; @@ -450,6 +455,7 @@ export const LiveVoiceDock = ({ canRetryPlayback={canRetryPlayback} canTakeTurn={canTakeTurn} collapsed={collapsed} + composerControl={composerControl} errorIndicator={errorIndicator} interruptionBySpeaking={interruptionBySpeaking} microphoneMuted={microphoneMuted} From 4585e20028b6a401553106a8ddfec1f8a6780b81 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 11:32:05 +0200 Subject: [PATCH 03/41] Match the interview budget control to its prototype Restore the compact colored picker, hover previews and quiet estimate with a focusable detail card. Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 53 +- .../interview-budget-control.tsx | 608 ++++++++++++------ .../src/shared/interview-budget.ts | 12 +- .../@hashintel/petrinaut/docs/ai-assistant.md | 2 +- 4 files changed, 465 insertions(+), 210 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index 6785f3ffe7d..2be1c3a4066 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -1,9 +1,10 @@ // @vitest-environment jsdom import { cleanup, fireEvent, render, screen } from "@testing-library/react"; import { useState } from "react"; -import { afterEach, expect, test, vi } from "vitest"; +import { afterEach, beforeEach, expect, test, vi } from "vitest"; import { type InterviewBudgetLevel } from "../../../shared/interview-budget"; +import { NoopResizeObserver } from "../shared/petrinaut-jsdom"; import { InterviewBudgetControl, InterviewBudgetPill, @@ -11,7 +12,12 @@ import { import type { PetrinautAiComposerControlContext } from "@hashintel/petrinaut/ui"; -afterEach(cleanup); +beforeEach(() => vi.stubGlobal("ResizeObserver", NoopResizeObserver)); +afterEach(() => { + cleanup(); + vi.unstubAllGlobals(); + vi.restoreAllMocks(); +}); const Harness = () => { const [level, setLevel] = useState("standard"); @@ -29,10 +35,23 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible name: "Interview budget level", }); expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); + vi.spyOn(slider, "getBoundingClientRect").mockReturnValue({ + left: 100, + width: 308, + right: 408, + top: 0, + bottom: 32, + height: 32, + x: 100, + y: 0, + toJSON: () => ({}), + }); + fireEvent.mouseMove(slider, { clientX: 394 }); + expect(screen.getByText("Deep · No limit")).toBeTruthy(); + // Previewing a stop must not change the current selection in the header. + expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); fireEvent.mouseEnter(screen.getByRole("button", { name: "Deep" })); - expect( - screen.getByText("Explore edge cases; pause between topics."), - ).toBeTruthy(); + expect(screen.getByText(/Probes units, ranges and edge cases/)).toBeTruthy(); fireEvent.change(slider, { target: { value: "1" } }); expect(slider.getAttribute("aria-valuetext")).toBe("Quick · ~5 min"); fireEvent.click(screen.getByRole("button", { name: "Off" })); @@ -41,7 +60,7 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible ).toBeTruthy(); }); -test("pill counts canonical replies, changes with mode and disappears for Off", () => { +test("pill counts canonical replies, changes with mode and disappears for Off", async () => { const context: PetrinautAiComposerControlContext = { conversationId: "conversation", status: "ready" as const, @@ -57,6 +76,12 @@ test("pill counts canonical replies, changes with mode and disappears for Off", , ); expect(screen.getByRole("status").textContent).toBe("Last question · ~2 min"); + const trigger = screen.getByRole("status").parentElement; + if (!trigger) throw new Error("Missing estimate tooltip trigger"); + fireEvent.focus(trigger); + const card = await screen.findByRole("tooltip"); + expect(card.textContent).toContain("6 questions in text; 5 asked, 1 left."); + expect(card.textContent).toContain("open"); rerender( ); expect(screen.queryByRole("status")).toBeNull(); }); + +test("does not show an estimate before the interview starts", () => { + render( + , + ); + expect(screen.queryByRole("status")).toBeNull(); +}); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index a58fb1296b9..dacd4bb581c 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -7,7 +7,7 @@ import { PiStack, } from "react-icons/pi"; -import { Button, Popover } from "@hashintel/ds-components"; +import { BaseTooltip, Button, Popover } from "@hashintel/ds-components"; import { css } from "@hashintel/ds-helpers/css"; import { @@ -28,32 +28,26 @@ const icons = { thorough: PiMagnifyingGlass, deep: PiStack, }; -// Host colors override the library's separately compiled Button utility layer. -const levelStyle = { +const levelTheme = { off: css({ - color: "neutral.fg.body !important", - backgroundColor: "neutral.bgSolid.surface !important", - borderColor: "neutral.bd.subtle !important", + "--budget-color": "token(colors.neutral.s100)", + "--budget-tint": "token(colors.neutral.a10)", }), quick: css({ - color: "yellow.fg.body !important", - backgroundColor: "yellow.bgSolid.subtle !important", - borderColor: "yellow.bd.subtle !important", + "--budget-color": "token(colors.orange.s90)", + "--budget-tint": "token(colors.orange.a20)", }), standard: css({ - color: "blue.fg.body !important", - backgroundColor: "blue.bgSolid.subtle !important", - borderColor: "blue.bd.subtle !important", + "--budget-color": "token(colors.blue.s90)", + "--budget-tint": "token(colors.blue.a20)", }), thorough: css({ - color: "green.fg.body !important", - backgroundColor: "green.bgSolid.subtle !important", - borderColor: "green.bd.subtle !important", + "--budget-color": "token(colors.green.s90)", + "--budget-tint": "token(colors.green.a20)", }), deep: css({ - color: "purple.fg.body !important", - backgroundColor: "purple.bgSolid.subtle !important", - borderColor: "purple.bd.subtle !important", + "--budget-color": "token(colors.purple.s90)", + "--budget-tint": "token(colors.purple.a20)", }), }; @@ -67,216 +61,362 @@ export const InterviewBudgetControl = ({ const [open, setOpen] = useState(false); const [hovered, setHovered] = useState(null); const triggerRef = useRef(null); + const sliderRef = useRef(null); const config = interviewBudgetLevelsConfig[level]; const CurrentIcon = icons[level]; const selectedIndex = interviewBudgetLevels.indexOf(level); - const preview = interviewBudgetLevelsConfig[hovered ?? level]; + const previewLevel = hovered ?? level; + const preview = interviewBudgetLevelsConfig[previewLevel]; return ( - <> + - ))} -
- -

+ ))} + + { + const bounds = event.currentTarget.getBoundingClientRect(); + const position = Math.max( + 0, + Math.min( + 1, + (event.clientX - bounds.left - 14) / (bounds.width - 28), + ), + ); + setHovered( + interviewBudgetLevels[Math.round(position * 4)] ?? level, + ); + }} + onChange={(event) => { + const next = + interviewBudgetLevels[Number(event.currentTarget.value)]; + if (next) { + setHovered(null); + onChange(next); + } + }} + /> + + +

+ {interviewBudgetLevels.map((stop, index) => ( +
- - + {interviewBudgetLevelsConfig[stop].name} + + ))} + +

+ + {preview.name} · {preview.guide} + {" "} + {preview.description} +

+ )} - + ); }; @@ -291,18 +431,90 @@ export const InterviewBudgetPill = ({ const mode = context.inputMode ?? "text"; const label = interviewBudgetLabel(level, mode, asked); const budget = getInterviewBudget(level, mode, asked); - if (!budget || label === null) return null; + if (!budget || label === null || asked === 0) return null; const config = interviewBudgetLevelsConfig[level]; - const detail = `${config.name} · ${config.guide}. ${asked} replies counted; ${budget.questionCap ?? "no"} question cap in ${mode}; ${budget.remaining ?? "unlimited"} left. ${budget.questionCap === null ? "Pause between topics." : "At the cap, wrap up with facts, assumptions and open items; gaps stay open."} This is an estimate, not a countdown.`; + const nearCap = budget.remaining !== null && budget.remaining <= 1; + const mechanism = + budget.questionCap === null + ? `${asked} asked; no cap. Brunch offers a pause between topics instead of closing.` + : `${budget.questionCap} questions in ${mode}; ${asked} asked, ${budget.remaining} left.`; + const note = + budget.remaining === 0 + ? "Cap reached. Brunch closes after this answer with what it has; anything open is listed, not invented." + : budget.remaining === 1 + ? "After this question Brunch closes with stated facts, recorded assumptions and open items." + : "Minutes are an estimate, not a countdown. Change the level any time."; return ( -
- + +

+ + {config.name} · {config.guide} + + {mechanism} +

+

+ {note} +

+
+ } > - {label} - + + {label} + + ); }; diff --git a/apps/petrinaut-website/src/shared/interview-budget.ts b/apps/petrinaut-website/src/shared/interview-budget.ts index aebcd0dcd68..c29b7b80c14 100644 --- a/apps/petrinaut-website/src/shared/interview-budget.ts +++ b/apps/petrinaut-website/src/shared/interview-budget.ts @@ -14,7 +14,7 @@ export const interviewBudgetLevelsConfig = { minutes: 0, text: null, voice: null, - description: "Interview without a budget.", + description: "No budget sent. Brunch interviews as today.", }, quick: { name: "Quick", @@ -22,7 +22,7 @@ export const interviewBudgetLevelsConfig = { minutes: 5, text: 3, voice: 2, - description: "Focus on the essentials.", + description: "Essentials only, batched. Unsupported gaps stay open.", }, standard: { name: "Standard", @@ -30,7 +30,8 @@ export const interviewBudgetLevelsConfig = { minutes: 10, text: 6, voice: 4, - description: "Explore one topic at a time.", + description: + "One topic at a time, with units. Defaults offered, not assumed.", }, thorough: { name: "Thorough", @@ -38,7 +39,8 @@ export const interviewBudgetLevelsConfig = { minutes: 20, text: 10, voice: 7, - description: "Explore variation and return flows.", + description: + "Adds peaks, durations and return flows. Asks before assuming.", }, deep: { name: "Deep", @@ -46,7 +48,7 @@ export const interviewBudgetLevelsConfig = { minutes: 0, text: null, voice: null, - description: "Explore edge cases; pause between topics.", + description: "Probes units, ranges and edge cases. Nothing assumed.", }, } as const; diff --git a/libs/@hashintel/petrinaut/docs/ai-assistant.md b/libs/@hashintel/petrinaut/docs/ai-assistant.md index ae265fc8eae..dc74bdf7e24 100644 --- a/libs/@hashintel/petrinaut/docs/ai-assistant.md +++ b/libs/@hashintel/petrinaut/docs/ai-assistant.md @@ -37,7 +37,7 @@ The header text is not selectable. Header icons animate on hover and click unles In the website's Brunch assistant, the round icon beside Send opens an interview budget. The same control appears in the Voice dock. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level. -The pill above the composer estimates time from questions left; it is not a countdown. Hover it for the question count. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The pill progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off hides the pill and uses the ordinary interview without a budget. +After the first reply, a quiet estimate appears at the right above the composer. It estimates time from questions left; it is not a countdown. Hover or focus it for a card with the question count and closing behaviour. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The estimate progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off hides the estimate and uses the ordinary interview without a budget. Changing the level adds a note to this session's transcript. Earlier questions still count towards the new cap; Brunch applies the change on the next submission. At the cap, Brunch records the latest answer and closes with stated facts, labelled assumptions and open items. A cap does not mean the model is complete or runnable: missing facts, ranges and units remain open rather than being invented. You can choose a higher level to continue. From 174376cccf62f21110f30180d1a4248c17382bdb Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 13:01:24 +0200 Subject: [PATCH 04/41] Remove divider above the interview budget description Co-authored-by: Amp --- .../main/app/local-storage-demo/interview-budget-control.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index dacd4bb581c..c832ab9fa0c 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -400,10 +400,8 @@ export const InterviewBudgetControl = ({ fontSize: "xs", lineHeight: "[1.45]", color: "neutral.s100", - margin: "[10px 0 0]", - paddingTop: "[10px]", + margin: "[12px 0 0]", minHeight: "[18px]", - borderTop: "[1px solid token(colors.neutral.a10)]", })} > Date: Thu, 1 Oct 2026 14:35:04 +0200 Subject: [PATCH 05/41] Reserve the interview budget status row to avoid layout shift Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 4 ++-- .../local-storage-demo/interview-budget-control.tsx | 12 ++++++++++-- libs/@hashintel/petrinaut/docs/ai-assistant.md | 2 +- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index 2be1c3a4066..c31db1eb955 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -95,7 +95,7 @@ test("pill counts canonical replies, changes with mode and disappears for Off", expect(screen.queryByRole("status")).toBeNull(); }); -test("does not show an estimate before the interview starts", () => { +test("reserves the row with the level before the interview starts", () => { render( { }} />, ); - expect(screen.queryByRole("status")).toBeNull(); + expect(screen.getByRole("status").textContent).toBe("Standard · ~10 min"); }); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index c832ab9fa0c..d7d703e8daf 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -427,10 +427,15 @@ export const InterviewBudgetPill = ({ }) => { const asked = countInterviewReplies(context.messages); const mode = context.inputMode ?? "text"; - const label = interviewBudgetLabel(level, mode, asked); const budget = getInterviewBudget(level, mode, asked); - if (!budget || label === null || asked === 0) return null; + if (!budget) return null; const config = interviewBudgetLevelsConfig[level]; + // The row is always present while a budget is active, so the first reply + // and later label changes do not move the composer or Voice dock. + const label = + asked === 0 + ? `${config.name} · ${config.guide}` + : (interviewBudgetLabel(level, mode, asked) ?? ""); const nearCap = budget.remaining !== null && budget.remaining <= 1; const mechanism = budget.questionCap === null @@ -498,10 +503,13 @@ export const InterviewBudgetPill = ({ data-near-cap={nearCap || undefined} className={css({ display: "inline-flex", + justifyContent: "flex-end", + minWidth: "[132px]", fontSize: "[11px]", fontWeight: "semibold", lineHeight: "[1.5]", fontVariantNumeric: "tabular-nums", + whiteSpace: "nowrap", color: "neutral.s80", borderRadius: "[4px]", cursor: "default", diff --git a/libs/@hashintel/petrinaut/docs/ai-assistant.md b/libs/@hashintel/petrinaut/docs/ai-assistant.md index dc74bdf7e24..a6f72cf4820 100644 --- a/libs/@hashintel/petrinaut/docs/ai-assistant.md +++ b/libs/@hashintel/petrinaut/docs/ai-assistant.md @@ -37,7 +37,7 @@ The header text is not selectable. Header icons animate on hover and click unles In the website's Brunch assistant, the round icon beside Send opens an interview budget. The same control appears in the Voice dock. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level. -After the first reply, a quiet estimate appears at the right above the composer. It estimates time from questions left; it is not a countdown. Hover or focus it for a card with the question count and closing behaviour. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The estimate progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off hides the estimate and uses the ordinary interview without a budget. +While a budget is active, a quiet status sits at the right above the composer or Voice dock. It shows the chosen level until the first reply, then an estimate of time from questions left; it is not a countdown. The row keeps its space, so these changes do not move the input controls. Hover or focus it for a card with the question count and closing behaviour. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The estimate progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off hides the estimate and uses the ordinary interview without a budget. Changing the level adds a note to this session's transcript. Earlier questions still count towards the new cap; Brunch applies the change on the next submission. At the cap, Brunch records the latest answer and closes with stated facts, labelled assumptions and open items. A cap does not mean the model is complete or runnable: missing facts, ranges and units remain open rather than being invented. You can choose a higher level to continue. From aa101abb80078902cb70c4c2538716f21756ef14 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 14:45:52 +0200 Subject: [PATCH 06/41] Shorten interview budget copy in the popover, estimate card and transcript note Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 4 +-- .../interview-budget-control.tsx | 30 +++++++++++-------- .../local-storage-demo-app.tsx | 2 +- .../src/shared/interview-budget.ts | 12 ++++---- .../@hashintel/petrinaut/docs/ai-assistant.md | 2 +- .../ai-assistant-contents.test.tsx | 6 ++-- 6 files changed, 29 insertions(+), 27 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index c31db1eb955..d36fe4bc2f6 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -47,7 +47,7 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible toJSON: () => ({}), }); fireEvent.mouseMove(slider, { clientX: 394 }); - expect(screen.getByText("Deep · No limit")).toBeTruthy(); + expect(screen.getByText("Deep", { selector: "strong" })).toBeTruthy(); // Previewing a stop must not change the current selection in the header. expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); fireEvent.mouseEnter(screen.getByRole("button", { name: "Deep" })); @@ -80,7 +80,7 @@ test("pill counts canonical replies, changes with mode and disappears for Off", if (!trigger) throw new Error("Missing estimate tooltip trigger"); fireEvent.focus(trigger); const card = await screen.findByRole("tooltip"); - expect(card.textContent).toContain("6 questions in text; 5 asked, 1 left."); + expect(card.textContent).toContain("6 questions · 5 asked · 1 left"); expect(card.textContent).toContain("open"); rerender( - - {preview.name} · {preview.guide} - {" "} + {previewLevel !== level && ( + <> + + {preview.name} + {" "} + + )} {preview.description}

@@ -439,14 +443,16 @@ export const InterviewBudgetPill = ({ const nearCap = budget.remaining !== null && budget.remaining <= 1; const mechanism = budget.questionCap === null - ? `${asked} asked; no cap. Brunch offers a pause between topics instead of closing.` - : `${budget.questionCap} questions in ${mode}; ${asked} asked, ${budget.remaining} left.`; + ? `${asked} asked · no cap` + : `${budget.questionCap} questions · ${asked} asked · ${budget.remaining} left`; const note = - budget.remaining === 0 - ? "Cap reached. Brunch closes after this answer with what it has; anything open is listed, not invented." - : budget.remaining === 1 - ? "After this question Brunch closes with stated facts, recorded assumptions and open items." - : "Minutes are an estimate, not a countdown. Change the level any time."; + budget.questionCap === null + ? "Brunch pauses between topics instead of closing." + : budget.remaining === 0 + ? "Brunch closes after this answer; open items stay listed." + : budget.remaining === 1 + ? "Brunch closes after this question; open items stay listed." + : "An estimate, not a countdown."; return (
{ { id: "budget-change", role: "system", - parts: [ - { type: "text", text: "Interview budget changed to Quick." }, - ], + parts: [{ type: "text", text: "Budget: Quick · ~5 min" }], }, ]} onClose={noop} @@ -2947,7 +2945,7 @@ describe("AiAssistantContents", () => { ); expect(screen.getByRole("note").textContent).toBe( - "Interview budget changed to Quick.", + "Budget: Quick · ~5 min", ); expect(screen.queryByText("Activity")).toBeNull(); }, From 6c4a5a05e4c8b6a243ef9b4bbc30267630ef2995 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 19:49:18 +0200 Subject: [PATCH 07/41] Return focus to the interview budget trigger after Escape The trigger remounts when its tooltip is re-enabled on close, so the Popover's focus return landed on a detached button and keyboard users were left on the page body. Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 30 ++++++++++++++++++- .../interview-budget-control.tsx | 13 +++++++- 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index d36fe4bc2f6..bcc2a70d571 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -1,5 +1,11 @@ // @vitest-environment jsdom -import { cleanup, fireEvent, render, screen } from "@testing-library/react"; +import { + cleanup, + fireEvent, + render, + screen, + waitFor, +} from "@testing-library/react"; import { useState } from "react"; import { afterEach, beforeEach, expect, test, vi } from "vitest"; @@ -60,6 +66,28 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible ).toBeTruthy(); }); +test("Escape closes the control and returns focus to its trigger", async () => { + render(); + fireEvent.click( + screen.getByRole("button", { + name: "Interview budget: Standard · ~10 min", + }), + ); + const slider = await screen.findByRole("slider", { + name: "Interview budget level", + }); + await waitFor(() => expect(document.activeElement).toBe(slider)); + fireEvent.keyDown(slider, { key: "Escape" }); + await waitFor(() => expect(screen.queryByRole("slider")).toBeNull()); + await waitFor(() => + expect(document.activeElement).toBe( + screen.getByRole("button", { + name: "Interview budget: Standard · ~10 min", + }), + ), + ); +}); + test("pill counts canonical replies, changes with mode and disappears for Off", async () => { const context: PetrinautAiComposerControlContext = { conversationId: "conversation", diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index aa9a5eb148e..c62871d3822 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -1,4 +1,4 @@ -import { useRef, useState } from "react"; +import { useEffect, useRef, useState } from "react"; import { PiGauge, PiLightning, @@ -62,6 +62,14 @@ export const InterviewBudgetControl = ({ const [hovered, setHovered] = useState(null); const triggerRef = useRef(null); const sliderRef = useRef(null); + // Toggling `disableTooltip` remounts the trigger, so the Popover's own focus + // return lands on a detached button. Restore it after an Escape dismissal. + const refocusTrigger = useRef(false); + useEffect(() => { + if (open || !refocusTrigger.current) return; + refocusTrigger.current = false; + triggerRef.current?.focus(); + }, [open]); const config = interviewBudgetLevelsConfig[level]; const CurrentIcon = icons[level]; const selectedIndex = interviewBudgetLevels.indexOf(level); @@ -140,6 +148,9 @@ export const InterviewBudgetControl = ({
{ + if (event.key === "Escape") refocusTrigger.current = true; + }} onMouseLeave={() => setHovered(null)} className={`${levelTheme[level]} ${css({ width: "[324px]", From 1d95818bdf3e4e98f1469cac77531fd4cbf502a9 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 19:49:18 +0200 Subject: [PATCH 08/41] Keep budget notes made while Brunch is replying A note anchored to the pending user message vanished when canonical history replaced that message with a new id. Fall back to the anchor's position among messages of the same role. Co-authored-by: Amp --- .../local-storage-demo-app.tsx | 50 +++++++++++++------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx index a2960b49bfc..7abe0d15a9d 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx @@ -460,7 +460,11 @@ export const LocalStorageDemoApp = ({ const { level: interviewBudgetLevel, setLevel: setInterviewBudgetLevel } = useInterviewBudgetPreference(); const [budgetNotes, setBudgetNotes] = useState< - { conversationId: string; after: string; message: PetrinautAiMessage }[] + { + conversationId: string; + after: { id: string; role: string; ordinal: number }; + message: PetrinautAiMessage; + }[] >([]); const { enabled: realtimeEnabled, @@ -991,16 +995,28 @@ export const LocalStorageDemoApp = ({ primaryLabel: "Chat", presentation: "brunch" as const, mapMessagesForDisplay: (messages: PetrinautAiMessage[]) => { - const withNotes = messages.flatMap((message) => [ - message, - ...budgetNotes - .filter( - (note) => - note.conversationId === conversationId && - note.after === message.id, - ) - .map((note) => note.message), - ]); + // Canonical history re-identifies an optimistic user message + // once its turn settles, so an anchor whose id is gone falls + // back to its position among messages of the same role. + const ids = new Set(messages.map((message) => message.id)); + const ordinals = new Map(); + const withNotes = messages.flatMap((message) => { + const ordinal = (ordinals.get(message.role) ?? 0) + 1; + ordinals.set(message.role, ordinal); + return [ + message, + ...budgetNotes + .filter( + (note) => + note.conversationId === conversationId && + (ids.has(note.after.id) + ? note.after.id === message.id + : note.after.role === message.role && + note.after.ordinal === ordinal), + ) + .map((note) => note.message), + ]; + }); return mapVoiceMessages?.(withNotes) ?? withNotes; }, resolveToolPresentation: resolveBrunchToolPresentation, @@ -1014,14 +1030,20 @@ export const LocalStorageDemoApp = ({ level={interviewBudgetLevel} onChange={(level) => { if (level === interviewBudgetLevel) return; - const after = context.messages.at(-1)?.id; - if (after) { + const last = context.messages.at(-1); + if (last) { const config = interviewBudgetLevelsConfig[level]; setBudgetNotes((notes) => [ ...notes, { conversationId: context.conversationId, - after, + after: { + id: last.id, + role: last.role, + ordinal: context.messages.filter( + (message) => message.role === last.role, + ).length, + }, message: { id: `interview-budget:${crypto.randomUUID()}`, role: "system", From 6120e861ac6ac2a946f50a6679119ce09a722ed7 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Thu, 1 Oct 2026 22:25:24 +0200 Subject: [PATCH 09/41] Simplify interview level notes in the chat transcript Co-authored-by: Amp --- .../local-storage-demo-app.tsx | 2 +- .../@hashintel/petrinaut/docs/ai-assistant.md | 2 +- .../ai-assistant-contents.test.tsx | 8 +++---- .../ai-assistant-contents.tsx | 21 +++++++++++++++---- 4 files changed, 23 insertions(+), 10 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx index 7abe0d15a9d..6fc9029113e 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx @@ -1050,7 +1050,7 @@ export const LocalStorageDemoApp = ({ parts: [ { type: "text", - text: `Budget: ${config.name} · ${config.guide}`, + text: `${config.name} · ${config.guide}`, }, ], }, diff --git a/libs/@hashintel/petrinaut/docs/ai-assistant.md b/libs/@hashintel/petrinaut/docs/ai-assistant.md index efc3d795b8f..fa10e269b95 100644 --- a/libs/@hashintel/petrinaut/docs/ai-assistant.md +++ b/libs/@hashintel/petrinaut/docs/ai-assistant.md @@ -39,7 +39,7 @@ In the website's Brunch assistant, the round icon beside Send opens an interview While a budget is active, a quiet status sits at the right above the composer or Voice dock. It shows the chosen level until the first reply, then an estimate of time from questions left; it is not a countdown. The row keeps its space, so these changes do not move the input controls. Hover or focus it for a card with the question count and closing behaviour. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The estimate progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off hides the estimate and uses the ordinary interview without a budget. -Changing the level adds a short **Budget** note to this session's transcript. Earlier questions still count towards the new cap; Brunch applies the change on the next submission. At the cap, Brunch records the latest answer and closes with stated facts, labelled assumptions and open items. A cap does not mean the model is complete or runnable: missing facts, ranges and units remain open rather than being invented. You can choose a higher level to continue. +Changing the level adds a compact note with a settings icon and the new level, such as **Quick · ~5 min**, to this session's transcript. Earlier questions still count towards the new cap; Brunch applies the change on the next submission. At the cap, Brunch records the latest answer and closes with stated facts, labelled assumptions and open items. A cap does not mean the model is complete or runnable: missing facts, ranges and units remain open rather than being invented. You can choose a higher level to continue. ### Messages and activity diff --git a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx index 0ccd7e9d020..ba7113866fc 100644 --- a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx +++ b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx @@ -2932,7 +2932,7 @@ describe("AiAssistantContents", () => { { id: "budget-change", role: "system", - parts: [{ type: "text", text: "Budget: Quick · ~5 min" }], + parts: [{ type: "text", text: "Quick · ~5 min" }], }, ]} onClose={noop} @@ -2944,9 +2944,9 @@ describe("AiAssistantContents", () => { />, ); - expect(screen.getByRole("note").textContent).toBe( - "Budget: Quick · ~5 min", - ); + const note = screen.getByRole("note"); + expect(note.textContent).toBe("Quick · ~5 min"); + expect(note.querySelector('svg[aria-hidden="true"]')).not.toBeNull(); expect(screen.queryByText("Activity")).toBeNull(); }, ); diff --git a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx index 1aecce8aa0a..009b7dc248e 100644 --- a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx +++ b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx @@ -702,14 +702,27 @@ const AiAssistantMessage = memo( role="note" data-role="system" className={css({ - paddingY: "2", + display: "flex", + alignItems: "center", + gap: "1.5", + paddingY: "0.5", color: "neutral.fg.body", fontSize: "xs", })} > - {answers.map((item) => ( -
{item.part.text}
- ))} + +
+ {answers.map((item) => ( +
{item.part.text}
+ ))} +
); } From f6e634e2d31df9ffa9ccdeff1a9ca76c246ddc8f Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Fri, 2 Oct 2026 05:31:43 +0200 Subject: [PATCH 10/41] Refine interview level notes and preserve blank dock status space Co-authored-by: Amp --- .changeset/interview-budget-controls.md | 2 +- .../interview-budget-control.test.tsx | 36 +++++++----- .../interview-budget-control.tsx | 55 ++++++++++++++++--- .../local-storage-demo-app.tsx | 11 ++++ .../@hashintel/petrinaut/docs/ai-assistant.md | 4 +- .../@hashintel/petrinaut/src/ui/petrinaut.tsx | 10 +++- .../Editor/panels/ai-assistant-panel.tsx | 1 + .../ai-assistant-contents.test.tsx | 38 +++++++++++++ .../ai-assistant-contents.tsx | 26 +++++++-- 9 files changed, 153 insertions(+), 30 deletions(-) diff --git a/.changeset/interview-budget-controls.md b/.changeset/interview-budget-controls.md index f19874cb7f4..988a120223f 100644 --- a/.changeset/interview-budget-controls.md +++ b/.changeset/interview-budget-controls.md @@ -2,4 +2,4 @@ "@hashintel/petrinaut": patch --- -Support host-owned status above the assistant composer and Voice dock, keep composer controls available during live Voice sessions, and supply the current input mode to host controls. Display system messages as visible notes in Chat and Voice. +Support host-owned status above the assistant composer and Voice dock, keep composer controls available during live Voice sessions, and supply the current input mode to host controls. Display system messages as visible notes in Chat and Voice, with optional host-owned rendering. diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index bcc2a70d571..f450367c692 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -123,18 +123,24 @@ test("pill counts canonical replies, changes with mode and disappears for Off", expect(screen.queryByRole("status")).toBeNull(); }); -test("reserves the row with the level before the interview starts", () => { - render( - , - ); - expect(screen.getByRole("status").textContent).toBe("Standard · ~10 min"); -}); +test.each(["text", "voice"] as const)( + "reserves a blank row before the interview starts in %s", + (inputMode) => { + render( + , + ); + expect(screen.queryByRole("status")).toBeNull(); + expect(screen.queryByText("Standard · ~10 min")).toBeNull(); + expect(document.querySelector("[data-budget-placeholder]")).not.toBeNull(); + }, +); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index c62871d3822..b93e1f6a55c 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -433,6 +433,44 @@ export const InterviewBudgetControl = ({ ); }; +export const InterviewBudgetNote = ({ + level, +}: { + level: InterviewBudgetLevel; +}) => { + const ref = useRef(null); + const CurrentIcon = icons[level]; + const config = interviewBudgetLevelsConfig[level]; + useEffect(() => { + if (window.matchMedia("(prefers-reduced-motion: reduce)").matches) return; + const animation = ref.current?.animate( + [ + { opacity: 0.6, transform: "translateY(2px)" }, + { opacity: 1, transform: "translateY(0)" }, + ], + { duration: 180, easing: "ease-out" }, + ); + return () => animation?.cancel(); + }, []); + return ( +
+
+ ); +}; + export const InterviewBudgetPill = ({ level, context, @@ -443,14 +481,17 @@ export const InterviewBudgetPill = ({ const asked = countInterviewReplies(context.messages); const mode = context.inputMode ?? "text"; const budget = getInterviewBudget(level, mode, asked); - if (!budget) return null; + // Keep the same footprint as the estimate, including its bottom padding. + if (!budget || asked === 0) + return ( + )} - {composerStatus} + {!isVoiceDockCollapsed && composerStatus} {isVoiceSessionLive ? (
Date: Fri, 2 Oct 2026 05:58:46 +0200 Subject: [PATCH 14/41] Rename the interview control to Conversation depth Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 17 +++++++++++------ .../interview-budget-control.tsx | 19 ++++++++++++++----- .../@hashintel/petrinaut/docs/ai-assistant.md | 4 ++-- 3 files changed, 27 insertions(+), 13 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index 21234a2b88a..b97daa756d6 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -51,12 +51,17 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible render(); fireEvent.click( screen.getByRole("button", { - name: "Interview budget: Standard · ~10 min", + name: "Conversation depth: Standard · ~10 min", }), ); const slider = await screen.findByRole("slider", { - name: "Interview budget level", + name: "Conversation depth level", }); + expect( + screen.getByRole("group", { name: "Conversation depth" }), + ).toBeTruthy(); + expect(screen.getByText("Conversation depth")).toBeTruthy(); + expect(screen.getByText("Choose how much detail to explore.")).toBeTruthy(); expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); vi.spyOn(slider, "getBoundingClientRect").mockReturnValue({ left: 100, @@ -79,7 +84,7 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible expect(slider.getAttribute("aria-valuetext")).toBe("Quick · ~5 min"); fireEvent.click(screen.getByRole("button", { name: "Off" })); expect( - screen.getByRole("button", { name: "Interview budget: Off · No budget" }), + screen.getByRole("button", { name: "Conversation depth: Off · No budget" }), ).toBeTruthy(); }); @@ -87,11 +92,11 @@ test("Escape closes the control and returns focus to its trigger", async () => { render(); fireEvent.click( screen.getByRole("button", { - name: "Interview budget: Standard · ~10 min", + name: "Conversation depth: Standard · ~10 min", }), ); const slider = await screen.findByRole("slider", { - name: "Interview budget level", + name: "Conversation depth level", }); await waitFor(() => expect(document.activeElement).toBe(slider)); fireEvent.keyDown(slider, { key: "Escape" }); @@ -99,7 +104,7 @@ test("Escape closes the control and returns focus to its trigger", async () => { await waitFor(() => expect(document.activeElement).toBe( screen.getByRole("button", { - name: "Interview budget: Standard · ~10 min", + name: "Conversation depth: Standard · ~10 min", }), ), ); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index 48c208e5237..1c5d1fa5854 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -108,7 +108,7 @@ export const InterviewBudgetControl = ({ }, })} data-budget-level={level} - aria-label={`Interview budget: ${config.name} · ${config.guide}`} + aria-label={`Conversation depth: ${config.name} · ${config.guide}`} aria-expanded={open} aria-haspopup="dialog" tooltip={`${config.name} · ${config.guide}`} @@ -129,7 +129,7 @@ export const InterviewBudgetControl = ({ >
{ if (event.key === "Escape") refocusTrigger.current = true; }} @@ -151,7 +151,7 @@ export const InterviewBudgetControl = ({ alignItems: "baseline", justifyContent: "space-between", gap: "2", - marginBottom: "[14px]", + marginBottom: "[4px]", })} > - Interview budget + Conversation depth
+

+ Choose how much detail to explore. +

Date: Fri, 2 Oct 2026 06:11:06 +0200 Subject: [PATCH 15/41] Simplify the interview control label to Detail level Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 20 +++++++++---------- .../interview-budget-control.tsx | 19 +++++------------- .../@hashintel/petrinaut/docs/ai-assistant.md | 4 ++-- 3 files changed, 16 insertions(+), 27 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index b97daa756d6..9a33393b478 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -51,17 +51,15 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible render(); fireEvent.click( screen.getByRole("button", { - name: "Conversation depth: Standard · ~10 min", + name: "Detail level: Standard · ~10 min", }), ); const slider = await screen.findByRole("slider", { - name: "Conversation depth level", + name: "Detail level", }); - expect( - screen.getByRole("group", { name: "Conversation depth" }), - ).toBeTruthy(); - expect(screen.getByText("Conversation depth")).toBeTruthy(); - expect(screen.getByText("Choose how much detail to explore.")).toBeTruthy(); + expect(screen.getByRole("group", { name: "Detail level" })).toBeTruthy(); + expect(screen.getByText("Detail level")).toBeTruthy(); + expect(screen.queryByText("Choose how much detail to explore.")).toBeNull(); expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); vi.spyOn(slider, "getBoundingClientRect").mockReturnValue({ left: 100, @@ -84,7 +82,7 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible expect(slider.getAttribute("aria-valuetext")).toBe("Quick · ~5 min"); fireEvent.click(screen.getByRole("button", { name: "Off" })); expect( - screen.getByRole("button", { name: "Conversation depth: Off · No budget" }), + screen.getByRole("button", { name: "Detail level: Off · No budget" }), ).toBeTruthy(); }); @@ -92,11 +90,11 @@ test("Escape closes the control and returns focus to its trigger", async () => { render(); fireEvent.click( screen.getByRole("button", { - name: "Conversation depth: Standard · ~10 min", + name: "Detail level: Standard · ~10 min", }), ); const slider = await screen.findByRole("slider", { - name: "Conversation depth level", + name: "Detail level", }); await waitFor(() => expect(document.activeElement).toBe(slider)); fireEvent.keyDown(slider, { key: "Escape" }); @@ -104,7 +102,7 @@ test("Escape closes the control and returns focus to its trigger", async () => { await waitFor(() => expect(document.activeElement).toBe( screen.getByRole("button", { - name: "Conversation depth: Standard · ~10 min", + name: "Detail level: Standard · ~10 min", }), ), ); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index 1c5d1fa5854..49d98739c99 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -108,7 +108,7 @@ export const InterviewBudgetControl = ({ }, })} data-budget-level={level} - aria-label={`Conversation depth: ${config.name} · ${config.guide}`} + aria-label={`Detail level: ${config.name} · ${config.guide}`} aria-expanded={open} aria-haspopup="dialog" tooltip={`${config.name} · ${config.guide}`} @@ -129,7 +129,7 @@ export const InterviewBudgetControl = ({ >
{ if (event.key === "Escape") refocusTrigger.current = true; }} @@ -151,7 +151,7 @@ export const InterviewBudgetControl = ({ alignItems: "baseline", justifyContent: "space-between", gap: "2", - marginBottom: "[4px]", + marginBottom: "[14px]", })} > - Conversation depth + Detail level
-

- Choose how much detail to explore. -

Date: Fri, 2 Oct 2026 06:14:54 +0200 Subject: [PATCH 16/41] Label the interview control Interview length Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 16 ++++++++-------- .../interview-budget-control.tsx | 8 ++++---- libs/@hashintel/petrinaut/docs/ai-assistant.md | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index 9a33393b478..d0833b04980 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -51,14 +51,14 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible render(); fireEvent.click( screen.getByRole("button", { - name: "Detail level: Standard · ~10 min", + name: "Interview length: Standard · ~10 min", }), ); const slider = await screen.findByRole("slider", { - name: "Detail level", + name: "Interview length", }); - expect(screen.getByRole("group", { name: "Detail level" })).toBeTruthy(); - expect(screen.getByText("Detail level")).toBeTruthy(); + expect(screen.getByRole("group", { name: "Interview length" })).toBeTruthy(); + expect(screen.getByText("Interview length")).toBeTruthy(); expect(screen.queryByText("Choose how much detail to explore.")).toBeNull(); expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); vi.spyOn(slider, "getBoundingClientRect").mockReturnValue({ @@ -82,7 +82,7 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible expect(slider.getAttribute("aria-valuetext")).toBe("Quick · ~5 min"); fireEvent.click(screen.getByRole("button", { name: "Off" })); expect( - screen.getByRole("button", { name: "Detail level: Off · No budget" }), + screen.getByRole("button", { name: "Interview length: Off · No budget" }), ).toBeTruthy(); }); @@ -90,11 +90,11 @@ test("Escape closes the control and returns focus to its trigger", async () => { render(); fireEvent.click( screen.getByRole("button", { - name: "Detail level: Standard · ~10 min", + name: "Interview length: Standard · ~10 min", }), ); const slider = await screen.findByRole("slider", { - name: "Detail level", + name: "Interview length", }); await waitFor(() => expect(document.activeElement).toBe(slider)); fireEvent.keyDown(slider, { key: "Escape" }); @@ -102,7 +102,7 @@ test("Escape closes the control and returns focus to its trigger", async () => { await waitFor(() => expect(document.activeElement).toBe( screen.getByRole("button", { - name: "Detail level: Standard · ~10 min", + name: "Interview length: Standard · ~10 min", }), ), ); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index 49d98739c99..cfc9fa9f102 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -108,7 +108,7 @@ export const InterviewBudgetControl = ({ }, })} data-budget-level={level} - aria-label={`Detail level: ${config.name} · ${config.guide}`} + aria-label={`Interview length: ${config.name} · ${config.guide}`} aria-expanded={open} aria-haspopup="dialog" tooltip={`${config.name} · ${config.guide}`} @@ -129,7 +129,7 @@ export const InterviewBudgetControl = ({ >
{ if (event.key === "Escape") refocusTrigger.current = true; }} @@ -163,7 +163,7 @@ export const InterviewBudgetControl = ({ color: "neutral.s100", })} > - Detail level + Interview length Date: Fri, 2 Oct 2026 06:19:20 +0200 Subject: [PATCH 17/41] Simplify interview length descriptions Co-authored-by: Amp --- .../interview-budget-control.test.tsx | 2 +- apps/petrinaut-website/src/shared/interview-budget.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx index d0833b04980..1058a78d650 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.test.tsx @@ -77,7 +77,7 @@ test("opens a five-stop control with hover descriptions and keyboard-accessible // Previewing a stop must not change the current selection in the header. expect(slider.getAttribute("aria-valuetext")).toBe("Standard · ~10 min"); fireEvent.mouseEnter(screen.getByRole("button", { name: "Deep" })); - expect(screen.getByText(/Probes units, ranges and edge cases/)).toBeTruthy(); + expect(screen.getByText(/Keep exploring, without a limit/)).toBeTruthy(); fireEvent.change(slider, { target: { value: "1" } }); expect(slider.getAttribute("aria-valuetext")).toBe("Quick · ~5 min"); fireEvent.click(screen.getByRole("button", { name: "Off" })); diff --git a/apps/petrinaut-website/src/shared/interview-budget.ts b/apps/petrinaut-website/src/shared/interview-budget.ts index bf1d5fe0cfa..aea570c4ff3 100644 --- a/apps/petrinaut-website/src/shared/interview-budget.ts +++ b/apps/petrinaut-website/src/shared/interview-budget.ts @@ -14,7 +14,7 @@ export const interviewBudgetLevelsConfig = { minutes: 0, text: null, voice: null, - description: "Brunch interviews as today.", + description: "No set length.", }, quick: { name: "Quick", @@ -22,7 +22,7 @@ export const interviewBudgetLevelsConfig = { minutes: 5, text: 3, voice: 2, - description: "Essentials only, batched.", + description: "Just the essentials.", }, standard: { name: "Standard", @@ -30,7 +30,7 @@ export const interviewBudgetLevelsConfig = { minutes: 10, text: 6, voice: 4, - description: "One topic at a time, with units.", + description: "Cover the main steps.", }, thorough: { name: "Thorough", @@ -38,7 +38,7 @@ export const interviewBudgetLevelsConfig = { minutes: 20, text: 10, voice: 7, - description: "Adds peaks, durations and return flows.", + description: "Include details and exceptions.", }, deep: { name: "Deep", @@ -46,7 +46,7 @@ export const interviewBudgetLevelsConfig = { minutes: 0, text: null, voice: null, - description: "Probes units, ranges and edge cases.", + description: "Keep exploring, without a limit.", }, } as const; From 17664c398a34e42d29470db7f74fbdd6b0af7d88 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Fri, 2 Oct 2026 08:15:03 +0200 Subject: [PATCH 18/41] Gate interview length behind Brunch Labs Co-authored-by: Amp --- .../assistant-labs-settings.test.tsx | 28 +++++ .../assistant-labs-settings.tsx | 15 +++ .../local-storage-demo-app.test.tsx | 106 +++++++++++++++++- .../local-storage-demo-app.tsx | 102 ++++++++++------- .../local-storage-demo/voice-preference.ts | 34 +++++- .../@hashintel/petrinaut/docs/ai-assistant.md | 4 +- 6 files changed, 240 insertions(+), 49 deletions(-) diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.test.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.test.tsx index 092a87b8064..55657a53428 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.test.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.test.tsx @@ -23,10 +23,13 @@ const defaultProps = { assistantReady: true, brunchConfigured: true, brunchSelected: false, + interviewBudgetEnabled: false, + interviewBudgetPreferenceReady: true, openAIVoiceConfig: voiceConfig, realtimeEnabled: false, realtimePreferenceReady: true, selectAssistant: vi.fn(), + setInterviewBudgetEnabled: vi.fn(), setRealtimeEnabled: vi.fn(), setVoiceEnabled: vi.fn(), voiceEnabled: false, @@ -83,6 +86,31 @@ test("selects Brunch, enables Voice, and explains when Voice is unavailable", as ).toBeDefined(); }); +test("shows Interview length only within Brunch and waits for its preference", async () => { + const view = render(); + expect( + screen.queryByRole("checkbox", { name: "Interview length" }), + ).toBeNull(); + view.rerender( + , + ); + expect( + screen.getByRole("checkbox", { name: "Interview length" }), + ).toHaveProperty("disabled", true); + view.rerender(); + const toggle = screen.getByRole("checkbox", { name: "Interview length" }); + expect(toggle).toHaveProperty("checked", false); + expect(toggle).toHaveProperty("disabled", false); + fireEvent.click(toggle); + await waitFor(() => + expect(defaultProps.setInterviewBudgetEnabled).toHaveBeenCalledWith(true), + ); +}); + test("shows Realtime only for enabled Brunch Voice and waits for capability", async () => { const view = render(); expect(screen.queryByRole("checkbox", { name: "Realtime mode" })).toBeNull(); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.tsx index e8f232fa63a..5ad3198eace 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/assistant-labs-settings.tsx @@ -95,10 +95,13 @@ export const AssistantLabsSettings = ({ assistantReady, brunchConfigured, brunchSelected, + interviewBudgetEnabled, + interviewBudgetPreferenceReady, openAIVoiceConfig, realtimeEnabled, realtimePreferenceReady, selectAssistant, + setInterviewBudgetEnabled, setRealtimeEnabled, setVoiceEnabled, voiceEnabled, @@ -107,10 +110,13 @@ export const AssistantLabsSettings = ({ readonly assistantReady: boolean; readonly brunchConfigured: boolean; readonly brunchSelected: boolean; + readonly interviewBudgetEnabled: boolean; + readonly interviewBudgetPreferenceReady: boolean; readonly openAIVoiceConfig: OpenAIVoiceConfig | null | undefined; readonly realtimeEnabled: boolean; readonly realtimePreferenceReady: boolean; readonly selectAssistant: (selection: AssistantSelection) => void; + readonly setInterviewBudgetEnabled: (enabled: boolean) => void; readonly setRealtimeEnabled: (enabled: boolean) => void; readonly setVoiceEnabled: (enabled: boolean) => void; readonly voiceEnabled: boolean; @@ -141,6 +147,15 @@ export const AssistantLabsSettings = ({ onChange={(enabled) => selectAssistant(enabled ? "brunch" : "stock")} value={brunchSelected} /> + {brunchSelected && ( + + )} { await waitFor(() => expect(currentVoiceProvider()).toBe("live")); }); + test.each([ + [undefined, "standard"], + ["thorough", "thorough"], + ["off", "off"], + ] as const)( + "gates interview length separately from saved level %s", + async (savedLevel, expectedLevel) => { + const incarnationId = "interview-length-labs"; + seedStoredNet(incarnationId); + localStorage.setItem(assistantSelectionStorageKey, "brunch"); + if (savedLevel) + localStorage.setItem("petrinaut-website:interview-budget", savedLevel); + flueClientMock.current = flueHistoryClient(incarnationId); + vi.stubGlobal("PointerEvent", MouseEvent); + vi.stubGlobal( + "fetch", + vi.fn(async () => + Response.json({ + available: true, + provider: "live", + connectionTimeoutMs: 10_000, + }), + ), + ); + const context = { + conversationId: "labs-test", + messages: [], + status: "ready" as const, + stop: vi.fn(async () => {}), + submitText: vi.fn(), + }; + const expectBudget = (enabled: boolean) => { + const level = enabled ? expectedLevel : "off"; + expect(brunchPanelTransportOptions.current).toEqual( + expect.objectContaining({ interviewBudgetLevel: level }), + ); + const assistant = currentAssistant(); + const composer = assistant.renderComposerControl?.(context); + if (!isValidElement<{ children: ReactNode }>(composer)) + throw new Error("Missing composer controls"); + expect( + Children.toArray(composer.props.children).some( + (child) => + isValidElement(child) && child.type === InterviewBudgetControl, + ), + ).toBe(enabled); + expect(Boolean(assistant.renderComposerStatus?.(context))).toBe( + enabled, + ); + const voice = assistant.renderVoiceMode?.({ + ...context, + inputMode: "voice", + isAiAssistantOpen: true, + canAcceptVoiceInput: true, + registerVoiceModeControls: vi.fn(() => () => {}), + reportVoiceSessionState: vi.fn(), + setInputMode: vi.fn(), + setVoiceActive: vi.fn(), + submitVoiceInput: vi.fn(), + }); + if (!isValidElement<{ interviewBudgetLevel: string }>(voice)) + throw new Error("Missing Voice control"); + expect(voice.props.interviewBudgetLevel).toBe(level); + }; + const firstView = render( + {}} search={{}} />, + ); + const toggle = await screen.findByRole("checkbox", { + name: "Interview length", + }); + await waitFor(() => + expect(currentAssistant().renderVoiceMode).toBeDefined(), + ); + expect(toggle).toHaveProperty("checked", false); + expectBudget(false); + fireEvent.click(toggle); + await waitFor(() => expectBudget(true)); + expect( + localStorage.getItem("petrinaut-website:interview-budget-enabled"), + ).toBe("true"); + firstView.unmount(); + const restoredView = render( + {}} search={{}} />, + ); + await waitFor(() => expectBudget(true)); + const restoredToggle = screen.getByRole("checkbox", { + name: "Interview length", + }); + expect(restoredToggle).toHaveProperty("checked", true); + fireEvent.click(restoredToggle); + await waitFor(() => expectBudget(false)); + expect( + localStorage.getItem("petrinaut-website:interview-budget-enabled"), + ).toBe("false"); + expect(localStorage.getItem("petrinaut-website:interview-budget")).toBe( + savedLevel ?? null, + ); + restoredView.unmount(); + render( {}} search={{}} />); + await waitFor(() => expectBudget(false)); + }, + ); + test("a stored Brunch choice remains selectable and switching to Stock mounts nothing of Brunch", async () => { const incarnationId = "selection-incarnation"; seedStoredNet(incarnationId); diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx index 45d4a53ca9f..8b324da0237 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/local-storage-demo-app.tsx @@ -458,8 +458,17 @@ export const LocalStorageDemoApp = ({ ready: voicePreferenceReady, setEnabled: setVoiceEnabled, } = useVoicePreference(); - const { level: interviewBudgetLevel, setLevel: setInterviewBudgetLevel } = - useInterviewBudgetPreference(); + const { + level: selectedInterviewBudgetLevel, + setLevel: setInterviewBudgetLevel, + enabled: interviewBudgetEnabled, + setEnabled: setInterviewBudgetEnabled, + ready: interviewBudgetPreferenceReady, + } = useInterviewBudgetPreference(); + const interviewBudgetLevel = + interviewBudgetEnabled && interviewBudgetPreferenceReady + ? selectedInterviewBudgetLevel + : "off"; const [budgetNotes, setBudgetNotes] = useState< { conversationId: string; @@ -1036,51 +1045,54 @@ export const LocalStorageDemoApp = ({ ) => ( <> - { - if (level === interviewBudgetLevel) return; - const last = context.messages.at(-1); - if (last) { - const config = interviewBudgetLevelsConfig[level]; - setBudgetNotes((notes) => [ - ...notes, - { - conversationId: context.conversationId, - level, - after: { - id: last.id, - role: last.role, - ordinal: context.messages.filter( - (message) => message.role === last.role, - ).length, - }, - message: { - id: `interview-budget:${crypto.randomUUID()}`, - role: "system", - parts: [ - { - type: "text", - text: `${config.name} · ${config.guide}`, - }, - ], + {interviewBudgetEnabled && ( + { + if (level === interviewBudgetLevel) return; + const last = context.messages.at(-1); + if (last) { + const config = interviewBudgetLevelsConfig[level]; + setBudgetNotes((notes) => [ + ...notes, + { + conversationId: context.conversationId, + level, + after: { + id: last.id, + role: last.role, + ordinal: context.messages.filter( + (message) => message.role === last.role, + ).length, + }, + message: { + id: `interview-budget:${crypto.randomUUID()}`, + role: "system", + parts: [ + { + type: "text", + text: `${config.name} · ${config.guide}`, + }, + ], + }, }, - }, - ]); - } - setInterviewBudgetLevel(level); - }} - /> + ]); + } + setInterviewBudgetLevel(level); + }} + /> + )} ), renderComposerStatus: ( context: PetrinautAiComposerControlContext, - ) => ( - - ), + ) => + interviewBudgetEnabled ? ( + + ) : null, } : {}), ...(conversationId === null ? {} : { conversationId }), @@ -1154,6 +1166,7 @@ export const LocalStorageDemoApp = ({ }, [ aiMessagesByNetId, budgetNotes, + interviewBudgetEnabled, interviewBudgetLevel, setInterviewBudgetLevel, mapVoiceMessages, @@ -1252,10 +1265,15 @@ export const LocalStorageDemoApp = ({ assistantReady={assistantSelectionReady} brunchConfigured={brunchPreviewConfig.isBrunchConfigured} brunchSelected={brunchSelected} + interviewBudgetEnabled={interviewBudgetEnabled} + interviewBudgetPreferenceReady={ + interviewBudgetPreferenceReady + } openAIVoiceConfig={openAIVoiceConfig} realtimeEnabled={realtimeEnabled} realtimePreferenceReady={realtimePreferenceReady} selectAssistant={selectAssistant} + setInterviewBudgetEnabled={setInterviewBudgetEnabled} setRealtimeEnabled={setRealtimeEnabled} setVoiceEnabled={setVoiceEnabled} voiceEnabled={brunchSelected && voiceEnabled} diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts b/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts index 2950bfd1c05..8f22af9aa19 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/voice-preference.ts @@ -30,13 +30,37 @@ const readInterviewBudget = (): InterviewBudgetLevel => { const writeInterviewBudget = (level: InterviewBudgetLevel): void => writeBrowserStorage(localStorage, interviewBudgetStorageKey, level); +const interviewBudgetEnabledStorageKey = + "petrinaut-website:interview-budget-enabled"; +const readInterviewBudgetEnabled = (): boolean => + readBrowserStorage(localStorage, interviewBudgetEnabledStorageKey) === "true"; +const writeInterviewBudgetEnabled = (enabled: boolean): void => + writeBrowserStorage( + localStorage, + interviewBudgetEnabledStorageKey, + String(enabled), + ); + export const useInterviewBudgetPreference = () => { - const [level, setLevel] = usePersistedState({ - fallback: "standard", - read: readInterviewBudget, - write: writeInterviewBudget, + const [level, setLevel, levelReady] = usePersistedState( + { + fallback: "standard", + read: readInterviewBudget, + write: writeInterviewBudget, + }, + ); + const [enabled, setEnabled, enabledReady] = usePersistedState({ + fallback: false, + read: readInterviewBudgetEnabled, + write: writeInterviewBudgetEnabled, }); - return { level, setLevel }; + return { + level, + setLevel, + enabled, + setEnabled, + ready: levelReady && enabledReady, + }; }; const realtimePreferenceStorageKey = "petrinaut-website:realtime-enabled"; diff --git a/libs/@hashintel/petrinaut/docs/ai-assistant.md b/libs/@hashintel/petrinaut/docs/ai-assistant.md index 280ee05ef9b..834b7b92dd5 100644 --- a/libs/@hashintel/petrinaut/docs/ai-assistant.md +++ b/libs/@hashintel/petrinaut/docs/ai-assistant.md @@ -35,7 +35,9 @@ The header text is not selectable. Header icons animate on hover and click unles ### Interview length -In the website's Brunch assistant, the round icon beside Send opens **Interview length**. The same control appears in the Voice dock. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level. +In the website, turn on **Use Brunch** in **Settings → Labs**, then enable **Interview length**. This experiment starts disabled: no length control or estimate appears, and Brunch uses its ordinary interview behaviour. Turning it off preserves your saved level for next time. + +When enabled, the round icon beside Send opens **Interview length**. The same control appears in the Voice dock. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level and whether the experiment is enabled. After the first reply, a quiet status sits at the right above the composer or Voice controls in the expanded conversation. It estimates time from questions left; it is not a countdown. The row stays blank before the first reply and when Off is selected, but keeps its space so the input controls do not move. The collapsed Voice dock omits this row entirely to stay compact; expand the conversation to see the estimate. Hover or focus the estimate for a card with the question count and closing behaviour. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The estimate progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off uses the ordinary interview without a budget. From ed2e2d0642835a060e973aee06582f75223ba3b0 Mon Sep 17 00:00:00 2001 From: Kostandin Angjellari Date: Fri, 2 Oct 2026 08:25:46 +0200 Subject: [PATCH 19/41] Move interview length to the leading composer edge Co-authored-by: Amp --- .changeset/interview-budget-controls.md | 2 +- .../interview-budget-control.tsx | 4 +- .../@hashintel/petrinaut/docs/ai-assistant.md | 2 +- .../ai-assistant-contents.test.tsx | 41 ++++++++++++++++++- .../ai-assistant-contents.tsx | 3 +- .../ai-assistant-contents/voice-dock.tsx | 2 +- 6 files changed, 47 insertions(+), 7 deletions(-) diff --git a/.changeset/interview-budget-controls.md b/.changeset/interview-budget-controls.md index 7310076fccb..1ccf693d5b3 100644 --- a/.changeset/interview-budget-controls.md +++ b/.changeset/interview-budget-controls.md @@ -2,4 +2,4 @@ "@hashintel/petrinaut": patch --- -Support host-owned status above the assistant composer and expanded Voice controls without increasing the collapsed dock's height, keep composer controls available during live Voice sessions, and supply the current input mode to host controls. Display system messages as visible notes in Chat and Voice, with optional host-owned rendering. +Support host-owned status above the assistant composer and expanded Voice controls without increasing the collapsed dock's height, keep composer controls available during live Voice sessions, and supply the current input mode to host controls. Place host controls at the left of the Brunch composer and Voice dock, separate from submission and session actions. Display system messages as visible notes in Chat and Voice, with optional host-owned rendering. diff --git a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx index cfc9fa9f102..3e5af4cdbff 100644 --- a/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx +++ b/apps/petrinaut-website/src/main/app/local-storage-demo/interview-budget-control.tsx @@ -111,7 +111,7 @@ export const InterviewBudgetControl = ({ aria-label={`Interview length: ${config.name} · ${config.guide}`} aria-expanded={open} aria-haspopup="dialog" - tooltip={`${config.name} · ${config.guide}`} + tooltip={`Interview length · ${config.name}`} tooltipOptions={{ disableTooltip: open }} prefix={} onClick={() => { @@ -123,7 +123,7 @@ export const InterviewBudgetControl = ({ setOpen(false)} > diff --git a/libs/@hashintel/petrinaut/docs/ai-assistant.md b/libs/@hashintel/petrinaut/docs/ai-assistant.md index 834b7b92dd5..495f0646872 100644 --- a/libs/@hashintel/petrinaut/docs/ai-assistant.md +++ b/libs/@hashintel/petrinaut/docs/ai-assistant.md @@ -37,7 +37,7 @@ The header text is not selectable. Header icons animate on hover and click unles In the website, turn on **Use Brunch** in **Settings → Labs**, then enable **Interview length**. This experiment starts disabled: no length control or estimate appears, and Brunch uses its ordinary interview behaviour. Turning it off preserves your saved level for next time. -When enabled, the round icon beside Send opens **Interview length**. The same control appears in the Voice dock. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level and whether the experiment is enabled. +When enabled, the round icon at the left of the message input opens **Interview length** above it. Send or Voice stays at the right. The same control appears at the left of the Voice dock without increasing its height. Choose **Off**, **Quick · ~5 min**, **Standard · ~10 min** (the default), **Thorough · ~20 min**, or **Deep · no limit**. Click a stop name, drag the rail, or focus it and use the arrow keys. The browser remembers the level and whether the experiment is enabled. After the first reply, a quiet status sits at the right above the composer or Voice controls in the expanded conversation. It estimates time from questions left; it is not a countdown. The row stays blank before the first reply and when Off is selected, but keeps its space so the input controls do not move. The collapsed Voice dock omits this row entirely to stay compact; expand the conversation to see the estimate. Hover or focus the estimate for a card with the question count and closing behaviour. Quick, Standard and Thorough allow respectively 3, 6 and 10 replies in text, or 2, 4 and 7 in Voice. A grouped question or a confirmation-only reply counts once. The estimate progresses to **Last question**, then **Wrapping up**. Deep shows the running count and offers pauses; Off uses the ordinary interview without a budget. diff --git a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx index e2bd9f98a01..fadd4b2d957 100644 --- a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx +++ b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.test.tsx @@ -202,7 +202,11 @@ test("live-capability dock keeps microphone direct and Realtime controls absent" />, ); expect(screen.getByText("Connected")).toBeTruthy(); - expect(screen.getByRole("button", { name: "Interview budget" })).toBeTruthy(); + expect( + screen + .getByRole("button", { name: "Interview budget" }) + .closest('[data-part="left-actions"]'), + ).not.toBeNull(); const microphone = screen.getByRole("button", { name: "Mute microphone" }); expect(microphone).not.toBeNull(); expect(screen.queryByRole("button", { name: "Your turn" })).toBeNull(); @@ -3336,6 +3340,41 @@ describe("AiAssistantContents", () => { expect(control.nextElementSibling?.contains(sendButton)).toBe(true); }); + test.each([ + ["", "ready", "Start voice mode"], + ["Draft", "ready", "Send message"], + ["Draft", "streaming", "Stop AI response"], + ] as const)( + "keeps Brunch settings before the input with %s draft and %s status", + (input, status, actionLabel) => { + render( + Interview length} + input={input} + messages={[]} + onClose={noop} + onInputChange={noop} + onInputModeChange={noop} + onStop={noop} + onSubmit={noop} + presentation="brunch" + status={status} + voiceModeAvailable + />, + ); + const control = screen.getByRole("button", { name: "Interview length" }); + const textarea = screen.getByRole("textbox", { + name: "Message AI assistant", + }); + expect(control.nextElementSibling).toBe(textarea); + expect( + textarea.nextElementSibling?.contains( + screen.getByRole("button", { name: actionLabel }), + ), + ).toBe(true); + }, + ); + test("keeps one trailing Brunch composer action", () => { const onInputModeChange = vi.fn(); render( diff --git a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx index 8f7a3e4a79f..cdb4e4c012b 100644 --- a/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx +++ b/libs/@hashintel/petrinaut/src/ui/views/Editor/panels/ai-assistant-panel/ai-assistant-contents.tsx @@ -1802,6 +1802,7 @@ export const AiAssistantContents = ({ className={composerStyle} data-brunch={isBrunchChat || undefined} > + {isBrunchChat && composerControl}