Skip to content

Commit fa21e96

Browse files
httpsphlhttpsphl
authored
Merge pull request #211 from httpsphl/feat/catalog-engineering-roles
feat(catalog): eight engineering roles (G4, 3/4)
2 parents f8f9977 + 9ab9cc0 commit fa21e96

22 files changed

Lines changed: 562 additions & 15 deletions

‎app/src/features/catalog/agency.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ describe("the Bot agency", () => {
3333

3434
fireEvent.click(within(invite).getByRole("button", { name: "See all bots" }));
3535
const dialog = await screen.findByRole("dialog", { name: "Bot agency" });
36-
expect(await within(dialog).findAllByRole("listitem")).toHaveLength(44);
36+
expect(await within(dialog).findAllByRole("listitem")).toHaveLength(52);
3737
});
3838

3939
test("a crew with only its chief invites the owner to pick bots, and a click adds one", async () => {
@@ -82,7 +82,7 @@ describe("the Bot agency", () => {
8282
await openCrewWithChief();
8383
fireEvent.click(screen.getByRole("button", { name: "Bot agency" }));
8484
const dialog = await screen.findByRole("dialog", { name: "Bot agency" });
85-
expect(await within(dialog).findAllByRole("listitem")).toHaveLength(44);
85+
expect(await within(dialog).findAllByRole("listitem")).toHaveLength(52);
8686

8787
fireEvent.click(within(dialog).getByRole("button", { name: "Marketing & sales" }));
8888
expect(within(dialog).getAllByRole("listitem")).toHaveLength(18);
@@ -129,7 +129,7 @@ describe("the Bot agency", () => {
129129
expect(addCalls(fake)[0]).toMatchObject({ templateId: "code-reviewer" });
130130

131131
fireEvent.click(within(dialog).getByRole("button", { name: "Back to all bots" }));
132-
expect(within(dialog).getAllByRole("listitem")).toHaveLength(44);
132+
expect(within(dialog).getAllByRole("listitem")).toHaveLength(52);
133133
});
134134

135135
test("the same role twice gets another name", async () => {

‎app/src/i18n/en/catalog.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { base } from "./catalogBase";
2+
import { engineering } from "./catalogEngineering";
23
import { marketing } from "./catalogMarketing";
34
import { product } from "./catalogProduct";
45

@@ -46,5 +47,5 @@ export const catalog = {
4647
pairs: "Works well with",
4748
technical: "What the bot is told when it starts",
4849
},
49-
roles: { ...base, ...product, ...marketing },
50+
roles: { ...base, ...product, ...marketing, ...engineering },
5051
};

‎app/src/i18n/en/catalogEngineering.ts‎

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
// Engineering roles (spec 26.3): what the owner reads about each.
2+
3+
export const engineering = {
4+
"software-architect": {
5+
name: "Software Architect",
6+
role: "Designs how a system fits together and records the decisions, trade-offs and risks",
7+
summary: "Designs how the parts of a system fit together and writes down why",
8+
about:
9+
"Decides with you how a piece of software should be structured, picks the simplest design that meets your needs and writes down each important decision with its reasons, costs and risks. It designs; it does not write the product's code.",
10+
when: "Before you build something big, or when a system has become hard to change.",
11+
pairs:
12+
"Developer, Frontend, Backend and Mobile Developers, who build from the design, and Security Reviewer.",
13+
},
14+
"frontend-developer": {
15+
name: "Frontend Developer",
16+
role: "Builds and fixes the part of a site or app that people see and use, fast on a phone and usable by everyone",
17+
summary: "Builds the screens people use, fast on a phone and usable by everyone",
18+
about:
19+
"Builds and fixes pages, forms and menus, thinking about phones first, keyboards, screen readers and slow connections. It checks its work in a real browser and runs the project's tests.",
20+
when: "When a site or an app needs a new screen, or what exists is slow or confusing.",
21+
pairs: "Designer, who draws the screens, and Backend Developer, who provides the data.",
22+
},
23+
"backend-developer": {
24+
name: "Backend Developer",
25+
role: "Builds and fixes the server side: APIs, data handling, background jobs and their tests",
26+
summary: "Builds the part behind the screen: APIs, data and background jobs, with tests",
27+
about:
28+
"Builds and fixes what runs behind the screen: servers, APIs, data rules and jobs, with tests and with attention to what happens when something fails. It never runs changes against live data without asking you.",
29+
when: "When your product needs to save, process or share data, or connect to another service.",
30+
pairs: "Database Engineer, for the data, and Frontend Developer, who uses its APIs.",
31+
},
32+
"mobile-developer": {
33+
name: "Mobile Developer",
34+
role: "Builds and fixes phone apps and checks them on realistic screens, networks and devices",
35+
summary: "Builds and fixes phone apps, thinking about small screens, slow networks and battery",
36+
about:
37+
"Builds and fixes phone apps with small screens, bad networks, interruptions and permissions in mind. It tells you honestly what it could not test without a real device, and it never touches your store accounts or signing keys.",
38+
when: "When you want an app for phones, or the one you have is slow or crashes.",
39+
pairs: "Designer, for the screens, Backend Developer, for the API, and QA Tester.",
40+
},
41+
"database-engineer": {
42+
name: "Database Engineer",
43+
role: "Designs tables, writes and speeds up queries and plans safe changes to a database",
44+
summary: "Designs your database, makes queries fast and changes data without losing any",
45+
about:
46+
"Designs how your data is stored, makes slow queries fast by measuring first and plans every change so that it can be undone, with a backup first. It tests on a copy and never runs anything destructive on live data.",
47+
when: "When a database is slow, messy, or has to change without losing anything.",
48+
pairs: "Backend Developer, who applies the changes, and Data Engineer, who loads the data.",
49+
},
50+
"devops-engineer": {
51+
name: "DevOps Engineer",
52+
role: "Sets up builds, tests, deployments and monitoring, and keeps pipelines and servers healthy",
53+
summary: "Automates building, testing and shipping, and keeps it all running and watched",
54+
about:
55+
"Makes shipping software safe and boring: automatic builds and tests, repeatable deployments, logs and alerts, and a way back for each release. It asks before anything touches a live system and never asks you to paste passwords into the chat.",
56+
when: "When releasing is manual and scary, or something keeps breaking in production.",
57+
pairs:
58+
"Backend Developer, for what the service needs, and Security Reviewer, for access and secrets.",
59+
},
60+
"security-reviewer": {
61+
name: "Security Reviewer",
62+
role: "Reviews your own code and setup for security weaknesses and explains how to fix them",
63+
summary: "Looks for security holes in your own code and setup and explains how to fix them",
64+
about:
65+
"Reviews your own code and setup for weaknesses, explains each one in plain words with how serious it is and the smallest fix. It works defensively, only on what is yours, and never repeats a secret it finds. It thinks harder than most bots, so it uses a bit more of your plan.",
66+
when: "Before you launch, after a big change, or when you handle other people's data.",
67+
pairs: "Developer and DevOps Engineer, who apply the fixes, and Code Reviewer.",
68+
},
69+
"data-engineer": {
70+
name: "Data Engineer",
71+
role: "Builds reliable pipelines that move, clean and store data so that analysts can trust it",
72+
summary: "Builds the pipes that bring clean, trustworthy data to where you analyze it",
73+
about:
74+
"Builds the paths data takes from where it is created to where it is analyzed: it collects, cleans and checks it at every step and stops when something looks wrong instead of passing bad numbers on. It keeps your originals untouched.",
75+
when: "When your numbers live in many places or you cannot trust your reports.",
76+
pairs: "Database Engineer, for where to store it, and Data Analyst, who uses the result.",
77+
},
78+
};

‎app/src/i18n/es/catalog.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { Messages } from "../en";
22
import { base } from "./catalogBase";
3+
import { engineering } from "./catalogEngineering";
34
import { marketing } from "./catalogMarketing";
45
import { product } from "./catalogProduct";
56

@@ -43,5 +44,5 @@ export const catalog: Messages["catalog"] = {
4344
pairs: "Combina bien con",
4445
technical: "Lo que recibe el bot cuando empieza",
4546
},
46-
roles: { ...base, ...product, ...marketing },
47+
roles: { ...base, ...product, ...marketing, ...engineering },
4748
};

‎app/src/i18n/es/catalogEngineering.ts‎

Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
import type { engineering as en } from "../en/catalogEngineering";
2+
3+
export const engineering: typeof en = {
4+
"software-architect": {
5+
name: "Arquitecto de software",
6+
role: "Diseña cómo encaja un sistema y registra las decisiones, los intercambios y los riesgos",
7+
summary: "Diseña cómo encajan las partes de un sistema y escribe el porqué",
8+
about:
9+
"Decide contigo cómo debe estructurarse un software, elige el diseño más simple que cubre lo que necesitas y escribe cada decisión importante con sus motivos, costos y riesgos. Diseña; no escribe el código del producto.",
10+
when: "Antes de construir algo grande, o cuando un sistema se volvió difícil de cambiar.",
11+
pairs:
12+
"Desarrollador, Desarrollador front-end, back-end y móvil, que construyen a partir del diseño, y Revisor de seguridad.",
13+
},
14+
"frontend-developer": {
15+
name: "Desarrollador front-end",
16+
role: "Construye y arregla la parte de un sitio o app que la gente ve y usa, rápida en el móvil y usable por todos",
17+
summary: "Construye las pantallas que la gente usa, rápidas en el móvil y usables por todos",
18+
about:
19+
"Construye y arregla páginas, formularios y menús, pensando primero en el móvil, el teclado, los lectores de pantalla y las conexiones lentas. Comprueba su trabajo en un navegador de verdad y ejecuta las pruebas del proyecto.",
20+
when: "Cuando un sitio o una app necesita una pantalla nueva, o lo que existe es lento o confuso.",
21+
pairs: "Diseñador, que dibuja las pantallas, y Desarrollador back-end, que da los datos.",
22+
},
23+
"backend-developer": {
24+
name: "Desarrollador back-end",
25+
role: "Construye y arregla el lado del servidor: APIs, manejo de datos, tareas en segundo plano y sus pruebas",
26+
summary:
27+
"Construye la parte que está detrás de la pantalla: APIs, datos y tareas en segundo plano, con pruebas",
28+
about:
29+
"Construye y arregla lo que corre detrás de la pantalla: servidores, APIs, reglas sobre datos y tareas, con pruebas y con atención a lo que pasa cuando algo falla. Nunca ejecuta cambios en datos reales sin preguntarte.",
30+
when: "Cuando tu producto necesita guardar, procesar o compartir datos, o conectarse a otro servicio.",
31+
pairs:
32+
"Ingeniero de bases de datos, para los datos, y Desarrollador front-end, que usa las APIs.",
33+
},
34+
"mobile-developer": {
35+
name: "Desarrollador móvil",
36+
role: "Construye y arregla apps de móvil y las comprueba en pantallas, redes y dispositivos realistas",
37+
summary:
38+
"Construye y arregla apps de móvil, pensando en pantallas pequeñas, redes lentas y batería",
39+
about:
40+
"Construye y arregla apps de móvil pensando en pantallas pequeñas, redes malas, interrupciones y permisos. Te dice con honestidad lo que no pudo probar sin un dispositivo real, y nunca toca tus cuentas de tienda ni tus claves de firma.",
41+
when: "Cuando quieres una app para móviles, o la que tienes es lenta o se cierra sola.",
42+
pairs: "Diseñador, para las pantallas, Desarrollador back-end, para la API, y Tester.",
43+
},
44+
"database-engineer": {
45+
name: "Ingeniero de bases de datos",
46+
role: "Diseña tablas, escribe y acelera consultas y planifica cambios seguros en una base de datos",
47+
summary: "Diseña tu base de datos, hace rápidas las consultas y cambia datos sin perder nada",
48+
about:
49+
"Diseña cómo se guardan tus datos, acelera las consultas lentas midiendo antes y planifica cada cambio para poder deshacerlo, con copia de seguridad primero. Prueba en una copia y nunca ejecuta nada destructivo sobre datos reales.",
50+
when: "Cuando una base de datos está lenta, desordenada o tiene que cambiar sin perder nada.",
51+
pairs:
52+
"Desarrollador back-end, que aplica los cambios, e Ingeniero de datos, que carga los datos.",
53+
},
54+
"devops-engineer": {
55+
name: "Ingeniero DevOps",
56+
role: "Monta compilaciones, pruebas, despliegues y monitoreo, y mantiene sanos los procesos y los servidores",
57+
summary: "Automatiza compilar, probar y publicar, y mantiene todo funcionando y vigilado",
58+
about:
59+
"Hace que publicar software sea seguro y sin drama: compilaciones y pruebas automáticas, despliegues repetibles, registros y alertas, y una forma de volver atrás en cada versión. Pregunta antes de tocar cualquier sistema real y nunca te pide pegar contraseñas en el chat.",
60+
when: "Cuando publicar es manual y da miedo, o algo se rompe siempre en producción.",
61+
pairs:
62+
"Desarrollador back-end, para lo que el servicio necesita, y Revisor de seguridad, para accesos y secretos.",
63+
},
64+
"security-reviewer": {
65+
name: "Revisor de seguridad",
66+
role: "Revisa tu propio código y tu configuración en busca de fallos de seguridad y explica cómo corregirlos",
67+
summary: "Busca fallos de seguridad en tu código y tu configuración y explica cómo corregirlos",
68+
about:
69+
"Revisa tu código y tu configuración en busca de fallos, explica cada uno con palabras sencillas, su gravedad y la corrección más pequeña. Trabaja a la defensiva, solo sobre lo que es tuyo, y nunca repite un secreto que encuentre. Piensa más a fondo que la mayoría de los bots, así que gasta un poco más de tu plan.",
70+
when: "Antes de lanzar, después de un cambio grande, o cuando manejas datos de otras personas.",
71+
pairs: "Desarrollador e Ingeniero DevOps, que aplican las correcciones, y Revisor de código.",
72+
},
73+
"data-engineer": {
74+
name: "Ingeniero de datos",
75+
role: "Construye procesos fiables que mueven, limpian y guardan datos para que los analistas puedan confiar en ellos",
76+
summary: "Construye las tuberías que llevan datos limpios y fiables hasta donde los analizas",
77+
about:
78+
"Construye los caminos que recorren los datos desde donde nacen hasta donde se analizan: los recoge, limpia y comprueba en cada paso y se detiene cuando algo parece mal, en vez de pasar números malos. Mantiene tus originales intactos.",
79+
when: "Cuando tus números están en muchos sitios o no confías en tus informes.",
80+
pairs:
81+
"Ingeniero de bases de datos, para dónde guardar, y Analista de datos, que usa el resultado.",
82+
},
83+
};

‎app/src/i18n/pt-BR/catalog.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { Messages } from "../en";
22
import { base } from "./catalogBase";
3+
import { engineering } from "./catalogEngineering";
34
import { marketing } from "./catalogMarketing";
45
import { product } from "./catalogProduct";
56

@@ -43,5 +44,5 @@ export const catalog: Messages["catalog"] = {
4344
pairs: "Combina bem com",
4445
technical: "O que o bot recebe quando começa",
4546
},
46-
roles: { ...base, ...product, ...marketing },
47+
roles: { ...base, ...product, ...marketing, ...engineering },
4748
};

0 commit comments

Comments
 (0)