From eec93aedab155070917c3bfadedefd89d56dadac Mon Sep 17 00:00:00 2001 From: arena-agent <297053741+arena-agent@users.noreply.github.com> Date: Fri, 23 Oct 2026 07:52:54 +0000 Subject: [PATCH] fix(tests): stop test_clade_cumulus.jl pinning SV as a constant runtests.jl includes every test file into Main, so the files share one `SV` binding. Thirteen of them assign it plainly; test_clade_cumulus.jl (unit file 6 of 49) declared it `const`. In Julia 1.12.5 the next plain assignment -- unit file 14, test_validated_statistics.jl:4 -- then dies with invalid assignment to constant Main.SV outside any @test, which aborts the enclosing "MetaManifold" testset. Every file after that point stops running: the remaining 35 unit files, the occupancy disagreement experiment (included after the unit files), and the --integration and --server suites. CI on 8df1041 reports 835 tests; the last green run (2026-10-20) reported 2,967. The required `Occupancy disagreement test` context has been red since #207 for this reason -- the experiment it is named after never ran, and the `Validate measured occupancy grades` step was skipped every time. Drop the const, matching the other thirteen binding sites (this is also the rule test/occupancy_disagreement_test.jl documents for SV). No other top-level name is bound in more than one test file. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com> --- test/unit/test_clade_cumulus.jl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/unit/test_clade_cumulus.jl b/test/unit/test_clade_cumulus.jl index 6e12a0c9..4c416ab8 100644 --- a/test/unit/test_clade_cumulus.jl +++ b/test/unit/test_clade_cumulus.jl @@ -14,7 +14,14 @@ const EP = MetaManifold.Epistemic const CC = MetaManifold.CladeCumulus const DM = MetaManifold.DiversityMetrics const PH = MetaManifold.Phylogeny -const SV = MetaManifold.Server +# NOT const, unlike the four above: `runtests.jl` includes every test file into +# Main, so `SV` is one binding shared with the thirteen later test files +# (test_routes.jl, test_composition.jl, ...) that assign it plainly. Declaring +# it const here makes the first of them die with "invalid assignment to +# constant Main.SV", which aborts the whole MetaManifold testset -- so every +# file after this one, including the occupancy disagreement experiment, silently +# stops running. test/occupancy_disagreement_test.jl states the same rule. +SV = MetaManifold.Server _cc_req(method::String, path::String, body::String = "") = SV.Oxygen.internalrequest(