From fc60eb7917dd69abaaeb8a1682f6434bb9741b40 Mon Sep 17 00:00:00 2001 From: mkwasile Date: Tue, 9 Jun 2026 10:05:57 +0200 Subject: [PATCH] fix: set NDK PFC bandwidth to 50% per traffic class Update configure_pfc_ndk to distribute bandwidth equally (50/50) across both traffic classes instead of the previous 90/10 split. Update corresponding unit test assertion to match new values. Signed-off-by: Marek Wasilewski --- mfd_switchmanagement/vendors/dell/dell_os10/base.py | 2 +- .../test_vendors/test_dell/test_dell_os10/test_base.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mfd_switchmanagement/vendors/dell/dell_os10/base.py b/mfd_switchmanagement/vendors/dell/dell_os10/base.py index 5e098a2..5931bc1 100644 --- a/mfd_switchmanagement/vendors/dell/dell_os10/base.py +++ b/mfd_switchmanagement/vendors/dell/dell_os10/base.py @@ -1027,7 +1027,7 @@ def configure_pfc_ndk(self, port: str) -> None: :param port: port of switch """ - self.create_qos_policy([90, 10, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100") + self.create_qos_policy([50, 50, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100") self.set_port_bw_by_tc(port, suffix="100") self.set_port_pfc_by_tc(port, qos_priority=None, pfc="on") self.set_port_dcbx_version(port, mode="ieee") diff --git a/tests/unit/test_mfd_switchmanagement/test_vendors/test_dell/test_dell_os10/test_base.py b/tests/unit/test_mfd_switchmanagement/test_vendors/test_dell/test_dell_os10/test_base.py index 6e6dca5..31d0b37 100644 --- a/tests/unit/test_mfd_switchmanagement/test_vendors/test_dell/test_dell_os10/test_base.py +++ b/tests/unit/test_mfd_switchmanagement/test_vendors/test_dell/test_dell_os10/test_base.py @@ -1225,7 +1225,7 @@ def test_configure_pfc_ndk(self, switch, mocker): switch.configure_pfc_ndk(port) # Assert - switch.create_qos_policy.assert_called_once_with([90, 10, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100") + switch.create_qos_policy.assert_called_once_with([50, 50, 0, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], "100") switch.set_port_bw_by_tc.assert_called_once_with(port, suffix="100") switch.set_port_pfc_by_tc.assert_called_once_with(port, qos_priority=None, pfc="on") switch.set_port_dcbx_version.assert_called_once_with(port, mode="ieee")