From fb93123d7095027027596ee8eb165b4ddf219053 Mon Sep 17 00:00:00 2001 From: r-log Date: Mon, 3 Aug 2026 04:48:04 +0200 Subject: [PATCH 1/4] [CI] Restore dropped configure flags and let the compiler cache persist --- .github/workflows/core_linux_build.yml | 7 +++---- .github/workflows/core_windows_build.yml | 8 +++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/.github/workflows/core_linux_build.yml b/.github/workflows/core_linux_build.yml index 24161c65a..b8faef841 100644 --- a/.github/workflows/core_linux_build.yml +++ b/.github/workflows/core_linux_build.yml @@ -32,8 +32,7 @@ jobs: name: Build (${{ matrix.name }}) env: - BUILD_DIR: ${{ github.workspace }}/../build-${{ matrix.name }} - CCACHE_DIR: ${{ github.workspace }}/../ccache + BUILD_DIR: ${{ runner.temp }}/build-${{ matrix.name }} steps: - name: Checkout repository @@ -53,6 +52,8 @@ jobs: key: linux-${{ matrix.name }} max-size: 500M + # Never the socket tests: they bind real listeners and dominate the + # suite's wall-clock. A human asks for them, CI does not. - name: Configure run: > cmake -S . -B "$BUILD_DIR" -G Ninja @@ -67,8 +68,6 @@ jobs: -DBUILD_REALMD=1 -DBUILD_AH_SERVICE=1 -DWITH_TESTS=1 - # Never the socket tests: they bind real listeners and dominate the - # suite's wall-clock. A human asks for them, CI does not. -DWITH_NET_TESTS=0 -DSOAP=1 -DSCRIPT_LIB_ELUNA=1 diff --git a/.github/workflows/core_windows_build.yml b/.github/workflows/core_windows_build.yml index 2255196f4..1671f9e0e 100644 --- a/.github/workflows/core_windows_build.yml +++ b/.github/workflows/core_windows_build.yml @@ -22,9 +22,7 @@ jobs: runs-on: windows-2022 env: - BUILD_DIR: ${{ github.workspace }}\..\build-msvc - CCACHE_DIR: ${{ github.workspace }}\..\ccache - SCCACHE_DIR: ${{ github.workspace }}\..\sccache + BUILD_DIR: ${{ runner.temp }}\build-msvc steps: - name: Checkout repository @@ -109,6 +107,8 @@ jobs: key: windows-msvc max-size: 500M + # Never the socket tests: they bind real listeners and dominate the + # suite's wall-clock. A human asks for them, CI does not. - name: Configure shell: bash run: > @@ -123,8 +123,6 @@ jobs: -DBUILD_REALMD=1 -DBUILD_AH_SERVICE=1 -DWITH_TESTS=1 - # Never the socket tests: they bind real listeners and dominate the - # suite's wall-clock. A human asks for them, CI does not. -DWITH_NET_TESTS=0 -DSOAP=1 -DSCRIPT_LIB_ELUNA=1 From 5f66b2351f072c9170d477b112d96ca8a40a8ce8 Mon Sep 17 00:00:00 2001 From: r-log Date: Mon, 3 Aug 2026 04:48:28 +0200 Subject: [PATCH 2/4] [CI] Point OPENSSL_MODULES at the SlProWeb provider directory --- .github/workflows/core_windows_build.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/core_windows_build.yml b/.github/workflows/core_windows_build.yml index 1671f9e0e..05c11ae45 100644 --- a/.github/workflows/core_windows_build.yml +++ b/.github/workflows/core_windows_build.yml @@ -87,6 +87,9 @@ jobs: echo "OPENSSL_INCLUDE_DIR=$root/include" >> "$GITHUB_ENV" echo "OPENSSL_CRYPTO_LIBRARY=$root/lib/VC/libcrypto64MT.lib" >> "$GITHUB_ENV" echo "OPENSSL_SSL_LIBRARY=$root/lib/VC/libssl64MT.lib" >> "$GITHUB_ENV" + # SlProWeb installs provider DLLs beside openssl.exe, while its + # compiled MODULESDIR still names the default installation path. + echo "OPENSSL_MODULES=$root/bin" >> "$GITHUB_ENV" echo "$root/bin" >> "$GITHUB_PATH" else echo "::error::OpenSSL developer libraries not found" From b11b41a5b38c036d079101296e74207d41556d09 Mon Sep 17 00:00:00 2001 From: r-log Date: Mon, 3 Aug 2026 04:48:48 +0200 Subject: [PATCH 3/4] [Docs] Fix the CI workflow link in the README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bdb966f1b..e62d335dd 100644 --- a/README.md +++ b/README.md @@ -189,7 +189,7 @@ World of Warcraft, and all related art, images, and lore are copyright [Blizzard [7]: http://www.cppreference.com/ "C / C++ reference" [8]: https://github.com/mangos/MaNGOS/blob/master/mangosFamily.md "The MaNGOS family of Icons" [9]: https://discord.gg/fPxMjHS8xs "Our community hub on Discord" -[10]: https://github.com/mangoszero/server/actions/workflows/core_build.yml "Github Actions - Linux/MAC build status" +[10]: https://github.com/mangoszero/server/actions/workflows/core_linux_build.yml "Github Actions - Linux/MAC build status" [11]: https://ci.appveyor.com/project/MaNGOS/server-9fytl/history "AppVeyor Scan - Windows build status" [12]: https://app.codacy.com/gh/mangoszero/server/dashboard "Codacy Code Status" [13]: https://www.codefactor.io/repository/github/mangoszero/server "Codefactor Code Status" From bbc1a87ccae9fd6c5a9cc26f5e695ebe68326546 Mon Sep 17 00:00:00 2001 From: r-log Date: Mon, 3 Aug 2026 05:14:43 +0200 Subject: [PATCH 4/4] [CI] Keep BUILD_DIR on the github.workspace context The runner context is not available in jobs..env, so ${{ runner.temp }} there makes the whole workflow file invalid and GitHub refuses to run it. BUILD_DIR is never handed to actions/cache, so it does not need to avoid '..'; only CCACHE_DIR and SCCACHE_DIR did, and those stay removed. --- .github/workflows/core_linux_build.yml | 2 +- .github/workflows/core_windows_build.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/core_linux_build.yml b/.github/workflows/core_linux_build.yml index b8faef841..ead192a63 100644 --- a/.github/workflows/core_linux_build.yml +++ b/.github/workflows/core_linux_build.yml @@ -32,7 +32,7 @@ jobs: name: Build (${{ matrix.name }}) env: - BUILD_DIR: ${{ runner.temp }}/build-${{ matrix.name }} + BUILD_DIR: ${{ github.workspace }}/../build-${{ matrix.name }} steps: - name: Checkout repository diff --git a/.github/workflows/core_windows_build.yml b/.github/workflows/core_windows_build.yml index 05c11ae45..258b1e223 100644 --- a/.github/workflows/core_windows_build.yml +++ b/.github/workflows/core_windows_build.yml @@ -22,7 +22,7 @@ jobs: runs-on: windows-2022 env: - BUILD_DIR: ${{ runner.temp }}\build-msvc + BUILD_DIR: ${{ github.workspace }}\..\build-msvc steps: - name: Checkout repository