From 3adb7f10f0e9ccfc2eb34a02cd81a8e66d5c4ab5 Mon Sep 17 00:00:00 2001 From: Ramya-9353 Date: Fri, 3 Jul 2026 15:26:45 +0530 Subject: [PATCH 1/5] Fix GetProps buffer leak in OutputMessageMSG --- core/mapi/processor/dumpStore.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/core/mapi/processor/dumpStore.cpp b/core/mapi/processor/dumpStore.cpp index 0ef7d4f02..901bbed89 100644 --- a/core/mapi/processor/dumpStore.cpp +++ b/core/mapi/processor/dumpStore.cpp @@ -822,6 +822,8 @@ namespace mapi::processor WC_H_S(file::SaveToMSG(lpMessage, szFileName, fMapiUnicode != 0, nullptr, false)); } + MAPIFreeBuffer(lpsProps); + } bool dumpStore::BeginMessageWork( From 5b34547e7bc8af342278baa354ab76b0e4a7aab7 Mon Sep 17 00:00:00 2001 From: Ramya-9353 Date: Fri, 3 Jul 2026 16:00:55 +0530 Subject: [PATCH 2/5] Fix inverted email address validation in DoMailboxTablePerRowWork --- core/mapi/processor/dumpStore.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/mapi/processor/dumpStore.cpp b/core/mapi/processor/dumpStore.cpp index 901bbed89..0b784a86f 100644 --- a/core/mapi/processor/dumpStore.cpp +++ b/core/mapi/processor/dumpStore.cpp @@ -126,7 +126,7 @@ namespace mapi::processor output::OutputToFile(m_fMailboxTable, strings::LPCTSTRToWstring(lpDisplayName->Value.LPSZ)); } output::OutputToFile(m_fMailboxTable, L"\" premailaddress=\""); - if (!strings::CheckStringProp(lpEmailAddress, PT_TSTRING)) + if (strings::CheckStringProp(lpEmailAddress, PT_TSTRING)) { output::OutputToFile(m_fMailboxTable, strings::LPCTSTRToWstring(lpEmailAddress->Value.LPSZ)); } From 7c208299514f5324feb2e739540d5ff5615a1042 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 10 Jul 2026 18:07:17 +0000 Subject: [PATCH 3/5] Initial plan From 9f73605f7c76631c984661fa4ad3059d460baf6e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 10 Jul 2026 18:14:54 +0000 Subject: [PATCH 4/5] Remove extra blank line causing clang-format failure --- core/mapi/processor/dumpStore.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/core/mapi/processor/dumpStore.cpp b/core/mapi/processor/dumpStore.cpp index 0b784a86f..ef89e2369 100644 --- a/core/mapi/processor/dumpStore.cpp +++ b/core/mapi/processor/dumpStore.cpp @@ -823,7 +823,6 @@ namespace mapi::processor WC_H_S(file::SaveToMSG(lpMessage, szFileName, fMapiUnicode != 0, nullptr, false)); } MAPIFreeBuffer(lpsProps); - } bool dumpStore::BeginMessageWork( From 783fa5bc66fa0d3e85d834f9a7b31538146eec28 Mon Sep 17 00:00:00 2001 From: Stephen Griffin Date: Fri, 10 Jul 2026 14:41:26 -0400 Subject: [PATCH 5/5] Fix formatting in dumpStore.cpp --- core/mapi/processor/dumpStore.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/mapi/processor/dumpStore.cpp b/core/mapi/processor/dumpStore.cpp index ef89e2369..8fe9279d9 100644 --- a/core/mapi/processor/dumpStore.cpp +++ b/core/mapi/processor/dumpStore.cpp @@ -822,6 +822,7 @@ namespace mapi::processor WC_H_S(file::SaveToMSG(lpMessage, szFileName, fMapiUnicode != 0, nullptr, false)); } + MAPIFreeBuffer(lpsProps); } @@ -1005,4 +1006,4 @@ namespace mapi::processor delete lpMsgData; } } -} // namespace mapi::processor \ No newline at end of file +} // namespace mapi::processor