From 1ccfc481a9a19275f7a6458f9f76d471eb500963 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 24 Jun 2026 09:23:05 +0200 Subject: [PATCH 1/3] chore(git-node): clarify prompt message in promotion script --- lib/promote_release.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/promote_release.js b/lib/promote_release.js index a3b39e63..59cf293b 100644 --- a/lib/promote_release.js +++ b/lib/promote_release.js @@ -542,7 +542,7 @@ export default class ReleasePromotion extends Session { if (modifiedFiles.some(file => !file.endsWith('.md'))) { cli.warn('Some modified files are not markdown, that\'s unusual.'); cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`); - if (await cli.prompt('Consider amending the commit before continuing. Ready to continue?', { + if (await cli.prompt('Consider amending the commit. Ignore and continue anyway?', { defaultAnswer: false })) { break; From d212661b76cc547f455d453aba27ed2b48f60c99 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 24 Jun 2026 10:46:46 +0200 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Antoine du Hamel --- lib/promote_release.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/promote_release.js b/lib/promote_release.js index 59cf293b..a6941375 100644 --- a/lib/promote_release.js +++ b/lib/promote_release.js @@ -540,9 +540,9 @@ export default class ReleasePromotion extends Session { const [commitTitle, ...modifiedFiles] = releaseCommitOnDefaultBranch.trim().split('\n'); await this.validateReleaseCommit(commitTitle); if (modifiedFiles.some(file => !file.endsWith('.md'))) { - cli.warn('Some modified files are not markdown, that\'s unusual.'); + cli.warn('Some modified files are not markdown, that\'s unusual. Consider amending the commit.'); cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`); - if (await cli.prompt('Consider amending the commit. Ignore and continue anyway?', { + if (await cli.prompt('Ignore and continue anyway?', { defaultAnswer: false })) { break; From f5b31f7ab4f9606f28d6a7570dd3d6d3065c6ad8 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 24 Jun 2026 14:22:19 +0200 Subject: [PATCH 3/3] Apply suggestion from @aduh95 --- lib/promote_release.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/promote_release.js b/lib/promote_release.js index a6941375..49b44ef2 100644 --- a/lib/promote_release.js +++ b/lib/promote_release.js @@ -540,7 +540,9 @@ export default class ReleasePromotion extends Session { const [commitTitle, ...modifiedFiles] = releaseCommitOnDefaultBranch.trim().split('\n'); await this.validateReleaseCommit(commitTitle); if (modifiedFiles.some(file => !file.endsWith('.md'))) { - cli.warn('Some modified files are not markdown, that\'s unusual. Consider amending the commit.'); + cli.warn( + 'Some modified files are not markdown, that\'s unusual. Consider amending the commit.' + ); cli.info(`The list of modified files: ${modifiedFiles.map(f => `- ${f}`).join('\n')}`); if (await cli.prompt('Ignore and continue anyway?', { defaultAnswer: false