fix(lint): clear clang-tidy warnings in authored code

Give small enums an explicit uint8_t base, drop misplaced const on
Win32 handle typedefs, add override/nullptr in PreferencesDialog and
DockedEditor, and NOLINT the CREATE_SETTING statics. README notes
Anthropic LLM, tree-folder AI spawn, and dock-tab close.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: nullmastermind

README.md

@@ -8,9 +8,9 @@ You shouldn't have to leave your editor to talk to an AI, run git, or open a she
 
 ### AI agents
 
-NotepadAI speaks the Agent Client Protocol (ACP) over stdio. Claude Code and Codex are built in. Add any other ACP-compatible agent — Gemini, Auggie, or your own command — from Settings. Agents read and write files, run terminal commands, and see your workspace context, so they work on the same code you do.
+NotepadAI speaks the Agent Client Protocol (ACP) over stdio. Claude Code and Codex are built in. Add any other ACP-compatible agent — Gemini, Auggie, or your own command — from Settings. Agents read and write files, run terminal commands, and see your workspace context, so they work on the same code you do. Start a session from the AI menu or by right-clicking a folder in the file tree.
 
-There's also a Goal Agent: pick an ACP judge (Claude Code, Codex, Opencode) or a Custom API endpoint that speaks Anthropic's Messages API. You set success criteria and it drives the working agent until they hold. And when you commit, AI can write the commit message from your staged diff. The protocol details and how to wire up a custom ACP agent are in [doc/AcpAgents.md](doc/AcpAgents.md).
+There's also a Goal Agent: pick an ACP judge (Claude Code, Codex, Opencode) or a Custom API endpoint that speaks Anthropic's Messages API. You set success criteria and it drives the working agent until they hold. And when you commit, AI can write the commit message from your staged diff — that generator (and other LLM calls) can talk to an OpenAI-compatible endpoint or Anthropic's Messages API. The protocol details and how to wire up a custom ACP agent are in [doc/AcpAgents.md](doc/AcpAgents.md).
 
 ### Git, built in
 
@@ -22,7 +22,7 @@ A full PTY terminal built on libvterm and libptyqt, with mouse reporting and a s
 
 ### The editor itself
 
-It's still Notepad++ at heart: a tabbed, splittable interface (Qt Advanced Docking System) with syntax highlighting for 80+ languages through vendored Scintilla and Lexilla. Macro recording and playback, session management, and an embedded Lua scripting layer are all here. If you're coming from Notepad++, it imports your config and sessions. There's also an editor minimap, live preview for Markdown and HTML, and a find-in-folder search that scans workspace directories with regex support.
+It's still Notepad++ at heart: a tabbed, splittable interface (Qt Advanced Docking System) with syntax highlighting for 80+ languages through vendored Scintilla and Lexilla. Right-click a panel tab to close it or its neighbors. Macro recording and playback, session management, and an embedded Lua scripting layer are all here. If you're coming from Notepad++, it imports your config and sessions. There's also an editor minimap, live preview for Markdown and HTML, and a find-in-folder search that scans workspace directories with regex support.
 
 ### Extras worth knowing
 

src/ApplicationSettings.cpp

@@ -42,6 +42,11 @@ ApplicationSettings::ApplicationSettings(QObject *parent)
 {
 }
 
+// File-scope ApplicationSetting<T> objects and by-value QString setters are the
+// established CREATE_SETTING shape. QString's constructor is not noexcept, and
+// the setter copies — neither is a hot path (settings load once / write on
+// change). NOLINT covers the whole expansion rather than rewriting the macro.
+// NOLINTBEGIN(bugprone-throwing-static-initialization,performance-unnecessary-value-param)
 CREATE_SETTING(Gui, ShowMenuBar, showMenuBar, bool, true)
 CREATE_SETTING(Gui, ShowToolBar, showToolBar, bool, true)
 CREATE_SETTING(Gui, ShowTabBar, showTabBar, bool, true)
@@ -169,11 +174,6 @@ static QString defaultCommitMessagePromptTemplate()
         "```\n");
 }
 
-// CREATE_SETTING expands to a by-value QString setter, matching the existing
-// project idiom used by every other QString setting above. Suppressed here so
-// we don't drift from the established macro pattern (changing the macro is
-// out of scope and would noisily diff every preexisting QString setting).
-// NOLINTBEGIN(performance-unnecessary-value-param)
 CREATE_SETTING(Ai, CommitMessageProviderUrl, commitMessageProviderUrl, QString, QStringLiteral(""))
 CREATE_SETTING(Ai, CommitMessageModel, commitMessageModel, QString, QStringLiteral(""))
 CREATE_SETTING(Ai, CommitMessageApiFormat, commitMessageApiFormat, ApplicationSettings::AiApiFormatEnum, ApplicationSettings::OpenAiCompatible)
@@ -185,9 +185,9 @@ CREATE_SETTING(Ai, CommitMessageDiffByteBudget, commitMessageDiffByteBudget, int
 CREATE_SETTING(Ai, CommitMessageRulesByteBudget, commitMessageRulesByteBudget, int, 4000)
 CREATE_SETTING(Ai, CommitMessageStreamIdleTimeoutSec, commitMessageStreamIdleTimeoutSec, int, 60)
 CREATE_SETTING(Ai, CommitMessageGenerateShortcut, commitMessageGenerateShortcut, QString, QStringLiteral("Ctrl+Alt+G"))
-// NOLINTEND(performance-unnecessary-value-param)
 
 CREATE_SETTING(Ai, SyncWorkspaceOnAiSwitch, syncWorkspaceOnAiSwitch, bool, true)
+// NOLINTEND(bugprone-throwing-static-initialization,performance-unnecessary-value-param)
 
 // --- AI / ACP agent settings ---------------------------------------------------
 //

src/ApplicationSettings.h

@@ -70,7 +70,7 @@ class ApplicationSettings : public QSettings
 public:
     explicit ApplicationSettings(QObject *parent = nullptr);
 
-    enum DefaultDirectoryBehaviorEnum {
+    enum DefaultDirectoryBehaviorEnum : std::uint8_t {
         FollowCurrentDocument,
         RememberLastUsed,
         HardCoded

src/DockedEditor.cpp

@@ -56,7 +56,7 @@ int centerTabMaxWidth(const QWidget *tab)
 class DockedEditorComponentsFactory : public ads::CDockComponentsFactory
 {
 public:
-    ads::CDockAreaTitleBar* createDockAreaTitleBar(ads::CDockAreaWidget* DockArea) const {
+    ads::CDockAreaTitleBar* createDockAreaTitleBar(ads::CDockAreaWidget* DockArea) const override {
         DockedEditorTitleBar *titleBar = new DockedEditorTitleBar(DockArea);
 
         // Disable the built in context menu for the title bar since it has options we don't want

src/EmbeddedWindowController.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 #include <QList>
 #include <QObject>
 #include <QString>
@@ -64,7 +66,7 @@ class EmbeddedWindowController : public QObject
     void allEmbedsReleased();
 
 protected:
-    enum class ReleaseMode { RestoreExact, FailSafeDetach };
+    enum class ReleaseMode : std::uint8_t { RestoreExact, FailSafeDetach };
 
     struct Embed {
         quintptr token = 0;

src/EmbeddedWindowWin32.cpp

@@ -23,7 +23,7 @@ bool setLong(HWND hwnd, int index, LONG_PTR value)
 bool setParent(HWND hwnd, HWND parent)
 {
     SetLastError(ERROR_SUCCESS);
-    const HWND previous = SetParent(hwnd, parent);
+    HWND previous = SetParent(hwnd, parent);
     return previous != nullptr || GetLastError() == ERROR_SUCCESS;
 }
 
@@ -174,7 +174,7 @@ bool restoreExact(const NativeWindowState &s, quintptr token)
         MapWindowPoints(HWND_DESKTOP, reinterpret_cast<HWND>(s.originalParent),
                         reinterpret_cast<POINT *>(&rect), 2);
     if (sameWindow(s, token)) {
-        const HWND z = (s.originalExStyle & WS_EX_TOPMOST) ? HWND_TOPMOST : HWND_NOTOPMOST;
+        HWND z = (s.originalExStyle & WS_EX_TOPMOST) ? HWND_TOPMOST : HWND_NOTOPMOST;
         SetWindowPos(hwnd, z, rect.left, rect.top, rect.right - rect.left,
                      rect.bottom - rect.top, SWP_NOACTIVATE | SWP_FRAMECHANGED);
     }
@@ -248,7 +248,7 @@ SyncResult syncGeometry(quintptr targetHandle, quintptr hostHandle, quintptr tok
 #ifdef Q_OS_WIN
     HWND target = reinterpret_cast<HWND>(targetHandle);
     HWND host = reinterpret_cast<HWND>(hostHandle);
-    const HANDLE mark = reinterpret_cast<HANDLE>(token);
+    HANDLE mark = reinterpret_cast<HANDLE>(token);
     const auto ownsTarget = [target, mark]() {
         return IsWindow(target) && GetPropW(target, EmbedPropertyName) == mark;
     };

src/EmbeddedWindowWin32.h

@@ -7,6 +7,8 @@
 
 #pragma once
 
+#include <cstdint>
+
 #include <QList>
 #include <QString>
 #include <QtGlobal>
@@ -56,7 +58,7 @@ struct NativeWindowState {
 };
 
 // Result of re-syncing the foreign child's geometry to its host client area.
-enum class SyncResult {
+enum class SyncResult : std::uint8_t {
     Ok,             // reparented (if asked) and resized successfully
     TransientError, // a Win32 call failed but the window still looks alive
     WindowLost,     // the window is gone or the token no longer matches

src/PendingCloseState.h

@@ -7,13 +7,15 @@
 
 #pragma once
 
+#include <cstdint>
+
 // Tiny, allocation-free state machine shared by MainWindow and unit tests.
 // It guarantees one outstanding close intent, at most one queued retry, and
 // exactly-once acceptance (notably exactly one restart process launch).
 class PendingCloseState
 {
 public:
-    enum class Intent { None, Exit, Restart };
+    enum class Intent : std::uint8_t { None, Exit, Restart };
 
     void begin(Intent intent)
     {

src/dialogs/MainWindow.h

@@ -20,6 +20,8 @@
 #ifndef MAINWINDOW_H
 #define MAINWINDOW_H
 
+#include <cstdint>
+
 #include <QMainWindow>
 #include <QLabel>
 #include <QActionGroup>
@@ -301,7 +303,7 @@ private slots:
     // Persist a single snapshot (mid-session dock close path).
     void persistOneWorkspaceState(const WorkspaceStateSnapshot &snapshot) const;
 
-    enum class UserSaveAction { SaveAll, DiscardAll, Cancel };
+    enum class UserSaveAction : std::uint8_t { SaveAll, DiscardAll, Cancel };
     UserSaveAction promptForSave(const QVector<ScintillaNext *> &editors);
 
     void saveSettings() const;

src/dialogs/PreferencesDialog.h

@@ -38,8 +38,8 @@ class PreferencesDialog : public QDialog
     Q_OBJECT
 
 public:
-    PreferencesDialog(ApplicationSettings *settings, QWidget *parent = 0);
-    ~PreferencesDialog();
+    PreferencesDialog(ApplicationSettings *settings, QWidget *parent = nullptr);
+    ~PreferencesDialog() override;
 
     void showApplicationRestartRequired() const;