From 291d6c8728d7cab082e6cd1e8bae7e11042eb0bb Mon Sep 17 00:00:00 2001
From: amirahrari <ahrariamir@proton.me>
Date: Sat, 10 Oct 2026 19:27:49 +0330
Subject: [PATCH] fix: wait for the sidebar resource before rendering the
 shares panel

On a fresh load of the Spaces page, the space's graph permissions are not
loaded yet, so FileSideBar awaits them before setting the sidebar resource.
The panels stay mounted under the loading overlay during that wait, so
opening the members panel from a space tile rendered SpaceMembers with a
null resource and crashed in canShare. Show the loader until the resource
is set.

Fixes #3574
---
 .../src/components/SideBar/Shares/SharesPanel.vue   |  8 +++++++-
 .../components/SideBar/Shares/SharesPanel.spec.ts   | 13 ++++++++++++-
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Shares/SharesPanel.vue b/packages/web-app-files/src/components/SideBar/Shares/SharesPanel.vue
index 8d1ec9890e7..9df1d35bf75 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/SharesPanel.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/SharesPanel.vue
@@ -1,6 +1,6 @@
 <template>
   <div>
-    <oc-loader v-if="sharesLoading" :aria-label="$gettext('Loading list of shares')" />
+    <oc-loader v-if="sharesLoading || !resource" :aria-label="$gettext('Loading list of shares')" />
     <template v-else>
       <space-members v-if="showSpaceMembers" class="px-2 py-2" />
       <file-shares v-else class="px-2 py-2" />
@@ -14,13 +14,19 @@ import FileLinks from './FileLinks.vue'
 import FileShares from './FileShares.vue'
 import SpaceMembers from './SpaceMembers.vue'
 import { useSharesStore } from '@opencloud-eu/web-pkg'
+import { Resource } from '@opencloud-eu/web-client'
 import { storeToRefs } from 'pinia'
+import { inject, Ref } from 'vue'
 
 const { showSpaceMembers = false, showLinks = false } = defineProps<{
   showSpaceMembers?: boolean
   showLinks?: boolean
 }>()
 
+// the sidebar resource is null while it is still loading, e.g. when the space's
+// permissions are fetched first, and the panels below require it
+const resource = inject<Ref<Resource>>('resource')
+
 const sharesStore = useSharesStore()
 const { loading: sharesLoading } = storeToRefs(sharesStore)
 </script>
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/SharesPanel.spec.ts b/packages/web-app-files/tests/unit/components/SideBar/Shares/SharesPanel.spec.ts
index d528cf8c6b8..a17cbf5fa7d 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Shares/SharesPanel.spec.ts
+++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/SharesPanel.spec.ts
@@ -1,5 +1,6 @@
 import SharesPanel from '../../../../../src/components/SideBar/Shares/SharesPanel.vue'
 import { defaultPlugins, shallowMount } from '@opencloud-eu/web-test-helpers'
+import { ref } from 'vue'
 
 const ocLoaderStubSelector = 'oc-loader-stub'
 
@@ -21,9 +22,18 @@ describe('SharesPanel', () => {
     })
   })
 
-  function getWrapper({ sharesLoading = false } = {}) {
+  describe('when the sidebar resource is not loaded yet', () => {
+    it('should show the oc loader instead of the panels', () => {
+      const { wrapper } = getWrapper({ resource: null, showSpaceMembers: true })
+      expect(wrapper.find(ocLoaderStubSelector).exists()).toBeTruthy()
+      expect(wrapper.find('space-members-stub').exists()).toBeFalsy()
+    })
+  })
+
+  function getWrapper({ sharesLoading = false, resource = {}, showSpaceMembers = false } = {}) {
     return {
       wrapper: shallowMount(SharesPanel, {
+        props: { showSpaceMembers },
         global: {
           plugins: [
             ...defaultPlugins({ piniaOptions: { sharesState: { loading: sharesLoading } } })
@@ -31,6 +41,7 @@ describe('SharesPanel', () => {
           provide: {
             displayedItem: {},
             displayedSpace: {},
+            resource: ref(resource),
             spaceMembers: { value: [] }
           }
         }