Skip to content

File deletions during sy watch --hot mode crash the session #50

Description

@WolfGreyDev

When deleting files while running in sy watch --hot, the watch session crashes with a TypeError related to object conversion.

Error Details

┌─ Liquid ➤ Snippets ~ 14:42:57
│
│  changed    »  source/snippets/delete-this-snippet.liquid ~ 1 change
│
│  TYPE ERROR
│
│  Cannot convert undefined or null to object
│
│  ➔ at Function.assign (<anonymous>)
│  ➔ at graph (~/Sites/packages/syncify/dist/syncify.js:14048:47)
│  ➔ at ~/Sites/packages/syncify/dist/syncify.js:14303:49
│
│  name:    TypeError
│  graph:   OnlineStoreThemeFileOperationResult
│  detail:  POSSIBLY INTERNAL
│
└─ Liquid ➤ Snippets ~ 14:42:58

Steps to Reproduce

  1. Run watch session with sy watch --hot
  2. Delete a Liquid template file (e.g. delete-this-snippet.liquid)
  3. Watch session crash

Expected behavior

  • The watch session should handle file deletions gracefully in hot-reload mode without crashing.
  • The file should be removed from the connected Shopify theme

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    unstableAny issue that relates to the unstable/next branch

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions