From 12856654197ed0bbf50851a35dcc1cca8943ea92 Mon Sep 17 00:00:00 2001 From: meh Date: Fri, 21 Aug 2026 03:14:50 +0700 Subject: [PATCH] build: take tauri-runtime-blitz by version too It was the last git dependency, and the only reason it was one is that the crate could not be published: it set publish = false, it carried a [patch] redirecting usvg at a git branch, and its macos-private-api feature forwarded nothing, so --all-features left the runtime impl carrying a WindowBuilder method the trait did not declare. crates.io verifies with every feature on, so that last one failed to package for the same reason it failed to check. All three are fixed upstream and 0.1.0 is published, along with blitz-control-protocol. Cargo.lock now has no git sources at all. --- AGENTS.md | 14 ++++---------- Cargo.lock | 6 ++++-- Cargo.toml | 2 +- 3 files changed, 9 insertions(+), 13 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index b7b4631..48dc567 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -25,13 +25,8 @@ Do not reach for `rev` or `=` either: a git revision cannot be published and an exact pin is a range of one, so both split the graph the same way. A git `endpoint-libs` alongside the registry copy is precisely how this repository - ended up with two of it. -- **`tauri-runtime-blitz` is the one exception, and it is temporary.** It is - still a git dependency with a `rev` because the crate sets `publish = false` - and depends on a patched `usvg` for `Tree::intrinsic_dimensions`; crates.io - rejects anything with a git dependency. `ps-usvg` is published now, so the - path forward is to repoint it there, drop `publish = false`, release, and - bring this one to a caret with the rest. + ended up with two of it. There are no exceptions left: `tauri-runtime-blitz` + was the last git dependency, and it is `^0.1.0` from crates.io like the rest. - **Building against a working checkout is opt-in and never edits a tracked file.** Put the `[patch]` tables in `.cargo/local-engine.toml`, which is gitignored, and reach for them per command: @@ -42,9 +37,8 @@ - When you move the engine version, move `tauri-runtime-blitz`'s to match. Both resolve a ps-blitz, and two different ones put two engines in the graph, which surfaces as missing methods and unrelated `PaintScene` traits rather than as a - version error. This is why the exception above is worth closing: a caret on - both sides makes the shared range the thing that keeps them equal, instead of - a revision someone has to remember to move twice. + version error. A caret on both sides makes the shared range the thing that + keeps them equal, instead of a revision someone has to remember to move twice. - Work on a branch and ship through a pull request. Do not commit to `main`. - Run `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets --all-features -- -D warnings`, and `cargo test --workspace --all-features` before delivery. diff --git a/Cargo.lock b/Cargo.lock index a43daee..ce99e29 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -427,7 +427,8 @@ checksum = "6099cdc01846bc367c4e7dd630dc5966dccf36b652fae7a74e17b640411a91b2" [[package]] name = "blitz-control-protocol" version = "0.1.0" -source = "git+https://github.com/pathscale/tauri-runtime-blitz.git?rev=330cbb0963f93f5be85771cabad7fa73117535ab#330cbb0963f93f5be85771cabad7fa73117535ab" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8eca443ea23955ca693e482cb00f2051b47c6ca18aad324340aff8c6127eacff" dependencies = [ "endpoint-libs", "serde", @@ -7199,7 +7200,8 @@ dependencies = [ [[package]] name = "tauri-runtime-blitz" version = "0.1.0" -source = "git+https://github.com/pathscale/tauri-runtime-blitz.git?rev=330cbb0963f93f5be85771cabad7fa73117535ab#330cbb0963f93f5be85771cabad7fa73117535ab" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9faa026183d612fbd9fd0a869ab91932a41226158b4786274ca216c60ab805ad" dependencies = [ "blitz-control-protocol", "endpoint-libs", diff --git a/Cargo.toml b/Cargo.toml index 2b721f6..983bf78 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -106,7 +106,7 @@ tauri = { version = "^2.11.5", default-features = false } # explaining. A window that would not paint could not be photographed by the # one thing that could photograph it, because the capability had been optimised # out of the binary that needed it. -tauri-runtime-blitz = { git = "https://github.com/pathscale/tauri-runtime-blitz.git", rev = "330cbb0963f93f5be85771cabad7fa73117535ab", features = ["diagnostics"] } +tauri-runtime-blitz = { version = "^0.1.0", features = ["diagnostics"] } [profile.release] lto = "thin"