Merge pull request #219 from simon-mundy/qa/mago-sql-column-reference-cast

Drop the redundant isIdentifier cast in resolveColumnValue()

Author: simon-mundy

analyzer-baseline.toml

@@ -1842,12 +1842,6 @@ code = "possibly-undefined-string-array-index"
 message = 'Possibly undefined array key `string` accessed on `non-empty-array<string, PhpDb\Sql\Expression|PhpDb\Sql\Select|PhpDb\Sql\TableIdentifier|string>`.'
 count = 1
 
-[[issues]]
-file = "src/Sql/AbstractSql.php"
-code = "redundant-cast"
-message = "Redundant cast to `(bool)`: the expression already has this type."
-count = 1
-
 [[issues]]
 file = "src/Sql/AbstractSql.php"
 code = "redundant-cast"

src/Sql/AbstractSql.php

@@ -443,7 +443,7 @@ protected function resolveColumnValue(
         $isIdentifier = false;
         $fromTable    = '';
         if (is_array($column)) {
-            $isIdentifier = (bool) ($column['isIdentifier'] ?? false);
+            $isIdentifier = $column['isIdentifier'] ?? false;
             $fromTable    = $column['fromTable'] ?? '';
             $column       = $column['column'];
         }