Are patches really needed?

[jlombera]

I just stumbled upon this project and was curios about the use of patches.
If everything is going to be commits and code comments, and email is out of the picture, why are patches even needed?

You can just git push/fetch the changes and let pr handle just the PR related logic, but no need to handle the patches/commits itself. To make this really functional and easy to use for users, a client-side pr should be available, so that users don't have to concern with SSH commands nor other details themselves. E.g.:

# Create a new PR
# It will git-push the changes and then tell pr in the server side to
# create the new PR and the commits involved in it.
# If there are reasons no to use push/fetch, git-bundle(1)'s can be
# sent/received instead, but no need to use git-format-patch(1)'es.
$ pr create <name> <refspec>

# List status of PRs
# They can be filtered by status (open, accepted, merged, etc), by author, etc
$ pr list [<filters>]

# Get more info of a PR
# PR ID can be the name or a number auto-generated when it was created
$ pr info <ID>

# Fetch a PR
# Can be as simple as `git fetch <PR_branch>`; or
$ pr fetch <ID>

# Upload a review
$ pr add review <ID> <refspec>

$ pr accept <ID>
$ pr close <ID>
...

[neurosnap]

Hi, the entire idea behind git-pr is that it doesn't require any extra tooling like a locally installed cli tool. This means we have to live within the limitations of what git and ssh provide.

I'm not against a convenience cli tool that is a wrapper around the core dev loop, but that would be a user-land contribution that is not required.