Skip to content

Fix extract_tileset in captions.util #234

Description

@schrum2

The extract_tileset function has some code that behaves distinctively based on whether "MM" is part of the filename. Digging through the history indicates that this was a kludge meant to distinguish the behavior of Mega Man tilesets from others, but it became a problem when Mario Maker 2 (MM2) was introduced. It looks like Patrick continued to solve this with another kludge, but since I am rearranging the directory structure, it is finally time to fix this.

Is the special case for Mega Man really needed? It would be nice if I could just remove it. Changing it would probably invalidate past datasets, but might behave fine moving forward.

If I need to maintain special behavior, then I should probably change extract_tileset to take a game parameter instead of just a tileset path, but this function is called in many places, so that could cause problems.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions