From 5066cda3b7079339ba27b77f8d10b7ce46da19b6 Mon Sep 17 00:00:00 2001 From: ashb155 Date: Fri, 11 Sep 2026 00:35:46 +0530 Subject: [PATCH] additional i18n integrations --- app/src/main/assets/i18n | 2 +- app/src/main/java/be/scri/helpers/ui/RatingHelper.kt | 7 ++++++- .../java/be/scri/ui/common/appcomponents/HintDialog.kt | 2 +- app/src/main/java/be/scri/ui/screens/ConjugateScreen.kt | 2 +- .../java/be/scri/ui/screens/ConjugationSelectionScreen.kt | 2 +- .../java/be/scri/ui/screens/tutorial/TutorialHomeScreen.kt | 2 +- app/src/main/res/values/string.xml | 3 +++ 7 files changed, 14 insertions(+), 6 deletions(-) diff --git a/app/src/main/assets/i18n b/app/src/main/assets/i18n index 77247daea..faf95460a 160000 --- a/app/src/main/assets/i18n +++ b/app/src/main/assets/i18n @@ -1 +1 @@ -Subproject commit 77247daeaa90eea2e7a0ac4e285986a1c01822ff +Subproject commit faf95460a83758bcf1f42eaf25e026218e3a38e0 diff --git a/app/src/main/java/be/scri/helpers/ui/RatingHelper.kt b/app/src/main/java/be/scri/helpers/ui/RatingHelper.kt index 96b6bc117..a916a654d 100644 --- a/app/src/main/java/be/scri/helpers/ui/RatingHelper.kt +++ b/app/src/main/java/be/scri/helpers/ui/RatingHelper.kt @@ -84,7 +84,12 @@ object RatingHelper { try { context.startActivity(intent) } catch (e: ActivityNotFoundException) { - Toast.makeText(context, "No browser found to open $storeName page", Toast.LENGTH_SHORT).show() + Toast + .makeText( + context, + context.getString(R.string.i18n_app_about_feedback_no_browser_found).replace("{store}", storeName), + Toast.LENGTH_SHORT, + ).show() Log.e("RatingHelper", "Unable to open $storeName link", e) } } diff --git a/app/src/main/java/be/scri/ui/common/appcomponents/HintDialog.kt b/app/src/main/java/be/scri/ui/common/appcomponents/HintDialog.kt index e936879ff..75ad7e05e 100644 --- a/app/src/main/java/be/scri/ui/common/appcomponents/HintDialog.kt +++ b/app/src/main/java/be/scri/ui/common/appcomponents/HintDialog.kt @@ -197,7 +197,7 @@ fun HintDialogContent( shape = RoundedCornerShape(8.dp), ) { Text( - text = "OK", + text = stringResource(R.string.i18n_app_settings_option_ok), style = MaterialTheme.typography.headlineMedium, modifier = Modifier, ) diff --git a/app/src/main/java/be/scri/ui/screens/ConjugateScreen.kt b/app/src/main/java/be/scri/ui/screens/ConjugateScreen.kt index f060ad94d..8c924ad19 100644 --- a/app/src/main/java/be/scri/ui/screens/ConjugateScreen.kt +++ b/app/src/main/java/be/scri/ui/screens/ConjugateScreen.kt @@ -434,7 +434,7 @@ fun ConjugateScreen( verticalAlignment = Alignment.CenterVertically, ) { Text( - text = "Clear all ✕", + text = stringResource(R.string.i18n_app__global_clear_all) + " ✕", fontWeight = FontWeight.Bold, color = MaterialTheme.colorScheme.onPrimary, style = MaterialTheme.typography.bodySmall, diff --git a/app/src/main/java/be/scri/ui/screens/ConjugationSelectionScreen.kt b/app/src/main/java/be/scri/ui/screens/ConjugationSelectionScreen.kt index 5e6919acd..2dba1dd2b 100644 --- a/app/src/main/java/be/scri/ui/screens/ConjugationSelectionScreen.kt +++ b/app/src/main/java/be/scri/ui/screens/ConjugationSelectionScreen.kt @@ -199,7 +199,7 @@ fun ConjugationSelectionScreen( modifier = Modifier.fillMaxWidth(0.9f), ) { DropdownMenuItem( - text = { Text("All tenses") }, + text = { Text(stringResource(R.string.i18n_app_conjugate_choose_conjugation_all_tenses)) }, onClick = { selectedTenseGroup = null expanded = false diff --git a/app/src/main/java/be/scri/ui/screens/tutorial/TutorialHomeScreen.kt b/app/src/main/java/be/scri/ui/screens/tutorial/TutorialHomeScreen.kt index 02755c9be..59c719b20 100644 --- a/app/src/main/java/be/scri/ui/screens/tutorial/TutorialHomeScreen.kt +++ b/app/src/main/java/be/scri/ui/screens/tutorial/TutorialHomeScreen.kt @@ -156,7 +156,7 @@ fun TutorialHomeScreen( ) Icon( imageVector = Icons.AutoMirrored.Filled.KeyboardArrowRight, - contentDescription = "Go to ${chapter.title}", + contentDescription = stringResource(R.string.i18n_app_accessibility_go_to_chapter).replace("{title}", chapter.title), tint = secondaryTextColor, ) } diff --git a/app/src/main/res/values/string.xml b/app/src/main/res/values/string.xml index 117e89231..1d940d99b 100644 --- a/app/src/main/res/values/string.xml +++ b/app/src/main/res/values/string.xml @@ -50,6 +50,7 @@ Wikidata is a collaboratively edited multilingual knowledge graph hosted by the Wikimedia Foundation. It provides freely available data that anyone can use under a Creative Commons Public Domain license (CC0). Scribe uses language data from Wikidata to provide users with verb conjugations, noun-form annotations, noun plurals, and many other features. Wikipedia is a multilingual free online encyclopedia written and maintained by a community of volunteers through open collaboration and a wiki-based editing system. Scribe uses data from Wikipedia to produce autosuggestions by deriving the most common words in a language as well as the most common words that follow them. Report a bug + No browser found to open {store} page Rate Scribe Conjugate Rate us on Amazon Appstore Rate us on F-Droid @@ -75,6 +76,7 @@ Clear Copy conjugation Expand tenses + Go to {title} Leading icon Play button Right Arrow @@ -87,6 +89,7 @@ Copy to clipboard Clipboard Download verb data with the menu below to start conjugating verbs. + All tenses Select tense Choose a conjugation below Data not present in Wikidata