issue with Node.adjust()

[cjcliffe]

Seems to be an issue on the following line:

https://github.com/secretrobotron/octree.js/blob/master/octree.js#L256

where "containsPoint" is used as containsPoint( minpoint, aabb ) and containsPoint( maxpoint, aabb ) when the function definition is containsPoint ( aabb, point ) which seems contrary.

Having issues using adjust() using any combination of logical substitutions for the issue here (flipping parameters, swapping index and both); visibility shows popping of objects.

Manually removing and inserting the object from the tree prevents popping but is much slower than calls to adjust()

[secretrobotron]

That does look wrong. I recall that section being a work in progress as I attempted to write tests for it.

You did try switching them around, and had the same results?

[cjcliffe]

yeah, tried all the combinations I could think would be possible with those two vars; seemed about the same result either way

[cjcliffe]

Any update on this? I've got an awesome new lighting/visibility system in CubicVR.js that's just been waiting for a fix to this function.

[secretrobotron]

I'm working on it, actually. The code was just incomplete because my place
ride ended. Adjust needed to be reworked. Some cleanup and goodies coming.
On Apr 6, 2013 5:10 PM, "Charles J. Cliffe" notifications@github.com
wrote:

Any update on this? I've got an awesome new lighting/visibility system in
CubicVR.js that's just been waiting for a fix to this function.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-16004128
.

[cjcliffe]

.... ?

I can do without any goodies or cleanup, I just need adjust() to work with the code I have -- this has been waiting for a couple months now :)

[cjcliffe]

@secretrobotron

[rpsirois]

I'm not sure where the bug is (I ported part of this code for my own implementation), but wouldn't it be easier to clear the data, re-insert the node, then bubble up an event that removes the leaves if they have no data?

Btw, are Gladius and friends still under development? Doesn't seem like there's a lot of activity.

[secretrobotron]

Sorry guys. Thought I'd have some time recently to pour more into this problem. I inspected the code though, and it doesn't look quite right. The previous version of Octree (in an older version of CubicVR) was correct.

It would be easier to clear the data and re-insert the node (perfect workaround for the time being), but adjust was supposed to alleviate the need to pull it back out to the top of the tree by remembering some data about how it made it down to its current position.

AFAIK, Gladius isn't really under development now, but the team does other things that are related. Happy to introduce you if you're interested.

If you guys need this code to be working in the short term, I'm happy to push some other things out of the way to spend some more time with it. How urgent?

[rpsirois]

Not urgent at all. Thanks for the update! I'm pretty much a graphics noob... mostly just tinkering around. Thanks for writing the code, though! It helped me quite a bit.