From bcc7704b9626bba705726d6919426b9304ca67e1 Mon Sep 17 00:00:00 2001 From: Michael Young Date: Tue, 29 Sep 2026 09:24:26 +0100 Subject: [PATCH 1/3] Remove deprecated pkgname flag to Autodoc --- makedoc.g | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makedoc.g b/makedoc.g index a115b7b98..6378ece13 100644 --- a/makedoc.g +++ b/makedoc.g @@ -124,7 +124,7 @@ XMLEntities.bbN := """\mathbb{N} # The actual call to AutoDoc -AutoDoc("semigroups", rec( +AutoDoc(rec( autodoc := rec(scan_dirs := ["gap/tools/", "gap/attributes"]), gapdoc := rec( LaTeXOptions := rec(EarlyExtraPreamble := """ From f89532181113ba4439c6e12e1ebe5851fd7a0c66 Mon Sep 17 00:00:00 2001 From: James Mitchell Date: Mon, 28 Sep 2026 09:42:52 +0100 Subject: [PATCH 2/3] ci: add GAP 4.16 drop 4.12 --- .github/workflows/standard.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/standard.yml b/.github/workflows/standard.yml index ad96941a4..c95432722 100644 --- a/.github/workflows/standard.yml +++ b/.github/workflows/standard.yml @@ -29,10 +29,10 @@ jobs: - macOS gap-version: - master + - v4.16 - v4.15 - v4.14 - v4.13 - - v4.12 configflags: - "--disable-hpcombi" From d7234d360cb38114951915d5db71e01a55e78ec1 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Thu, 8 Oct 2026 15:26:59 +0200 Subject: [PATCH 3/3] Fix detection of GAP strings ... by using IS_STRING_REP: this then also covers sorted and unsorted strings. Of the following six strings, the old code only accepted the first two. gap> t:="str";; TNUM_OBJ(t); 72 gap> t:=Immutable("str");; TNUM_OBJ(t); 73 gap> t:="cba";;IsSet(t);; TNUM_OBJ(t); 74 gap> t:=Immutable("cba");;IsSet(t);; TNUM_OBJ(t); 75 gap> t:="abc";;IsSet(t);; TNUM_OBJ(t); 76 gap> t:=Immutable("abc");;IsSet(t);; TNUM_OBJ(t); 77 --- src/to-cpp.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/to-cpp.hpp b/src/to-cpp.hpp index 1ee71bb61..d7bfdce0c 100644 --- a/src/to-cpp.hpp +++ b/src/to-cpp.hpp @@ -390,7 +390,7 @@ namespace gapbind14 { static gap_tnum_type constexpr gap_type = T_STRING; cpp_type operator()(Obj o) const { - if (TNUM_OBJ(o) != T_STRING && TNUM_OBJ(o) != T_STRING + IMMUTABLE) { + if (!IS_STRING_REP(o)) { ErrorQuit("expected string but got %s!", (Int) TNAM_OBJ(o), 0L); } std::string stype = std::string(CSTR_STRING(o)); @@ -412,7 +412,7 @@ namespace gapbind14 { cpp_type operator()(Obj o) const { using Order = libsemigroups::Order; - if (TNUM_OBJ(o) != T_STRING && TNUM_OBJ(o) != T_STRING + IMMUTABLE) { + if (!IS_STRING_REP(o)) { ErrorQuit("expected string but got %s!", (Int) TNAM_OBJ(o), 0L); } std::string_view stype = CSTR_STRING(o);