From a3ad442c726131d5df9f5245abc66a8d87922e45 Mon Sep 17 00:00:00 2001 From: Declan McKenna Date: Fri, 9 Oct 2026 15:07:01 +0100 Subject: [PATCH] Retire the org workflow templates: callers/ is the only copy No repo had been installed from the sentfutures/.github templates, repos under personal accounts can't see them, and keeping the second copy in sync had failed twice. sentfutures/.github#5 deletes them; this drops the mirror notes and rule, and points the manual install at callers/. --- CLAUDE.md | 10 ++++++---- README.md | 22 +++++++++++++--------- callers/claude-mention.caller.yml | 3 --- callers/claude-pr-review.caller.yml | 3 --- 4 files changed, 19 insertions(+), 19 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index 9bb187f..e6421c1 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -38,8 +38,7 @@ Nothing runs locally. Changes are tested and released by the PR flow itself: event. Rollback is re-pointing the tag: `git push origin +:refs/tags/v1`. - **Breaking changes** (renamed/removed input) must not ride `v1`: tag `v2`, - update `callers/` and the `sentfutures/.github` templates to `@v2`, add a - README changelog entry. + update `callers/` to `@v2`, add a README changelog entry. To exercise the plugin skills locally: `/plugin marketplace add sentfutures/devops` then @@ -142,8 +141,11 @@ reintroduce. ## Files that move together -- `callers/*.caller.yml` are **mirrored** as org workflow templates in - `sentfutures/.github/workflow-templates/` — update both. +- `callers/*.caller.yml` are the only copy of the callers. The org workflow + templates that mirrored them in `sentfutures/.github` were retired on + 2026-10-09 (sentfutures/.github#5): no repo had been installed from them, + repos under personal accounts can't see org templates, and the copy + drifted. Don't re-add them without a sync check. - `skills/pr-review-watch/SKILL.md` is the **canonical** copy; consuming repos hold copies under `.claude/skills/`. Improve it here, and keep the "In this repo (fill in at install…)" section as a fill-in template. diff --git a/README.md b/README.md index 021db83..db60650 100644 --- a/README.md +++ b/README.md @@ -92,13 +92,18 @@ person opens a PR. 1. **Label** — create `needs-human-review` in the repo (Issues → Labels). A missing label only degrades to a warning in the run log, so do it up front where it's visible. -2. **Workflows** — repo → Actions → New workflow → under **"By sentfutures"** - choose **"Claude PR review bot — reviews every PR"** → Configure → replace - the two `FILL_ME_IN` values (`required_check`: your CI check's name as it - appears on a PR, or delete the line if there is none; `escalate_to`: - maintainer GitHub logins) → commit. Repeat for **"Claude @mention handler - — on-demand"** (nothing to fill in). Equivalent: copy both files from this - repo's `callers/` into your `.github/workflows/`. +2. **Workflows** — copy `callers/claude-pr-review.caller.yml` and + `callers/claude-mention.caller.yml` from this repo into your + `.github/workflows/` as `claude-pr-review.yml` and `claude-mention.yml`. + In the review caller, replace the two `FILL_ME_IN` values: + - `required_check`: your CI check's name as it appears on a PR, or delete + the line if there is none. + - `escalate_to`: maintainer GitHub logins. + + The mention caller has nothing to fill in. Commit both. (Until 2026-10-09 + these were also offered as org workflow templates in `sentfutures/.github`. + They were retired: no repo had been set up from them, repos under personal + accounts can't see org templates, and the second copy kept drifting.) 3. **Skill** — copy `skills/pr-review-watch/` from this repo into your repo's `.claude/skills/` and complete its "In this repo" fill-in bullets from your repo's own CLAUDE.md and CI. That skill is how a Claude Code session @@ -227,8 +232,7 @@ Three tiers, in order of how often they should happen: Code: *"in sentfutures/devops, add to the review bot's prompt and open a PR"*. 3. **Breaking changes** (rename/remove an input): do not ride `v1`. Tag `v2`, - update `callers/` and the `sentfutures/.github` templates to `@v2`, and - add a changelog entry below. + update `callers/` to `@v2`, and add a changelog entry below. 4. **Never** edit the verdict-verification step's jq or the tool allowlist without reading their inline comments first — each line exists because of a production incident, and the selftest may not catch the failure mode you diff --git a/callers/claude-mention.caller.yml b/callers/claude-mention.caller.yml index 9ac0ffa..24b8c49 100644 --- a/callers/claude-mention.caller.yml +++ b/callers/claude-mention.caller.yml @@ -8,9 +8,6 @@ name: Claude mention handler # # NOTE the permissions: this handler gets contents: write (it can push # commits when asked to) — a deliberately broader grant than the review bot's. -# -# This file is mirrored as an org workflow template in sentfutures/.github — -# keep the two in sync when editing. on: issue_comment: types: [created] diff --git a/callers/claude-pr-review.caller.yml b/callers/claude-pr-review.caller.yml index 2a1054d..4681fa5 100644 --- a/callers/claude-pr-review.caller.yml +++ b/callers/claude-pr-review.caller.yml @@ -5,9 +5,6 @@ name: Claude PR review bot # (.github/workflows/claude-pr-review.yml); this file only carries the # triggers and this repo's own settings. Setup steps (app install, secret # access, label, branch protection): see the sentfutures/devops README. -# -# This file is mirrored as an org workflow template in sentfutures/.github — -# keep the two in sync when editing. on: pull_request: # `edited` re-reviews when a stacked PR retargets its base branch (GitHub