Skip to content

Declare optional arguments on ABCDatabase.*_access methods  #613

Description

@flongford

Not all of the The ABCDatabase.grant_access and ABCDatabase.revoke_access method arguments appear to be required.

def grant_access(self, app_name, user_name, app_license,
allow_home, allow_view, volume, allow_startup_data):

def revoke_access(self, app_name, user_name, app_license,
allow_home, allow_view, volume, allow_startup_data):

In fact all of them except app_name and user_name could probably be made optional with given defaults, since our implementations already expect to handle falsy values anyway.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions