Skip to content

Check submodules' commits #9

Description

@alyapunov

There are two common mistakes that are comparably easy to make and have significant consequences.

  1. Submodule was updated by mistake.
  2. Submodule was updated to a wrong commit that is not in master branch of the submodule.

It would be great if checkpatch could find those mistakes.

  1. Let's introduce a special commit message tag, that shows that submodule update was intended. Something like "UPDATE_SUBMODULE=". Don't allow commits with submodule update without appropriate commit message tags.
  2. Let's check that submodule commit is in master tree. Perhaps it can be done as in tarantool/tools/check_push_master.sh, it should be investigated. And perhaps having done that, check_push_master.sh must be removed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureA new functionality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions