From bfe295a11e7e69611095ab354597799b52edcc23 Mon Sep 17 00:00:00 2001 From: Reem Alhazmi Date: Wed, 16 Sep 2026 17:26:42 +1000 Subject: [PATCH] fix(config): remove dead scheduler configuration --- config/schedule.rb | 5 ----- config/schedule.yml | 3 +++ test/config/scheduler_configuration_test.rb | 17 +++++++++++++++++ 3 files changed, 20 insertions(+), 5 deletions(-) delete mode 100644 config/schedule.rb create mode 100644 test/config/scheduler_configuration_test.rb diff --git a/config/schedule.rb b/config/schedule.rb deleted file mode 100644 index 93f33fc11a..0000000000 --- a/config/schedule.rb +++ /dev/null @@ -1,5 +0,0 @@ -set :output, "#{path}/log/cron.log" - -every 1.day, at: '3:00 am' do - rake 'db:update_temporal' -end diff --git a/config/schedule.yml b/config/schedule.yml index 62fd893daf..c98d577a5a 100644 --- a/config/schedule.yml +++ b/config/schedule.yml @@ -1,3 +1,6 @@ +# Schedules are owned by Sidekiq-cron and .ci-setup/crontab: +# Sidekiq-cron owns in-process scheduled jobs. +# .ci-setup/crontab owns the container's rake schedule. # config/schedule.yml register_webhooks: diff --git a/test/config/scheduler_configuration_test.rb b/test/config/scheduler_configuration_test.rb new file mode 100644 index 0000000000..c0b542bd27 --- /dev/null +++ b/test/config/scheduler_configuration_test.rb @@ -0,0 +1,17 @@ +require "test_helper" + +class SchedulerConfigurationTest < ActiveSupport::TestCase + test "dead whenever schedule is removed" do + dead_schedule = Rails.root.join("config/schedule.rb") + + refute dead_schedule.exist?, + "config/schedule.rb should be removed because whenever is not installed" + end + + test "schedule owners are documented" do + schedule = Rails.root.join("config/schedule.yml").read + + assert_includes schedule.lines.first, "Sidekiq-cron" + assert_includes schedule.lines.first, ".ci-setup/crontab" + end +end