From 8fe9eb793d4654faf65585a28629fb0922d8afe9 Mon Sep 17 00:00:00 2001 From: Matthew Farrell Date: Sat, 19 Sep 2026 23:06:01 -0400 Subject: [PATCH] Use if-let*/when-let* (if-let/when-let obsolete in Emacs 31) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Emacs 31.1 marked `if-let', `when-let' and `and-let' obsolete in favour of the starred variants. Because julia-repl.el sets `no-byte-compile: t', it is macroexpanded at load time, so every Emacs 31 user sees these warnings whenever julia-repl is loaded: julia-repl.el: Warning: ‘if-let’ is an obsolete macro (as of 31.1); use ‘if-let*’ instead. [5 times] julia-repl.el: Warning: ‘when-let’ is an obsolete macro (as of 31.1); use ‘when-let*’ or ‘and-let*’ instead. All six call sites bind a single variable, so the rewrite is semantics-preserving. `if-let*' and `when-let*' have existed since Emacs 26.1, well below the package's 29.1 requirement. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01ETZ3Po9TDsuH7aNhtvkZcb --- julia-repl.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/julia-repl.el b/julia-repl.el index fb99ae2..f91722a 100644 --- a/julia-repl.el +++ b/julia-repl.el @@ -152,7 +152,7 @@ When PASTE-P, “bracketed paste” mode will be used. When RET-P, terminate wit (cl-defmethod julia-repl--locate-live-buffer ((_terminal-backend julia-repl--buffer-ansi-term) name) - (if-let ((inferior-buffer (get-buffer (julia-repl--add-earmuffs name)))) + (if-let* ((inferior-buffer (get-buffer (julia-repl--add-earmuffs name)))) (with-current-buffer inferior-buffer (cl-assert (eq major-mode 'term-mode) nil "Expected term-mode. Changed mode or backends?")) (when (term-check-proc inferior-buffer) @@ -206,7 +206,7 @@ When PASTE-P, “bracketed paste” mode will be used. When RET-P, terminate wit (cl-defmethod julia-repl--locate-live-buffer ((_terminal-backend julia-repl--buffer-vterm) name) - (if-let ((inferior-buffer (get-buffer (julia-repl--add-earmuffs name)))) + (if-let* ((inferior-buffer (get-buffer (julia-repl--add-earmuffs name)))) (with-current-buffer inferior-buffer (cl-assert (eq major-mode 'vterm-mode) nil "Expected vterm-mode. Changed mode or backends?") (when (vterm-check-proc inferior-buffer) @@ -243,7 +243,7 @@ When PASTE-P, “bracketed paste” mode will be used. When RET-P, terminate wit (cl-defmethod julia-repl--locate-live-buffer ((_terminal-backend julia-repl--buffer-eat) name) - (if-let ((inferior-buffer (get-buffer (julia-repl--add-earmuffs name)))) + (if-let* ((inferior-buffer (get-buffer (julia-repl--add-earmuffs name)))) (with-current-buffer inferior-buffer (cl-assert (eq major-mode 'eat-mode) nil "Expected eat-mode. Changed mode or backends?") (when (eat-term-live-p inferior-buffer) @@ -866,7 +866,7 @@ name), separated by dots, as a list." (defun julia-repl-cd () "Change directory to the directory of the current buffer (if applicable)." (interactive) - (if-let ((directory (file-name-directory (buffer-file-name)))) + (if-let* ((directory (file-name-directory (buffer-file-name)))) (progn (julia-repl--send-string (concat "cd(\"" (julia-repl--path-rewrite directory julia-repl-path-rewrite-rules) @@ -891,7 +891,7 @@ When called with a prefix argument, activate the home project." (progn (message "activating home project") (julia-repl--send-string "import Pkg; Pkg.activate()")) - (if-let ((projectfile (julia-repl-find-projectfile))) + (if-let* ((projectfile (julia-repl-find-projectfile))) (progn (message "activating %s" projectfile) (julia-repl--send-string @@ -961,7 +961,7 @@ be added." (,(kbd "C-c C-v") . julia-repl-prompt-set-executable-key) (,(kbd "C-c C-z") . julia-repl) (,(kbd "") . julia-repl-send-line)) - (when-let ((filename (buffer-file-name))) + (when-let* ((filename (buffer-file-name))) (setq-local default-directory (file-name-directory filename)))) (provide 'julia-repl)