From 92032d9d6c43fef1aa4be5de467d4da0cbff6139 Mon Sep 17 00:00:00 2001
From: m-vawter <mvawter@protonmail.com>
Date: Fri, 2 Oct 2026 20:57:13 -0400
Subject: [PATCH] fix(chat): Ask Agent to Fix reaches the agent when Agent Chat
 was closed (#92)

askFix reopened the chat window, but its ref was still null in the same
tick, so sendMessage was skipped silently. Wait one tick for the window to
mount before sending. A new e2e spec closes Agent Chat, breaks an app, and
asks the agent to fix it (red before this change, green after).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 app/app.vue                           |  6 ++--
 tests/e2e/ask-fix-chat-closed.spec.ts | 46 +++++++++++++++++++++++++++
 2 files changed, 50 insertions(+), 2 deletions(-)
 create mode 100644 tests/e2e/ask-fix-chat-closed.spec.ts

diff --git a/app/app.vue b/app/app.vue
index 32129f5..0659198 100644
--- a/app/app.vue
+++ b/app/app.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { onMounted, reactive, ref, type ComponentPublicInstance } from "vue";
+import { nextTick, onMounted, reactive, ref, type ComponentPublicInstance } from "vue";
 import { useOsStore } from "./features/os/stores/os";
 import { useAppsStore } from "./features/apps/stores/apps";
 import WindowFrame from "./features/os/components/WindowFrame.vue";
@@ -81,12 +81,14 @@ function getAppSource(id: string) {
   return app ? readFile(app.entry) : null;
 }
 
-function askFix(payload: { appId: string; error: string; sourceCode?: string }) {
+async function askFix(payload: { appId: string; error: string; sourceCode?: string }) {
   const chatWin = os.windows.find((w) => w.appId === 'chat');
   if (chatWin) {
     os.focusWindow(chatWin.id);
   } else {
     openBuiltin('chat');
+    // The chat window mounts on the next render; wait for its ref before sending.
+    await nextTick();
   }
 
   const app = getApp(payload.appId);
diff --git a/tests/e2e/ask-fix-chat-closed.spec.ts b/tests/e2e/ask-fix-chat-closed.spec.ts
new file mode 100644
index 0000000..757124d
--- /dev/null
+++ b/tests/e2e/ask-fix-chat-closed.spec.ts
@@ -0,0 +1,46 @@
+import { expect, test } from '@playwright/test'
+import { stubAgentReply } from './support/agent-stub'
+import { appWindow, dominicHooks, keepRequestsLocal, openDesktop } from './support/desktop'
+
+// #92: "Ask Agent to Fix" must reach the agent even when Agent Chat was
+// closed. The click reopens the chat window; the message has to wait for that
+// window to mount instead of being dropped.
+
+const REPAIRED_APP = `<template>
+  <div class="p-6">
+    <h2>{{ status }}</h2>
+  </div>
+</template>
+
+<script setup>
+import { ref } from 'vue'
+const status = ref('Repaired by the agent')
+</script>
+`
+
+test.beforeEach(async ({ page, baseURL }) => {
+  await keepRequestsLocal(page, baseURL)
+})
+
+test('Ask Agent to Fix reopens a closed Agent Chat and still reaches the agent', async ({ page }) => {
+  const dominic = dominicHooks(page)
+  const chat = appWindow(page, 'Agent Chat')
+  const broken = appWindow(page, 'Broken (Syntax Error)')
+  await openDesktop(page)
+
+  await chat.getByRole('button', { name: 'Close' }).click()
+  await expect(chat).toHaveCount(0)
+
+  await dominic.injectBrokenApp('compile')
+  await expect(broken.getByText('Component Compilation Error')).toBeVisible()
+
+  const requests = await stubAgentReply(page, {
+    text: 'Found the bug; sending a fixed version.',
+    updateApp: { id: 'broken-app', vueSfcCode: REPAIRED_APP, summary: 'Fix the deliberate error' },
+  })
+  await broken.getByRole('button', { name: 'Ask Agent to Fix' }).click()
+
+  await expect(chat).toBeVisible()
+  await expect(broken.getByRole('heading', { name: 'Repaired by the agent' })).toBeVisible()
+  expect(requests).toHaveLength(1)
+})