Repository navigation
Let findings be dismissed as false positives or accepted risk - #33
Merged
Merged
Conversation
Each issue now carries a fingerprint: its node, type, identifying fields and message, leaving out what shifts between runs (line numbers, latest version, commit ages, digits in the message). Dismissals are stored per repository or action in data/dismissals.json and applied when an audit is built and whenever a stored analysis is read, so they hold across re-runs. Dismissed issues drop out of node counts, severity and statistics; dismissed_issues counts them. The issue details panel gets Dismiss (with an optional reason) and Restore. Every view works on active findings; the findings table can show dismissed ones. Findings reported twice on one node are now counted and listed once. Closes #22 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying actsense with
|
| Latest commit: |
14eab24
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5fd233a1.actsense.pages.dev |
| Branch Preview URL: | https://feat-dismiss-findings.actsense.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22.
What it does
How
backend/dismissals.py: every issue gets afingerprint: a hash of its node id, type, identifying fields and message, leaving out what shifts between runs (line_number,latest_version,days_old,commit_date, digits in the message). A finding mirrored onto a package or image node shares its source's fingerprint.DismissalStorekeeps dismissals per target indata/dismissals.json. They are applied when an audit is built and whenever a stored analysis is read.GraphBuilderleaves dismissed issues out ofissue_count, nodeseverityand the statistics, and addsdismissed_issues. It can also rebuild itself from stored graph data.POST /api/analyses/{id}/dismissals,DELETE /api/analyses/{id}/dismissals/{fingerprint},GET /api/dismissals?target=.Worth knowing
unfiltered_network_trafficsometimes reports the exact same finding twice on one workflow. It's now counted and listed once, so some existing analyses show two fewer findings.Testing
🤖 Generated with Claude Code