Stop leaking test servers - #2497
Open
Mirko-von-Leipzig wants to merge 2 commits into
Open
Conversation
SantiagoPittella
approved these changes
Aug 21, 2026
| } | ||
| .serve(shutdown) | ||
| .await | ||
| .expect("Failed to start serving store"); |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| .expect("Failed to start serving store"); | |
| .expect("Failed to start serving RPC"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our RPC tests contain the block producer API, which internally spawns the mempool monitoring task. This task is never cancelled and leaks. Not the biggest deal, but since this is part of the public API of the block producer crate, I thought I'd fix it.
I'm also okay with dropping this PR as unnecessary fluff.
Changelog