Repository navigation
Conversation
There was a problem hiding this comment.
Review conclusion
The production deployment change keeps image replacement gated behind three sequential service builds, and the added image-content checks correctly distinguish the user frontend from the Admin build using the Admin Vite base path. The explicit deploy-frontend:latest and deploy-admin:latest tags match the production Compose definitions, so the validation examines the same images later consumed by up --no-build.
Verified with bash -n, git diff --check, focused positive/negative fingerprint checks, and the passing deployment-script CI job. I found no actionable correctness, reliability, security, or maintainability regressions in the fixed diff.
…uction-frontend-image-swap
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build backend, user frontend, and Admin images sequentially, then validate the frontend image contents before replacing production containers.\n\nCloses #184