Skip to content

fix(deploy): prevent frontend image tag swaps - #185

Open
fj-sunny wants to merge 7 commits into
1024XEngineer:mainfrom
fj-sunny:codex/fix-production-frontend-image-swap
Open

fj-sunny wants to merge 7 commits into
1024XEngineer:mainfrom
fj-sunny:codex/fix-production-frontend-image-swap

Conversation

@fj-sunny

Copy link
Copy Markdown
Contributor

Build backend, user frontend, and Admin images sequentially, then validate the frontend image contents before replacing production containers.\n\nCloses #184

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review conclusion

The production deployment change keeps image replacement gated behind three sequential service builds, and the added image-content checks correctly distinguish the user frontend from the Admin build using the Admin Vite base path. The explicit deploy-frontend:latest and deploy-admin:latest tags match the production Compose definitions, so the validation examines the same images later consumed by up --no-build.

Verified with bash -n, git diff --check, focused positive/negative fingerprint checks, and the passing deployment-script CI job. I found no actionable correctness, reliability, security, or maintainability regressions in the fixed diff.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant