Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
Calldatalib toCalldataSliceto clarify the purposeImplement
CalldataParselib allowing efficient packed value parseNote
Low Risk
Changes are limited to new parsing utilities and a library rename with test-only call sites; no bounds checking in
CalldataParseis intentional but callers must enforce offsets themselves.Overview
Introduces
CalldataParse, a gas-oriented library for reading left-aligned packed values frombytes calldataviaat(shift)→CalldataWord→as*helpers (addresses,uint8–uint256,bytes1–bytes32, and MSB-indexedasBool).atuses inlinecalldataloadand does not bounds-check, as documented.Renames the existing slicing library from
CalldatatoCalldataSlice(samesliceAPIs and behavior) and updatesCalldataSliceMock/CalldataSlice.test.tsaccordingly.Adds
CalldataParseMockand a Hardhat suiteCalldataParse.test.tscovering byte offsets, bool bit extraction, addresses, and all supporteduintN/bytesNwidths.Reviewed by Cursor Bugbot for commit 7da967e. Bugbot is set up for automated code reviews on this repo. Configure here.